[BridgeJS] Address PR feedback and refresh generated artifacts

- Make `accessLevel` decode-tolerant on imported skeleton structs
  (`ImportedFunctionSkeleton`, `ImportedConstructorSkeleton`,
  `ImportedGetterSkeleton`, `ImportedSetterSkeleton`,
  `ImportedTypeSkeleton`) by writing explicit `init(from:)` decoders
  that fall back to `.internal` when the key is missing. Without this,
  any pre-existing skeleton JSON without the new field fails decoding —
  the `build-examples` CI job hit `DecodingError.keyNotFound` for
  `accessLevel` against externally consumed skeletons.
- Extract a private `recordSignature` helper so `visitClosure` and
  `recordInjectedSignature` share a single merge implementation.
- Assert in `withAccessLevel(rawLevel:)` so unknown access strings
  ("open", "private", future schema additions) surface in debug
  builds instead of silently inheriting the outer level.
- Document the `.internal` seeding assumption on
  `ClosureSignatureCollectorVisitor.init(moduleName:signatures:)`.
- Regenerate the BridgeJS pre-generated artifacts under Benchmarks/,
  Examples/PlayBridgeJS/, Tests/BridgeJSIdentityTests/, and
  Tests/BridgeJSRuntimeTests/ via `./Utilities/bridge-js-generate.sh`,
  per CONTRIBUTING.md. The runtime-tests Swift output now emits
  `public init` on three `JSTypedClosure` extensions whose signatures
  surface through public exported types.

Author: matthewa26

Benchmarks/Sources/Generated/JavaScript/BridgeJS.json

@@ -3339,6 +3339,7 @@
       {
         "functions" : [
           {
+            "accessLevel" : "internal",
             "effects" : {
               "isAsync" : false,
               "isStatic" : false,
@@ -3355,6 +3356,7 @@
             }
           },
           {
+            "accessLevel" : "internal",
             "effects" : {
               "isAsync" : false,
               "isStatic" : false,
@@ -3378,6 +3380,7 @@
             }
           },
           {
+            "accessLevel" : "internal",
             "effects" : {
               "isAsync" : false,
               "isStatic" : false,

Examples/PlayBridgeJS/Sources/PlayBridgeJS/Generated/JavaScript/BridgeJS.json

@@ -242,6 +242,7 @@
       {
         "functions" : [
           {
+            "accessLevel" : "internal",
             "effects" : {
               "isAsync" : false,
               "isStatic" : false,
@@ -260,11 +261,13 @@
         ],
         "types" : [
           {
+            "accessLevel" : "internal",
             "getters" : [
 
             ],
             "methods" : [
               {
+                "accessLevel" : "internal",
                 "effects" : {
                   "isAsync" : false,
                   "isStatic" : false,

Plugins/BridgeJS/Sources/BridgeJSSkeleton/BridgeJSSkeleton.swift

@@ -612,12 +612,22 @@ public struct BridgeSkeletonWalker<Visitor: BridgeSkeletonVisitor> {
     }
 
     /// String-typed convenience: maps `"public"`/`"package"`/`"internal"` from
-    /// `Exported*.explicitAccessControl` to the typed enum.
+    /// `Exported*.explicitAccessControl` to the typed enum. Unknown strings
+    /// (e.g. `"open"`, `"private"`) hit the assert in debug builds and inherit
+    /// the outer level in release — the `@JSExport` macros reject those cases
+    /// upstream, so this is a defensive guard against future schema drift.
     private mutating func withAccessLevel(
         _ rawLevel: String?,
         _ body: (inout BridgeSkeletonWalker) -> Void
     ) {
-        withAccessLevel(rawLevel.flatMap(BridgeJSAccessLevel.init(rawValue:)), body)
+        let level: BridgeJSAccessLevel?
+        if let rawLevel {
+            level = BridgeJSAccessLevel(rawValue: rawLevel)
+            assert(level != nil, "Unexpected access level string: \(rawLevel)")
+        } else {
+            level = nil
+        }
+        withAccessLevel(level, body)
     }
 }
 
@@ -1063,6 +1073,22 @@ public struct ImportedFunctionSkeleton: Codable {
         self.accessLevel = accessLevel
     }
 
+    private enum CodingKeys: String, CodingKey {
+        case name, jsName, from, parameters, returnType, effects, documentation, accessLevel
+    }
+
+    public init(from decoder: any Decoder) throws {
+        let container = try decoder.container(keyedBy: CodingKeys.self)
+        self.name = try container.decode(String.self, forKey: .name)
+        self.jsName = try container.decodeIfPresent(String.self, forKey: .jsName)
+        self.from = try container.decodeIfPresent(JSImportFrom.self, forKey: .from)
+        self.parameters = try container.decode([Parameter].self, forKey: .parameters)
+        self.returnType = try container.decode(BridgeType.self, forKey: .returnType)
+        self.effects = try container.decode(Effects.self, forKey: .effects)
+        self.documentation = try container.decodeIfPresent(String.self, forKey: .documentation)
+        self.accessLevel = try container.decodeIfPresent(BridgeJSAccessLevel.self, forKey: .accessLevel) ?? .internal
+    }
+
     public func abiName(context: ImportedTypeSkeleton?) -> String {
         return abiName(context: context, operation: nil)
     }
@@ -1087,6 +1113,16 @@ public struct ImportedConstructorSkeleton: Codable {
         self.accessLevel = accessLevel
     }
 
+    private enum CodingKeys: String, CodingKey {
+        case parameters, accessLevel
+    }
+
+    public init(from decoder: any Decoder) throws {
+        let container = try decoder.container(keyedBy: CodingKeys.self)
+        self.parameters = try container.decode([Parameter].self, forKey: .parameters)
+        self.accessLevel = try container.decodeIfPresent(BridgeJSAccessLevel.self, forKey: .accessLevel) ?? .internal
+    }
+
     public func abiName(context: ImportedTypeSkeleton) -> String {
         return ABINameGenerator.generateImportedABIName(
             baseName: "init",
@@ -1126,6 +1162,21 @@ public struct ImportedGetterSkeleton: Codable {
         self.accessLevel = accessLevel
     }
 
+    private enum CodingKeys: String, CodingKey {
+        case name, jsName, from, type, documentation, functionName, accessLevel
+    }
+
+    public init(from decoder: any Decoder) throws {
+        let container = try decoder.container(keyedBy: CodingKeys.self)
+        self.name = try container.decode(String.self, forKey: .name)
+        self.jsName = try container.decodeIfPresent(String.self, forKey: .jsName)
+        self.from = try container.decodeIfPresent(JSImportFrom.self, forKey: .from)
+        self.type = try container.decode(BridgeType.self, forKey: .type)
+        self.documentation = try container.decodeIfPresent(String.self, forKey: .documentation)
+        self.functionName = try container.decodeIfPresent(String.self, forKey: .functionName)
+        self.accessLevel = try container.decodeIfPresent(BridgeJSAccessLevel.self, forKey: .accessLevel) ?? .internal
+    }
+
     public func abiName(context: ImportedTypeSkeleton?) -> String {
         if let functionName = functionName {
             return ABINameGenerator.generateImportedABIName(
@@ -1169,6 +1220,20 @@ public struct ImportedSetterSkeleton: Codable {
         self.accessLevel = accessLevel
     }
 
+    private enum CodingKeys: String, CodingKey {
+        case name, jsName, type, documentation, functionName, accessLevel
+    }
+
+    public init(from decoder: any Decoder) throws {
+        let container = try decoder.container(keyedBy: CodingKeys.self)
+        self.name = try container.decode(String.self, forKey: .name)
+        self.jsName = try container.decodeIfPresent(String.self, forKey: .jsName)
+        self.type = try container.decode(BridgeType.self, forKey: .type)
+        self.documentation = try container.decodeIfPresent(String.self, forKey: .documentation)
+        self.functionName = try container.decodeIfPresent(String.self, forKey: .functionName)
+        self.accessLevel = try container.decodeIfPresent(BridgeJSAccessLevel.self, forKey: .accessLevel) ?? .internal
+    }
+
     public func abiName(context: ImportedTypeSkeleton?) -> String {
         if let functionName = functionName {
             return ABINameGenerator.generateImportedABIName(
@@ -1224,6 +1289,24 @@ public struct ImportedTypeSkeleton: Codable {
         self.documentation = documentation
         self.accessLevel = accessLevel
     }
+
+    private enum CodingKeys: String, CodingKey {
+        case name, jsName, from, constructor, methods, staticMethods, getters, setters, documentation, accessLevel
+    }
+
+    public init(from decoder: any Decoder) throws {
+        let container = try decoder.container(keyedBy: CodingKeys.self)
+        self.name = try container.decode(String.self, forKey: .name)
+        self.jsName = try container.decodeIfPresent(String.self, forKey: .jsName)
+        self.from = try container.decodeIfPresent(JSImportFrom.self, forKey: .from)
+        self.constructor = try container.decodeIfPresent(ImportedConstructorSkeleton.self, forKey: .constructor)
+        self.methods = try container.decode([ImportedFunctionSkeleton].self, forKey: .methods)
+        self.staticMethods = try container.decode([ImportedFunctionSkeleton].self, forKey: .staticMethods)
+        self.getters = try container.decode([ImportedGetterSkeleton].self, forKey: .getters)
+        self.setters = try container.decode([ImportedSetterSkeleton].self, forKey: .setters)
+        self.documentation = try container.decodeIfPresent(String.self, forKey: .documentation)
+        self.accessLevel = try container.decodeIfPresent(BridgeJSAccessLevel.self, forKey: .accessLevel) ?? .internal
+    }
 }
 
 public struct ImportedFileSkeleton: Codable {
@@ -1298,6 +1381,12 @@ public struct ClosureSignatureCollectorVisitor: BridgeSkeletonVisitor {
     public var signatures: Set<ClosureSignature> { Set(signatureAccessLevels.keys) }
     let moduleName: String
 
+    /// Convenience for callers that only need to seed signatures without
+    /// access metadata (e.g. exported-side walking, where closure init access
+    /// is irrelevant because the synthesized init isn't surfaced to consumers).
+    /// All seeded signatures default to `.internal`; if a seeded signature is
+    /// later observed with a more permissive access level, the merge in
+    /// `recordSignature` upgrades it.
     public init(moduleName: String, signatures: Set<ClosureSignature> = []) {
         self.moduleName = moduleName
         for signature in signatures {
@@ -1309,6 +1398,18 @@ public struct ClosureSignatureCollectorVisitor: BridgeSkeletonVisitor {
         _ signature: ClosureSignature,
         useJSTypedClosure: Bool,
         accessLevel: BridgeJSAccessLevel
+    ) {
+        recordSignature(signature, accessLevel: accessLevel)
+    }
+
+    /// Insert `signature` at `accessLevel`, or upgrade the existing level to
+    /// the more permissive of the two. Centralizing the merge here keeps
+    /// `visitClosure` and `recordInjectedSignature` in lockstep — if the
+    /// merge policy ever needs to change (e.g. adding a diagnostic for
+    /// conflicting levels), there's only one place to update.
+    private mutating func recordSignature(
+        _ signature: ClosureSignature,
+        accessLevel: BridgeJSAccessLevel
     ) {
         if let existing = signatureAccessLevels[signature] {
             signatureAccessLevels[signature] = max(existing, accessLevel)
@@ -1367,11 +1468,7 @@ public struct ClosureSignatureCollectorVisitor: BridgeSkeletonVisitor {
         _ signature: ClosureSignature,
         for function: ImportedFunctionSkeleton
     ) {
-        if let existing = signatureAccessLevels[signature] {
-            signatureAccessLevels[signature] = max(existing, function.accessLevel)
-        } else {
-            signatureAccessLevels[signature] = function.accessLevel
-        }
+        recordSignature(signature, accessLevel: function.accessLevel)
     }
 }
 

Tests/BridgeJSIdentityTests/Generated/JavaScript/BridgeJS.json

@@ -410,6 +410,7 @@
         ],
         "types" : [
           {
+            "accessLevel" : "internal",
             "getters" : [
 
             ],
@@ -422,6 +423,7 @@
             ],
             "staticMethods" : [
               {
+                "accessLevel" : "internal",
                 "effects" : {
                   "isAsync" : false,
                   "isStatic" : false,

Tests/BridgeJSRuntimeTests/Generated/BridgeJS.swift

@@ -369,7 +369,7 @@ private enum _BJS_Closure_20BridgeJSRuntimeTests7GreeterC_SS {
 }
 
 extension JSTypedClosure where Signature == (Greeter) -> String {
-    init(fileID: StaticString = #fileID, line: UInt32 = #line, _ body: @escaping (Greeter) -> String) {
+    public init(fileID: StaticString = #fileID, line: UInt32 = #line, _ body: @escaping (Greeter) -> String) {
         self.init(
             makeClosure: make_swift_closure_BridgeJSRuntimeTests_20BridgeJSRuntimeTests7GreeterC_SS,
             body: body,
@@ -687,7 +687,7 @@ private enum _BJS_Closure_20BridgeJSRuntimeTestsSS_7GreeterC {
 }
 
 extension JSTypedClosure where Signature == (String) -> Greeter {
-    init(fileID: StaticString = #fileID, line: UInt32 = #line, _ body: @escaping (String) -> Greeter) {
+    public init(fileID: StaticString = #fileID, line: UInt32 = #line, _ body: @escaping (String) -> Greeter) {
         self.init(
             makeClosure: make_swift_closure_BridgeJSRuntimeTests_20BridgeJSRuntimeTestsSS_7GreeterC,
             body: body,
@@ -753,7 +753,7 @@ private enum _BJS_Closure_20BridgeJSRuntimeTestsSS_SS {
 }
 
 extension JSTypedClosure where Signature == (String) -> String {
-    init(fileID: StaticString = #fileID, line: UInt32 = #line, _ body: @escaping (String) -> String) {
+    public init(fileID: StaticString = #fileID, line: UInt32 = #line, _ body: @escaping (String) -> String) {
         self.init(
             makeClosure: make_swift_closure_BridgeJSRuntimeTests_20BridgeJSRuntimeTestsSS_SS,
             body: body,