From 4eb6f7248634acae127135c235dedb6cad37e7b8 Mon Sep 17 00:00:00 2001
From: Caio Pizzol <caio@superdoc.dev>
Date: Tue, 5 May 2026 08:23:12 -0300
Subject: [PATCH] fix(types): drop accidental BasicUpload public re-export
 (SD-2893)

BasicUpload was re-exported through `superdoc/super-editor` and
`superdoc` despite being marked `@internal` at the export site
(packages/super-editor/src/editors/v1/index.js:103). It is not
documented in any README, AGENTS guide, or example. The two dev
components that use it (SuperdocDev.vue, DeveloperPlayground.vue)
import it directly from `@superdoc/common/components/BasicUpload.vue`,
not via the public re-export.

Drop the re-export rather than relocating the .vue file. The upload
widget is dev-tooling, not a public API. The bare
`@superdoc/common/components/BasicUpload.vue` shim entry goes away
because no public d.ts file references it anymore.

Also removes the BasicUpload assertion from the consumer-typecheck
customer-scenario fixture so the matrix stays green; the fixture
was the only place the public re-export was exercised.

Shim count: 3 to 2. Remaining: @superdoc/common (5 dist refs,
catch-all bin), @superdoc/style-engine/ooxml (10 dist refs).

Verified: build:es clean (8 guarded packages, 2 shim modules),
consumer matrix 47/0/0, runtime smoke 4/4 with BasicUpload
explicitly asserted absent from main and super-editor entries.
---
 packages/super-editor/src/editors/v1/index.js     | 3 ---
 packages/superdoc/src/index.js                    | 2 --
 tests/consumer-typecheck/src/customer-scenario.ts | 2 --
 3 files changed, 7 deletions(-)

diff --git a/packages/super-editor/src/editors/v1/index.js b/packages/super-editor/src/editors/v1/index.js
index 7e2989eebc..0979a94485 100644
--- a/packages/super-editor/src/editors/v1/index.js
+++ b/packages/super-editor/src/editors/v1/index.js
@@ -33,7 +33,6 @@ import { Mark } from '@core/Mark.js';
 import ContextMenu from './components/context-menu/ContextMenu.vue';
 /** @deprecated Use ContextMenu instead */
 const SlashMenu = ContextMenu;
-import BasicUpload from '@superdoc/common/components/BasicUpload.vue';
 
 import SuperEditor from './components/SuperEditor.vue';
 import Toolbar from './components/toolbar/Toolbar.vue';
@@ -100,8 +99,6 @@ export {
   SuperEditor,
   /** @internal */
   SuperInput,
-  /** @internal */
-  BasicUpload,
   Toolbar,
   AIWriter,
   ContextMenu,
diff --git a/packages/superdoc/src/index.js b/packages/superdoc/src/index.js
index 1034020a8c..d0bf89b4ad 100644
--- a/packages/superdoc/src/index.js
+++ b/packages/superdoc/src/index.js
@@ -28,7 +28,6 @@ import {
   // Vue components
   SuperEditor,
   SuperInput,
-  BasicUpload,
   Toolbar,
   AIWriter,
   ContextMenu,
@@ -289,7 +288,6 @@ export {
   // Vue components
   SuperEditor,
   SuperInput,
-  BasicUpload,
   Toolbar,
   AIWriter,
   ContextMenu,
diff --git a/tests/consumer-typecheck/src/customer-scenario.ts b/tests/consumer-typecheck/src/customer-scenario.ts
index 2e685875bb..178a499167 100644
--- a/tests/consumer-typecheck/src/customer-scenario.ts
+++ b/tests/consumer-typecheck/src/customer-scenario.ts
@@ -42,7 +42,6 @@ import {
   CommentsPluginKey,
   SuperEditor,
   SuperInput,
-  BasicUpload,
   Toolbar,
   AIWriter,
   ContextMenu,
@@ -831,7 +830,6 @@ function testAdditionalClasses() {
 function testVueComponents() {
   const superEditor = SuperEditor;
   const superInput = SuperInput;
-  const basicUpload = BasicUpload;
   const toolbarComponent = Toolbar;
   const aiWriter = AIWriter;
   const contextMenu = ContextMenu;