From 39215423778c43c0361f3797751dd957b4e1adf0 Mon Sep 17 00:00:00 2001 From: Michael Keller Date: Mon, 11 May 2026 12:51:37 +1200 Subject: [PATCH] Shearwater: Fix the Firmware Version Decoding. Decode the Shearwater firmware version as BCD. Signed-off-by: Michael Keller --- src/shearwater_predator_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shearwater_predator_parser.c b/src/shearwater_predator_parser.c index 5b000807..c2968918 100644 --- a/src/shearwater_predator_parser.c +++ b/src/shearwater_predator_parser.c @@ -897,7 +897,7 @@ shearwater_predator_parser_cache (shearwater_predator_parser_t *parser) dc_field_add_string_fmt(&parser->cache, "Serial", "%08x", parser->serial); // bytes 1-31 are identical in all formats - dc_field_add_string_fmt(&parser->cache, STRING_KEY_FIRMWARE_VERSION, "%2x", data[19]); + dc_field_add_string_fmt(&parser->cache, STRING_KEY_FIRMWARE_VERSION, "%u", bcd2dec(data[19])); add_deco_model(parser, data); add_battery_type(parser, data); dc_field_add_string_fmt(&parser->cache, "Battery at end", "%.1f V", data[9] / 10.0);