Fix LM transition model restart and add automated regression test #2606

Author: guptapratykshh

SU2_CFD/src/solvers/CTransLMSolver.cpp

@@ -549,8 +549,7 @@ void CTransLMSolver::LoadRestart(CGeometry** geometry, CSolver*** solver, CConfi
 
         /*--- Note: Intermittency_Sep and Intermittency_Eff are derived variables computed in Postprocessing,
          *    not solution variables stored in the restart file. They will be recomputed after this function
-         *    completes. Previously, this code incorrectly tried to read them from indices [index+2] and [index+3],
-         *    which caused a buffer overflow since only nVar=2 solution variables are stored per point. ---*/
+         *    completes. ---*/
 
         /*--- Increment the overall counter for how many points have been loaded. ---*/
         counter++;

TestCases/serial_regression.py

@@ -569,6 +569,16 @@ def main():
     schubauer_klebanoff_transition.test_iter    = 10
     schubauer_klebanoff_transition.test_vals    = [-8.284308, -13.239421, 0.000057, 0.007982]
     test_list.append(schubauer_klebanoff_transition)
+ 
+    # LM Transition model restart
+    lm_transition_restart           = TestCase('lm_transition_restart')
+    lm_transition_restart.cfg_dir   = "transition/LM_NACA0012"
+    lm_transition_restart.cfg_file  = "trans_LM_restart.cfg"
+    lm_transition_restart.test_iter = 4
+    lm_transition_restart.test_vals = [-1.654301, -5.151570, -2.075488, 0.000000, 0.000000]
+    lm_transition_restart.tol = 0.001
+    test_list.append(lm_transition_restart)
+
 
     #####################################
     ### Cont. adj. compressible Euler ###

TestCases/transition/LM_NACA0012/restart_flow.dat

@@ -0,0 +1,31 @@
+SOLVER= RANS
+KIND_TURB_MODEL= SA
+KIND_TRANS_MODEL= LM
+FREESTREAM_INTERMITTENCY= 1.0
+FREESTREAM_TURBULENCEINTENSITY= 0.05
+MACH_NUMBER= 0.8
+AOA= 1.25
+REF_DIMENSIONALIZATION= DIMENSIONAL
+REF_LENGTH= 1.0
+REF_AREA= 1.0
+FREESTREAM_PRESSURE= 101325.0
+FREESTREAM_TEMPERATURE= 288.15
+REYNOLDS_NUMBER= 6.5E6
+REYNOLDS_LENGTH= 1.0
+MARKER_HEATFLUX= ( airfoil, 0.0 )
+MARKER_FAR= ( farfield )
+NUM_METHOD_GRAD= WEIGHTED_LEAST_SQUARES
+CFL_NUMBER= 1.0
+ITER= 5
+LINEAR_SOLVER= FGMRES
+LINEAR_SOLVER_ERROR= 1E-6
+LINEAR_SOLVER_ITER= 5
+CONV_NUM_METHOD_FLOW= JST
+CONV_NUM_METHOD_TURB= SCALAR_UPWIND
+MESH_FILENAME= ../../../QuickStart/mesh_NACA0012_inv.su2
+MESH_FORMAT= SU2
+SOLUTION_FILENAME= restart_flow.dat
+RESTART_FILENAME= restart_flow_out.dat
+RESTART_SOL= YES
+CONV_FIELD= RMS_DENSITY
+SCREEN_OUTPUT= (INNER_ITER, RMS_DENSITY, RMS_NU_TILDE, RMS_INTERMITTENCY, RMS_MOM_RE, LIFT, DRAG)