Skip to content

Commit 26c326b

Browse files
committed
fix: modified what pointed out
1 parent 99d54f2 commit 26c326b

2 files changed

Lines changed: 7 additions & 10 deletions

File tree

src/main/java/com/github/sttk/errs/Exc.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public Object getReason() {
106106
*/
107107
@Override
108108
public String getMessage() {
109-
return new StringBuilder(this.reason.getClass().getName()).append(" ").append(reason.toString()).toString();
109+
return reason.toString();
110110
}
111111

112112
/**
@@ -118,7 +118,7 @@ public String getMessage() {
118118
@Override
119119
public String toString() {
120120
var buf = new StringBuilder(getClass().getName());
121-
buf.append(" { reason = ").append(getMessage());
121+
buf.append(" { reason = ").append(reason.getClass().getName()).append(" ").append(reason.toString());
122122
buf.append(", file = ").append(this.trace.getFileName());
123123
buf.append(", line = ").append(this.trace.getLineNumber());
124124
if (getCause() != null) {

src/test/java/com/github/sttk/errs/ExcTest.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -201,16 +201,14 @@ class TestGetMessage {
201201
@Test
202202
void with_cause() {
203203
var exc = new Exc(new IndexOutOfRange("data", 4, 0, 3));
204-
assertThat(exc.getMessage()).isEqualTo(
205-
"com.github.sttk.errs.ExcTest$IndexOutOfRange IndexOutOfRange[name=data, index=4, min=0, max=3]");
204+
assertThat(exc.getMessage()).isEqualTo("IndexOutOfRange[name=data, index=4, min=0, max=3]");
206205
}
207206

208207
@Test
209208
void with_no_cause() {
210209
var cause = new IndexOutOfBoundsException(4);
211210
var exc = new Exc(new IndexOutOfRange("data", 4, 0, 3), cause);
212-
assertThat(exc.getMessage()).isEqualTo(
213-
"com.github.sttk.errs.ExcTest$IndexOutOfRange IndexOutOfRange[name=data, index=4, min=0, max=3]");
211+
assertThat(exc.getMessage()).isEqualTo("IndexOutOfRange[name=data, index=4, min=0, max=3]");
214212
}
215213
}
216214

@@ -220,15 +218,15 @@ class TestToString {
220218
void with_reason() {
221219
var exc = new Exc(new IndexOutOfRange("data", 4, 0, 3));
222220
assertThat(exc.toString()).isEqualTo(
223-
"com.github.sttk.errs.Exc { reason = com.github.sttk.errs.ExcTest$IndexOutOfRange IndexOutOfRange[name=data, index=4, min=0, max=3], file = ExcTest.java, line = 221 }");
221+
"com.github.sttk.errs.Exc { reason = com.github.sttk.errs.ExcTest$IndexOutOfRange IndexOutOfRange[name=data, index=4, min=0, max=3], file = ExcTest.java, line = 219 }");
224222
}
225223

226224
@Test
227225
void with_reason_and_cause() {
228226
var cause = new IndexOutOfBoundsException(4);
229227
var exc = new Exc(new IndexOutOfRange("data", 4, 0, 3), cause);
230228
assertThat(exc.toString()).isEqualTo(
231-
"com.github.sttk.errs.Exc { reason = com.github.sttk.errs.ExcTest$IndexOutOfRange IndexOutOfRange[name=data, index=4, min=0, max=3], file = ExcTest.java, line = 229, cause = java.lang.IndexOutOfBoundsException: Index out of range: 4 }");
229+
"com.github.sttk.errs.Exc { reason = com.github.sttk.errs.ExcTest$IndexOutOfRange IndexOutOfRange[name=data, index=4, min=0, max=3], file = ExcTest.java, line = 227, cause = java.lang.IndexOutOfBoundsException: Index out of range: 4 }");
232230
}
233231
}
234232

@@ -238,8 +236,7 @@ class TestToRuntimeException {
238236
void getMessage() {
239237
var exc = new Exc(new IndexOutOfRange("data", 4, 0, 3));
240238
var rtExc = exc.toRuntimeException();
241-
assertThat(rtExc.getMessage()).isEqualTo(
242-
"com.github.sttk.errs.ExcTest$IndexOutOfRange IndexOutOfRange[name=data, index=4, min=0, max=3]");
239+
assertThat(rtExc.getMessage()).isEqualTo("IndexOutOfRange[name=data, index=4, min=0, max=3]");
243240
}
244241

245242
@Test

0 commit comments

Comments
 (0)