API error shadowed by ClassCastException message if error is not a json object

[notfinch]

Describe the bug

Using some stripebased payments, when an unsuccessful response is resived, the "error" field in the body may be a string instead of a correct json object in raw response
While parsing the error in the com.stripe.net.LiveStripeResponseGetter#handleApiError method, a ClassCastException error is thrown which is thrown out and is uninformative to the sdk consumer

To Reproduce

1. Make any api call that returns a non json type error
2. Get exception java.lang.ClassCastException: class com.google.gson.JsonPrimitive cannot be cast to class com.google.gson.JsonObject

Expected behavior

It is expected that any api call with an error will throw a StripeException or its child exception with a message from the api

Code snippets

No response

OS

all

Java version

21

stripe-java version

26.1.0

API version

2024-06-20

Additional context

try {
      JsonObject jsonObject =
          ApiResource.INTERNAL_GSON
              .fromJson(response.body(), JsonObject.class)
              .getAsJsonObject("error");
      error = ApiResource.deserializeStripeObject(jsonObject.toString(), StripeError.class, this);
    } catch (JsonSyntaxException e) {
      raiseMalformedJsonError(response.body(), response.code(), response.requestId(), e);
    }

The issue here getAsJsonObject("error")
I think that just need to add ClassCastException to the catch block

[remi-stripe]

@notfinch it should not be possible for the error to be a string instead of a proper JSON object. If this happens this would be a bug on our end we'd need to fix. I have definitely seen us do this incorrectly in the past but we've always quickly fixed those when it happened.

Do you have a concrete example where this happened and what the raw response looked like?

[omkarkulkarni2704]

To fix the issue, add a ClassCastException catch block to handle cases where the error field is a string instead of a JsonObject and throw an informative StripeException.

[xavdid-stripe]

@omkarkulkarni2704 were you seeing this issue as well? Do you (or anyone else) have a request ID to share so we can take a closer look?

[omkarkulkarni2704]

@xavdid-stripe Yes, I encountered this issue but I don’t have a specificrequest_id to share. The problem occurs when the error field is returned as a string instead of a JSON object, leading to a ClassCastException.
Let me know how I can assist further!

[xavdid-stripe]

Right, but that really shouldn't happen.

If you notice it again, please note the request id and pass it along here! that'll help us figure out what's up

[omkarkulkarni2704]

Ok