Fix ci

Author: sayhiben

.github/workflows/pr-validation.yml

@@ -118,13 +118,42 @@ jobs:
       run: |
         case "${{ matrix.test-type }}" in
           unit)
-            bundle exec rspec spec/models spec/lib spec/services spec/serializers --format progress --format RspecJunitFormatter --out tmp/rspec-unit.xml
+            UNIT_DIRS="spec/models spec/serializers"
+            if [ -d "spec/lib" ]; then
+              UNIT_DIRS="$UNIT_DIRS spec/lib"
+            fi
+            if [ -d "spec/services" ]; then
+              UNIT_DIRS="$UNIT_DIRS spec/services"
+            fi
+            bundle exec rspec $UNIT_DIRS --format progress --format RspecJunitFormatter --out tmp/rspec-unit.xml
             ;;
           integration)
-            bundle exec rspec spec/requests spec/controllers --format progress --format RspecJunitFormatter --out tmp/rspec-integration.xml
+            INTEGRATION_DIRS=""
+            if [ -d "spec/requests" ]; then
+              INTEGRATION_DIRS="$INTEGRATION_DIRS spec/requests"
+            fi
+            if [ -d "spec/controllers" ]; then
+              INTEGRATION_DIRS="$INTEGRATION_DIRS spec/controllers"
+            fi
+            if [ -z "$INTEGRATION_DIRS" ]; then
+              echo "No integration specs found. Skipping."
+              exit 0
+            fi
+            bundle exec rspec $INTEGRATION_DIRS --format progress --format RspecJunitFormatter --out tmp/rspec-integration.xml
             ;;
           system)
-            bundle exec rspec spec/features spec/system --format progress --format RspecJunitFormatter --out tmp/rspec-system.xml
+            SYSTEM_DIRS=""
+            if [ -d "spec/features" ]; then
+              SYSTEM_DIRS="$SYSTEM_DIRS spec/features"
+            fi
+            if [ -d "spec/system" ]; then
+              SYSTEM_DIRS="$SYSTEM_DIRS spec/system"
+            fi
+            if [ -z "$SYSTEM_DIRS" ]; then
+              echo "No system specs found. Skipping."
+              exit 0
+            fi
+            bundle exec rspec $SYSTEM_DIRS --format progress --format RspecJunitFormatter --out tmp/rspec-system.xml
             ;;
         esac
     

.rubocop.yml

@@ -1,16 +1,15 @@
 # StreamSource RuboCop Configuration
-# Rails-focused linting with sensible defaults
 
 plugins:
   - rubocop-rails
-  - rubocop-performance  
+  - rubocop-performance
   - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 3.3
-  TargetRailsVersion: 8.0
-  SuggestExtensions: false
+  TargetRubyVersion: 4.0
+  TargetRailsVersion: 8.1
   NewCops: enable
+  SuggestExtensions: false
   Exclude:
     - 'bin/**/*'
     - 'tmp/**/*'
@@ -23,41 +22,57 @@ AllCops:
     - 'public/**/*'
     - 'storage/**/*'
     - 'Gemfile.lock'
-    - 'config/environments/production.rb'
     - 'config/boot.rb'
     - 'config/application.rb'
+    - 'config/environments/production.rb'
 
-# Project-specific overrides
 Rails:
   Enabled: true
 
-# Allow longer lines for API documentation and complex queries
+# Keep Rails conventions; allow slightly more flexibility in specs.
 Layout/LineLength:
   Max: 120
   AllowedPatterns:
-    - '\A\s*#.*\z'  # Comments
-    - '\A\s*it\s.*\z'  # RSpec test descriptions
-    - '\A\s*describe\s.*\z'  # RSpec describe blocks
-    - '\A\s*context\s.*\z'  # RSpec context blocks
+    - '\\A\\s*#.*\\z'
+    - '\\A\\s*it\\s.*\\z'
+    - '\\A\\s*describe\\s.*\\z'
+    - '\\A\\s*context\\s.*\\z'
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+  ConsistentQuotesInMultiline: true
+
+Style/ClassAndModuleChildren:
+  EnforcedStyle: nested
+
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: never
+
+Style/SingleLineMethods:
+  AllowIfMethodIsEmpty: true
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
 
-# Allow longer methods for complex Rails actions and RSpec tests
 Metrics/MethodLength:
   Max: 20
   CountAsOne: ['array', 'heredoc']
   Exclude:
     - 'spec/**/*'
-    - 'app/controllers/**/*'
     - 'config/routes.rb'
 
-# Allow longer classes for controllers and models with many methods
 Metrics/ClassLength:
   Max: 150
   CountAsOne: ['array', 'heredoc']
   Exclude:
     - 'spec/**/*'
-    - 'app/controllers/**/*'
 
-# Allow longer blocks for RSpec and routes
 Metrics/BlockLength:
   Max: 25
   CountAsOne: ['array', 'heredoc']
@@ -68,120 +83,32 @@ Metrics/BlockLength:
     - 'Guardfile'
     - 'Rakefile'
 
-# Disable ABC size for complex methods (often needed in Rails)
 Metrics/AbcSize:
-  Enabled: false
+  Max: 25
+  Exclude:
+    - 'spec/**/*'
 
-# Allow complexity in controllers and specs
 Metrics/CyclomaticComplexity:
   Max: 10
   Exclude:
     - 'spec/**/*'
 
-# More flexible on parameter counts for controllers
+Metrics/PerceivedComplexity:
+  Max: 10
+  Exclude:
+    - 'spec/**/*'
+
 Metrics/ParameterLists:
   Max: 8
 
-# Allow assignment in conditions (common Rails pattern)
-Lint/AssignmentInCondition:
-  Enabled: false
-
-# Allow empty when (useful for case statements)
-Lint/EmptyWhen:
-  Enabled: false
-
-# Documentation requirements - be more lenient
-Style/Documentation:
-  Enabled: false
-
-# Allow compact module/class definitions
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-# Flexible on frozen string literals (Rails handles this)
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# Allow single line methods
-Style/SingleLineMethods:
-  AllowIfMethodIsEmpty: true
-
-# Allow guard clauses
-Style/GuardClause:
-  Enabled: true
-
-# Be flexible with hash syntax in Rails
-Style/HashSyntax:
-  EnforcedStyle: ruby19
-
-# Allow trailing commas (good for Git diffs)
-Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: comma
-
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: comma
-
-Style/TrailingCommaInArguments:
-  EnforcedStyleForMultiline: comma
-
-# Be more flexible with string literals
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-  ConsistentQuotesInMultiline: true
-
-# Allow both lambda styles
-Style/Lambda:
-  Enabled: false
-
-# Naming conventions
-Naming/VariableNumber:
-  EnforcedStyle: snake_case
-
-Naming/PredicatePrefix:
-  ForbiddenPrefixes:
-    - is_
-    - have_
-  AllowedMethods:
-    - is_a?
+RSpec/ExampleLength:
+  Max: 12
 
-# Rails cops will be loaded from rubocop-rails gem
+RSpec/MultipleExpectations:
+  Max: 3
 
-# Performance cops will be loaded from rubocop-performance gem
-
-# Security cops
-Security/YAMLLoad:
-  Enabled: true
-
-Security/Eval:
-  Enabled: true
-
-# RSpec cops will be loaded from rubocop-rspec gem
-
-# Bundler cops
-Bundler/OrderedGems:
-  Enabled: false
-
-# Disable cops that conflict with Rails conventions
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: false
-
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-
-Lint/RaiseException:
-  Enabled: true
-
-Lint/StructNewOverride:
-  Enabled: true
-
-Style/ExponentialNotation:
-  Enabled: true
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: true
+RSpec/MultipleMemoizedHelpers:
+  Max: 7
 
-Style/HashTransformValues:
-  Enabled: true
+RSpec/NestedGroups:
+  Max: 4

Gemfile

@@ -54,9 +54,9 @@ gem "image_processing"
 gem "rack-cors"
 
 # Authentication
-gem "jwt"
 gem "devise"
 gem "devise-jwt"
+gem "jwt"
 
 # Authorization
 gem "pundit"
@@ -89,19 +89,22 @@ group :development, :test do
   # Static analysis for security vulnerabilities [https://brakemanscanner.org/]
   gem "brakeman", require: false
 
+  # Performance profiling for CI performance checks
+  gem "memory_profiler", require: false
+
   # Ruby style guide enforcement
   gem "rubocop", require: false
-  gem "rubocop-rails", require: false
   gem "rubocop-performance", require: false
+  gem "rubocop-rails", require: false
   gem "rubocop-rspec", require: false
 
   # Testing
-  gem "rspec-rails"
+  gem "database_cleaner-active_record"
   gem "factory_bot_rails"
   gem "faker"
-  gem "shoulda-matchers"
-  gem "database_cleaner-active_record"
   gem "rails-controller-testing"
+  gem "rspec-rails"
+  gem "shoulda-matchers"
 end
 
 group :development do
@@ -115,8 +118,8 @@ end
 group :test do
   gem "rswag-specs"
   gem "simplecov", require: false
-  gem "webmock"
   gem "vcr"
+  gem "webmock"
 end
 
 # Performance monitoring

Gemfile.lock

@@ -204,6 +204,7 @@ GEM
       net-pop
       net-smtp
     marcel (1.1.0)
+    memory_profiler (1.1.0)
     mini_magick (5.3.1)
       logger
     mini_mime (1.1.5)
@@ -459,6 +460,7 @@ DEPENDENCIES
   jsbundling-rails
   jwt
   lograge
+  memory_profiler
   ostruct
   pagy
   pg

app/channels/application_cable/connection.rb

@@ -1,4 +1,5 @@
 module ApplicationCable
+  # Handles ActionCable connection authentication.
   class Connection < ActionCable::Connection::Base
     identified_by :current_user
 
@@ -14,13 +15,13 @@ def find_verified_user
 
       if token.present?
         decoded = JsonWebToken.decode(token)
-        if verified_user = User.find_by(id: decoded["user_id"])
+        if (verified_user = User.find_by(id: decoded["user_id"]))
           return verified_user
         end
       end
 
       # Fall back to session-based auth
-      if verified_user = User.find_by(id: cookies.encrypted[:user_id])
+      if (verified_user = User.find_by(id: cookies.encrypted[:user_id]))
         return verified_user
       end
 

app/channels/application_channel.rb

@@ -1,3 +1,4 @@
+# Base ActionCable channel behavior.
 class ApplicationChannel < ApplicationCable::Channel
   def subscribed
     # stream_from "some_channel"