Fix some linting errors

Author: sayhiben

app/assets/builds/application.js

@@ -11,19 +11,19 @@ def connect
     def find_verified_user
       # Try JWT token first (from cookies or params)
       token = cookies["jwt_token"] || request.params["token"]
-      
+
       if token.present?
         decoded = JsonWebToken.decode(token)
         if verified_user = User.find_by(id: decoded["user_id"])
           return verified_user
         end
       end
-      
+
       # Fall back to session-based auth
       if verified_user = User.find_by(id: cookies.encrypted[:user_id])
         return verified_user
       end
-      
+
       reject_unauthorized_connection
     rescue JWT::DecodeError
       reject_unauthorized_connection

app/assets/builds/application.js.map

@@ -1,4 +1,5 @@
 module Admin
+  # rubocop:disable Rails/ApplicationController
   class BaseController < ActionController::Base
     include Pagy::Method
 
@@ -14,7 +15,7 @@ class BaseController < ActionController::Base
     before_action :check_maintenance_mode
 
     layout "admin"
-    
+
     helper_method :current_user, :user_signed_in?, :current_admin_user
 
     rescue_from ActiveRecord::RecordNotFound, with: :record_not_found
@@ -28,7 +29,7 @@ def authenticate_admin!
         redirect_to admin_login_path, alert: "You must be logged in to access this area."
         return
       end
-      
+
       return if current_user&.admin? || current_user&.editor?
 
       redirect_to admin_login_path, alert: "You must be logged in as an admin or editor to access this area."
@@ -37,11 +38,11 @@ def authenticate_admin!
     def current_admin_user
       @current_admin_user ||= current_user if current_user&.admin?
     end
-    
+
     def current_user
       @current_user ||= User.find_by(id: session[:admin_user_id]) if session[:admin_user_id]
     end
-    
+
     def user_signed_in?
       current_user.present?
     end
@@ -78,22 +79,22 @@ def record_invalid(exception)
       respond_to do |format|
         format.html do
           flash[:alert] = "There was an error processing your request: #{exception.message}"
-          redirect_back(fallback_location: admin_streams_path)
+          redirect_back_or_to(admin_streams_path)
         end
         format.turbo_stream do
           render turbo_stream: turbo_stream.replace("flash",
                                                     partial: "admin/shared/flash",
                                                     locals: { alert: "There was an error processing your request." })
         end
-        format.json { render json: { error: exception.message }, status: :unprocessable_entity }
+        format.json { render json: { error: exception.message }, status: :unprocessable_content }
       end
     end
 
     def parameter_missing(exception)
       respond_to do |format|
         format.html do
           flash[:alert] = "Required parameter missing: #{exception.param}"
-          redirect_back(fallback_location: admin_streams_path)
+          redirect_back_or_to(admin_streams_path)
         end
         format.turbo_stream do
           render turbo_stream: turbo_stream.replace("flash",
@@ -104,4 +105,5 @@ def parameter_missing(exception)
       end
     end
   end
+  # rubocop:enable Rails/ApplicationController
 end

app/channels/application_cable/connection.rb

@@ -1,19 +1,15 @@
 module Admin
   class IgnoreListsController < BaseController
-    before_action :set_ignore_list, only: [:edit, :update, :destroy]
+    before_action :set_ignore_list, only: %i[edit update destroy]
 
     def index
       @ignore_lists = IgnoreList.all
 
       # Filter by list type
-      if params[:list_type].present?
-        @ignore_lists = @ignore_lists.where(list_type: params[:list_type])
-      end
+      @ignore_lists = @ignore_lists.where(list_type: params[:list_type]) if params[:list_type].present?
 
       # Search functionality
-      if params[:search].present?
-        @ignore_lists = @ignore_lists.where('value ILIKE ?', "%#{params[:search]}%")
-      end
+      @ignore_lists = @ignore_lists.where("value ILIKE ?", "%#{params[:search]}%") if params[:search].present?
 
       # Sorting
       @ignore_lists = @ignore_lists.order(created_at: :desc)
@@ -31,43 +27,42 @@ def new
       @ignore_list = IgnoreList.new(list_type: params[:list_type])
     end
 
+    def edit; end
+
     def create
       @ignore_list = IgnoreList.new(ignore_list_params)
 
       if @ignore_list.save
-        redirect_to admin_ignore_lists_path, notice: 'Ignore list entry was successfully created.'
+        redirect_to admin_ignore_lists_path, notice: "Ignore list entry was successfully created."
       else
-        render :new, status: :unprocessable_entity
+        render :new, status: :unprocessable_content
       end
     end
 
-    def edit
-    end
-
     def update
       if @ignore_list.update(ignore_list_params)
-        redirect_to admin_ignore_lists_path, notice: 'Ignore list entry was successfully updated.'
+        redirect_to admin_ignore_lists_path, notice: "Ignore list entry was successfully updated."
       else
-        render :edit, status: :unprocessable_entity
+        render :edit, status: :unprocessable_content
       end
     end
 
     def destroy
       @ignore_list.destroy
-      redirect_to admin_ignore_lists_path, notice: 'Ignore list entry was successfully deleted.'
+      redirect_to admin_ignore_lists_path, notice: "Ignore list entry was successfully deleted."
     end
 
     # Bulk import action
     def bulk_import
-      if request.post?
-        results = process_bulk_import(params[:import_data], params[:list_type])
-        
-        if results[:errors].empty?
-          redirect_to admin_ignore_lists_path, notice: "Successfully imported #{results[:created].count} entries."
-        else
-          redirect_to admin_ignore_lists_path, 
-                      alert: "Imported #{results[:created].count} entries. #{results[:errors].count} errors occurred."
-        end
+      return unless request.post?
+
+      results = process_bulk_import(params[:import_data], params[:list_type])
+
+      if results[:errors].empty?
+        redirect_to admin_ignore_lists_path, notice: "Successfully imported #{results[:created].count} entries."
+      else
+        redirect_to admin_ignore_lists_path,
+                    alert: "Imported #{results[:created].count} entries. #{results[:errors].count} errors occurred."
       end
     end
 
@@ -78,12 +73,12 @@ def set_ignore_list
     end
 
     def ignore_list_params
-      params.require(:ignore_list).permit(:list_type, :value, :notes)
+      params.expect(ignore_list: %i[list_type value notes])
     end
 
     def process_bulk_import(import_data, list_type)
       results = { created: [], errors: [] }
-      
+
       return results if import_data.blank? || list_type.blank?
 
       # Split by newlines and process each line
@@ -92,7 +87,7 @@ def process_bulk_import(import_data, list_type)
         next if value.blank?
 
         ignore_list = IgnoreList.new(list_type: list_type, value: value)
-        
+
         if ignore_list.save
           results[:created] << ignore_list
         else
@@ -103,4 +98,4 @@ def process_bulk_import(import_data, list_type)
       results
     end
   end
-end
+end

app/controllers/admin/base_controller.rb

@@ -7,7 +7,7 @@ def index
         Location.includes(:streams)
                 .order(created_at: :desc)
                 .search_by_name(params[:search]),
-        limit: 25
+        limit: 25,
       )
     end
 
@@ -19,8 +19,7 @@ def new
       @location = Location.new
     end
 
-    def edit
-    end
+    def edit; end
 
     def create
       @location = Location.new(location_params)
@@ -30,8 +29,8 @@ def create
           format.html { redirect_to admin_location_path(@location), notice: "Location was successfully created." }
           format.turbo_stream
         else
-          format.html { render :new, status: :unprocessable_entity }
-          format.turbo_stream { render :form_update, status: :unprocessable_entity }
+          format.html { render :new, status: :unprocessable_content }
+          format.turbo_stream { render :form_update, status: :unprocessable_content }
         end
       end
     end
@@ -42,8 +41,8 @@ def update
           format.html { redirect_to admin_location_path(@location), notice: "Location was successfully updated." }
           format.turbo_stream
         else
-          format.html { render :edit, status: :unprocessable_entity }
-          format.turbo_stream { render :form_update, status: :unprocessable_entity }
+          format.html { render :edit, status: :unprocessable_content }
+          format.turbo_stream { render :form_update, status: :unprocessable_content }
         end
       end
     end
@@ -64,7 +63,7 @@ def set_location
     end
 
     def location_params
-      params.require(:location).permit(:city, :state_province, :region, :country, :latitude, :longitude, :is_known_city)
+      params.expect(location: %i[city state_province region country latitude longitude is_known_city])
     end
   end
-end
+end

app/controllers/admin/ignore_lists_controller.rb

@@ -1,7 +1,7 @@
 module Admin
   class SessionsController < Admin::BaseController
-    skip_before_action :authenticate_admin!, only: [:new, :create]
-    skip_before_action :check_maintenance_mode, only: [:new, :create]
+    skip_before_action :authenticate_admin!, only: %i[new create]
+    skip_before_action :check_maintenance_mode, only: %i[new create]
     layout "admin_login"
 
     def new
@@ -18,7 +18,7 @@ def create
         redirect_to admin_streams_path, notice: "Successfully logged in."
       else
         flash.now[:alert] = "Invalid email or password, or insufficient privileges."
-        render :new, status: :unprocessable_entity
+        render :new, status: :unprocessable_content
       end
     end
 
@@ -35,4 +35,4 @@ def current_admin_user
       @current_admin_user ||= current_user if current_user&.admin?
     end
   end
-end
+end

app/controllers/admin/locations_controller.rb

@@ -39,8 +39,8 @@ def create
           end
         else
           @users = User.order(:email)
-          format.html { render :new, status: :unprocessable_entity }
-          format.turbo_stream { render :new, status: :unprocessable_entity }
+          format.html { render :new, status: :unprocessable_content }
+          format.turbo_stream { render :new, status: :unprocessable_content }
         end
       end
     end
@@ -59,8 +59,8 @@ def update
           end
         else
           @users = User.order(:email)
-          format.html { render :edit, status: :unprocessable_entity }
-          format.turbo_stream { render :edit, status: :unprocessable_entity }
+          format.html { render :edit, status: :unprocessable_content }
+          format.turbo_stream { render :edit, status: :unprocessable_content }
         end
       end
     end