Add PHP 8.5, Symfony 7.4 and 8.0

Author: steevanb

.claude/commands/add-php-version.md

@@ -0,0 +1,65 @@
+---
+description: Add a new PHP version to CI (DependenciesVersions, Dockerfile, phpstan configs)
+argument-hint: <php-version>
+allowed-tools: [Read, Edit, Write, Glob, Grep, Bash]
+---
+
+Add PHP version **$ARGUMENTS** to the CI pipeline. Follow each step exactly.
+
+## Step 1: Validate input
+
+The argument must be a PHP version like `8.5`. If `$ARGUMENTS` is empty or does not match the pattern `X.Y` (single digit dot single digit), stop and tell the user the correct usage: `/add-php-version 8.5`.
+
+Derive these values from the version `X.Y`:
+- **MAJOR** = X (e.g. `8`)
+- **MINOR** = Y (e.g. `5`)
+- **phpVersion int** = X0Y00 (e.g. `80500`) — pad minor to two digits, append two zeros
+
+## Step 2: Update `bin/DependenciesVersions.php`
+
+Read the file. In the `$this->phpVersions` chain (around line 33-38), add `->add('X.Y')` immediately before `->setReadOnly()`. Follow the existing indentation (16 spaces).
+
+## Step 3: Update `docker/ci/Dockerfile`
+
+Read the file. Find the last `# PHP X.Y` comment block in the `apt-get install` section (the block with `phpX.Y-cli`, `phpX.Y-dom`, `phpX.Y-mbstring`). Add a new block immediately after it with the same pattern:
+
+```
+        # PHP X.Y
+        phpX.Y-cli \
+        phpX.Y-dom \
+        phpX.Y-mbstring \
+```
+
+Make sure the backslash continuation is preserved on the line before the new block.
+
+## Step 4: Create phpstan config files
+
+1. Glob `config/ci/phpstan/php-*.neon` to find all existing Symfony versions in use.
+2. Extract the unique Symfony versions (e.g. `7.0`, `7.1`, `7.2`, `7.3`).
+3. For each Symfony version `Z.A`, create `config/ci/phpstan/php-X.Y.symfony-Z.A.neon` with this exact content (no trailing newline after the last line):
+
+```
+includes:
+    - common.neon
+parameters:
+    phpVersion: <phpVersion int>
+    tmpDir: ../../../var/ci/phpstan/php-X-Y/symfony-Z-A
+```
+
+Where dashes replace dots in directory names (e.g. `php-8-5/symfony-7-0`).
+
+## Step 5: Build Docker image
+
+Run `bin/ci/docker` to rebuild the CI Docker image with the new PHP version. This may take several minutes.
+
+## Step 6: Run CI validation
+
+Run `bin/ci/validate` to verify everything passes. If it fails, fix the errors and re-run until it passes.
+
+## Step 7: Report
+
+List all files that were modified or created.
+
+At the very end, display this reminder message in bold yellow (using markdown):
+
+> **⚠️ Don't forget to push the Docker image: `bin/ci/docker --push`**

.gitignore

@@ -1,3 +1,4 @@
+/.claude/settings.local.json
 /var/
 !/var/.gitkeep
 /vendor/

CLAUDE.md

@@ -0,0 +1,60 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+PHP library for running shell processes in parallel with dependency management between them. Built on Symfony Console/Process components. The library itself is used to run its own CI validation (self-dogfooding).
+
+## Common Commands
+
+**Run tests locally (requires PHP 8.2+ and ext-pcntl):**
+```bash
+composer install
+vendor/bin/phpunit -c config/ci/phpunit.xml
+```
+
+**Run full CI validation (runs all checks in parallel using this library itself):**
+```bash
+bin/ci/env          # install dependencies
+bin/ci/validate     # runs phpcs, phpstan, phpunit, composer checks, etc. in parallel
+```
+
+**Run individual CI tools:**
+```bash
+bin/ci/phpcs                # code style (steevanb custom sniffs)
+bin/ci/phpstan              # static analysis (level 9)
+bin/ci/phpunit-coverage     # tests with coverage
+```
+
+CI tests across a matrix: PHP 8.2/8.3/8.4 × Symfony 7.0/7.1/7.2/7.3.
+
+## Architecture
+
+### Core Components
+
+**`ParallelProcessesApplication`** (`src/Console/Application/`) — Main orchestrator. Extends Symfony `SingleCommandApplication`, implements `SignalableCommandInterface`. Uses a fluent builder interface to add processes, configure timeout/refresh interval/max parallel processes, then `run()`. Handles SIGINT for graceful shutdown.
+
+**`Process`** (`src/Process/Process.php`) — Extends Symfony `Process`, implements `ProcessInterface`. Each process has configurable output verbosity levels (standard, error, failure, canceled), a `StartCondition` for dependency management, and cancellation support.
+
+**`StartCondition`** (`src/Process/StartCondition.php`) — Controls when a process can start via three dependency collections:
+- `processesTerminated` — start after these finish (regardless of success/failure)
+- `processesSuccessful` — start only after these succeed
+- `processesFailed` — start only after these fail
+
+**`BootstrapProcess` / `TearDownProcess`** — Special process types. Bootstrap processes automatically become dependencies (via `processesSuccessful`) for all standard processes. TearDown processes automatically wait for all standard processes to terminate.
+
+**Theme system** (`src/Console/Application/Theme/`) — Strategy pattern. `DefaultTheme` shows real-time colored status; `SummaryTheme` shows minimal output (used in CI). Custom themes implement `ThemeInterface`. Selected via `--theme` CLI option.
+
+**`ProcessInterfaceCollection`** — Type-safe collection with filtering: `getReady()`, `getStarted()`, `countRunning()`.
+
+## Code Conventions
+
+- `declare(strict_types=1)` on every file
+- PHP 8.2+ features: constructor property promotion, `readonly`, enums, `#[\Override]` attribute
+- PHPStan level 9 (strictest)
+- Fluent interface pattern (methods return `static`)
+- Interfaces suffixed with `Interface`, no `Abstract` prefix convention
+- Tests: one test class per method, `@covers` annotation required, test directory mirrors `src/` structure
+- PHPUnit config: `config/ci/phpunit.xml` (with coverage), `config/release/phpunit.xml`
+- PHPStan configs: `config/ci/phpstan/` (per PHP/Symfony version combination)

bin/DependenciesVersions.php

@@ -35,6 +35,7 @@ public function __construct(array $argv)
                 ->add('8.2')
                 ->add('8.3')
                 ->add('8.4')
+                ->add('8.5')
                 ->setReadOnly();
         }
 

config/ci/phpstan/php-8.5.symfony-7.0.neon

@@ -0,0 +1,5 @@
+includes:
+    - common.neon
+parameters:
+    phpVersion: 80500
+    tmpDir: ../../../var/ci/phpstan/php-8-5/symfony-7-0

config/ci/phpstan/php-8.5.symfony-7.1.neon

@@ -0,0 +1,5 @@
+includes:
+    - common.neon
+parameters:
+    phpVersion: 80500
+    tmpDir: ../../../var/ci/phpstan/php-8-5/symfony-7-1

config/ci/phpstan/php-8.5.symfony-7.2.neon

@@ -0,0 +1,5 @@
+includes:
+    - common.neon
+parameters:
+    phpVersion: 80500
+    tmpDir: ../../../var/ci/phpstan/php-8-5/symfony-7-2

config/ci/phpstan/php-8.5.symfony-7.3.neon

@@ -0,0 +1,5 @@
+includes:
+    - common.neon
+parameters:
+    phpVersion: 80500
+    tmpDir: ../../../var/ci/phpstan/php-8-5/symfony-7-3

docker/ci/Dockerfile

@@ -38,6 +38,10 @@ RUN \
         php8.4-cli \
         php8.4-dom \
         php8.4-mbstring \
+        # PHP 8.5
+        php8.5-cli \
+        php8.5-dom \
+        php8.5-mbstring \
         # For Composer
         curl \
         zip \

src/Process/Process.php

@@ -251,7 +251,6 @@ protected function updateStatus(bool $blocking): void
     protected function getParentPrivatePropertyValue(string $property): mixed
     {
         $reflection = new \ReflectionProperty(SymfonyProcess::class, $property);
-        $reflection->setAccessible(true);
 
         return $reflection->getValue($this);
     }