From f958ad66743b03291666901423d6169fbd2b537c Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Tue, 11 Aug 2026 10:21:26 +0000 Subject: [PATCH] test: migrate `stats/base/dists/gamma/quantile` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01PDwfERAzjEANsUeUns9Jtk --- .../dists/gamma/quantile/test/test.factory.js | 33 +++---------------- .../gamma/quantile/test/test.quantile.js | 33 +++---------------- 2 files changed, 8 insertions(+), 58 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/gamma/quantile/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/gamma/quantile/test/test.factory.js index 995690fdd788..0a72dd1e0bc2 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/gamma/quantile/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/gamma/quantile/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -186,9 +185,7 @@ tape( 'the created function evaluates the quantile for `p` given large `alpha` a var expected; var quantile; var alpha; - var delta; var beta; - var tol; var p; var y; var i; @@ -200,13 +197,7 @@ tape( 'the created function evaluates the quantile for `p` given large `alpha` a for ( i = 0; i < p.length; i++ ) { quantile = factory( alpha[i], beta[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha:'+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1350.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 25 ), true, 'returns expected value' ); } t.end(); }); @@ -215,9 +206,7 @@ tape( 'the created function evaluates the quantile for `p` given large shape par var expected; var quantile; var alpha; - var delta; var beta; - var tol; var p; var y; var i; @@ -229,13 +218,7 @@ tape( 'the created function evaluates the quantile for `p` given large shape par for ( i = 0; i < p.length; i++ ) { quantile = factory( alpha[i], beta[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha:'+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 19 ), true, 'returns expected value' ); } t.end(); }); @@ -244,9 +227,7 @@ tape( 'the created function evaluates the quantile for `p` given large rate para var expected; var quantile; var alpha; - var delta; var beta; - var tol; var p; var y; var i; @@ -258,13 +239,7 @@ tape( 'the created function evaluates the quantile for `p` given large rate para for ( i = 0; i < p.length; i++ ) { quantile = factory( alpha[i], beta[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha:'+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 200.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 96 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/gamma/quantile/test/test.quantile.js b/lib/node_modules/@stdlib/stats/base/dists/gamma/quantile/test/test.quantile.js index 48bc5dbd98e0..cf37ead92bd4 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/gamma/quantile/test/test.quantile.js +++ b/lib/node_modules/@stdlib/stats/base/dists/gamma/quantile/test/test.quantile.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var quantile = require( './../lib' ); @@ -130,9 +129,7 @@ tape( 'if provided `alpha` equal to `0.0`, the function returns `0.0` for a val tape( 'the function evaluates the quantile for `x` given large parameters `alpha` and `beta`', function test( t ) { var expected; var alpha; - var delta; var beta; - var tol; var p; var y; var i; @@ -143,13 +140,7 @@ tape( 'the function evaluates the quantile for `x` given large parameters `alpha beta = bothLarge.beta; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha:'+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1350.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 25 ), true, 'returns expected value' ); } t.end(); }); @@ -157,9 +148,7 @@ tape( 'the function evaluates the quantile for `x` given large parameters `alpha tape( 'the function evaluates the quantile for `x` given large shape parameter `alpha`', function test( t ) { var expected; var alpha; - var delta; var beta; - var tol; var p; var y; var i; @@ -170,13 +159,7 @@ tape( 'the function evaluates the quantile for `x` given large shape parameter ` beta = largeShape.beta; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha:'+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 19 ), true, 'returns expected value' ); } t.end(); }); @@ -184,9 +167,7 @@ tape( 'the function evaluates the quantile for `x` given large shape parameter ` tape( 'the function evaluates the quantile for `x` given large rate parameter `beta`', function test( t ) { var expected; var alpha; - var delta; var beta; - var tol; var p; var y; var i; @@ -197,13 +178,7 @@ tape( 'the function evaluates the quantile for `x` given large rate parameter `b beta = largeRate.beta; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', alpha:'+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 200.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 96 ), true, 'returns expected value' ); } t.end(); });