From cffbacb2393225eb94f2b02dade2c9fc14c87f1b Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 11 Aug 2026 09:25:03 +0000 Subject: [PATCH] test: migrate `math/base/special/cexp` to ULP-based testing Replace relative-tolerance (EPS-scaled delta/tol) comparisons with `@stdlib/assert/is-almost-same-value` ULP-based assertions in both test.js and test.native.js. Measured minimum ULP thresholds (fixture set: pure_imaginary.json, general_complex.json): - test.js: 0 ULP for both real and imaginary components (exact match on the reference fixtures). - test.native.js: 1 ULP for the real component and the pure-imaginary imaginary component; 2 ULP for the general-complex imaginary component, mirroring the native implementation's pre-existing wider tolerance for that case. Resolves a part of #11352. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../math/base/special/cexp/test/test.js | 39 +++---------------- .../base/special/cexp/test/test.native.js | 39 +++---------------- 2 files changed, 10 insertions(+), 68 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/cexp/test/test.js b/lib/node_modules/@stdlib/math/base/special/cexp/test/test.js index 6f1145bef1a2..afcaffbc058b 100644 --- a/lib/node_modules/@stdlib/math/base/special/cexp/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/cexp/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var Complex128 = require( '@stdlib/complex/float64/ctor' ); @@ -58,10 +57,8 @@ tape( 'the function returns a double-precision complex floating-point number', f }); tape( 'the function computes exp(z) for pure imaginary z', function test( t ) { - var delta; var expre; var expim; - var tol; var re; var im; var i; @@ -74,29 +71,15 @@ tape( 'the function computes exp(z) for pure imaginary z', function test( t ) { for ( i = 0; i < re.length; i++ ) { q = cexp( new Complex128( re[ i ], im[ i ] ) ); - if ( real( q ) === expre[ i ] ) { - t.strictEqual( real( q ), expre[ i ], 'returns expected real component' ); - } else { - delta = abs( real( q ) - expre[ i ] ); - tol = EPS * abs( expre[ i ] ); - t.ok( delta <= tol, 'within tolerance. z: '+re[i]+'+ '+im[i]+'i. real: '+real( q )+'. expected: '+expre[i]+'. delta: '+delta+'. tol: '+tol+'.' ); - } - if ( imag( q ) === expim[ i ] ) { - t.strictEqual( imag( q ), expim[ i ], 'returns expected imaginary component' ); - } else { - delta = abs( imag( q ) - expim[ i ] ); - tol = EPS * abs( expim[ i ] ); - t.ok( delta <= tol, 'within tolerance. z: '+re[i]+'+ '+im[i]+'i. imag: '+imag( q )+'. expected: '+expim[i]+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( real( q ), expre[ i ], 0 ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( imag( q ), expim[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function computes exp(z) for complex z', function test( t ) { - var delta; var expre; var expim; - var tol; var re; var im; var i; @@ -109,20 +92,8 @@ tape( 'the function computes exp(z) for complex z', function test( t ) { for ( i = 0; i < re.length; i++ ) { q = cexp( new Complex128( re[ i ], im[ i ] ) ); - if ( real( q ) === expre[ i ] ) { - t.strictEqual( real( q ), expre[ i ], 'returns expected real component' ); - } else { - delta = abs( real( q ) - expre[ i ] ); - tol = EPS * abs( expre[ i ] ); - t.ok( delta <= tol, 'within tolerance. z: '+re[i]+'+ '+im[i]+'i. real: '+real( q )+'. expected: '+expre[i]+'. delta: '+delta+'. tol: '+tol+'.' ); - } - if ( imag( q ) === expim[ i ] ) { - t.strictEqual( imag( q ), expim[ i ], 'returns expected imaginary component' ); - } else { - delta = abs( imag( q ) - expim[ i ] ); - tol = EPS * abs( expim[ i ] ); - t.ok( delta <= tol, 'within tolerance. z: '+re[i]+'+ '+im[i]+'i. imag: '+imag( q )+'. expected: '+expim[i]+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( real( q ), expre[ i ], 0 ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( imag( q ), expim[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/cexp/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/cexp/test/test.native.js index bfc709c75c1a..c4d89e3f6056 100644 --- a/lib/node_modules/@stdlib/math/base/special/cexp/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/cexp/test/test.native.js @@ -22,11 +22,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var Complex128 = require( '@stdlib/complex/float64/ctor' ); @@ -67,10 +66,8 @@ tape( 'the function returns a double-precision complex floating-point number', o }); tape( 'the function computes exp(z) for pure imaginary z', opts, function test( t ) { - var delta; var expre; var expim; - var tol; var re; var im; var i; @@ -83,29 +80,15 @@ tape( 'the function computes exp(z) for pure imaginary z', opts, function test( for ( i = 0; i < re.length; i++ ) { q = cexp( new Complex128( re[ i ], im[ i ] ) ); - if ( real( q ) === expre[ i ] ) { - t.strictEqual( real( q ), expre[ i ], 'returns expected real component' ); - } else { - delta = abs( real( q ) - expre[ i ] ); - tol = EPS * abs( expre[ i ] ); - t.ok( delta <= tol, 'within tolerance. z: '+re[i]+'+ '+im[i]+'i. real: '+real( q )+'. expected: '+expre[i]+'. delta: '+delta+'. tol: '+tol+'.' ); - } - if ( imag( q ) === expim[ i ] ) { - t.strictEqual( imag( q ), expim[ i ], 'returns expected imaginary component' ); - } else { - delta = abs( imag( q ) - expim[ i ] ); - tol = EPS * abs( expim[ i ] ); - t.ok( delta <= tol, 'within tolerance. z: '+re[i]+'+ '+im[i]+'i. imag: '+imag( q )+'. expected: '+expim[i]+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( real( q ), expre[ i ], 1 ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( imag( q ), expim[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function computes exp(z) for complex z', opts, function test( t ) { - var delta; var expre; var expim; - var tol; var re; var im; var i; @@ -118,20 +101,8 @@ tape( 'the function computes exp(z) for complex z', opts, function test( t ) { for ( i = 0; i < re.length; i++ ) { q = cexp( new Complex128( re[ i ], im[ i ] ) ); - if ( real( q ) === expre[ i ] ) { - t.strictEqual( real( q ), expre[ i ], 'returns expected real component' ); - } else { - delta = abs( real( q ) - expre[ i ] ); - tol = EPS * abs( expre[ i ] ); - t.ok( delta <= tol, 'within tolerance. z: '+re[i]+'+ '+im[i]+'i. real: '+real( q )+'. expected: '+expre[i]+'. delta: '+delta+'. tol: '+tol+'.' ); - } - if ( imag( q ) === expim[ i ] ) { - t.strictEqual( imag( q ), expim[ i ], 'returns expected imaginary component' ); - } else { - delta = abs( imag( q ) - expim[ i ] ); - tol = 2.0 * EPS * abs( expim[ i ] ); - t.ok( delta <= tol, 'within tolerance. z: '+re[i]+'+ '+im[i]+'i. imag: '+imag( q )+'. expected: '+expim[i]+'. delta: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( real( q ), expre[ i ], 1 ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( imag( q ), expim[ i ], 2 ), true, 'returns expected value' ); } t.end(); });