chore: deps update & function cleanup

Cleaned up and rewrote a few functions; fixed a config error bug; updated for latest Rodio dependency changes

Author: stacksjb

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "shell_command_menu"
-version = "0.2.4"
+version = "0.2.5"
 edition = "2024"
 
 [dependencies]
@@ -12,11 +12,12 @@ prettytable = "0.10.0"
 inquire = "0.9.2"
 textwrap = "0.16.2"
 rodio = "0.21.1"
-tokio = { version = "1.49.0", features = ["full"] }
+tokio = { version = "1.49.0", features = ["rt"] }
 anyhow = "1.0.100"
 csv = "1.4.0"
 
 
 [dev-dependencies]
+tokio = { version = "1.49.0", features = ["macros", "rt"] }
 serial_test = "3.3.1"
 tempfile = "3.24.0"

Cargo.toml

@@ -1,5 +1,8 @@
 # Changelog
 
+1/27/26 - v0.2.5
+Cleaned up and rewrote a few functions; fixed a config error bug; updated for latest Rodio dependency changes
+
 7/4/25
 Updated formatting for Rust 1.88 and Clippy
 

src/changelog.md

@@ -58,18 +58,20 @@ pub fn load_config(path: &PathBuf) -> anyhow::Result<Config> {
 }
 
 // Save the entire configuration (including commands and other sections) to a file.
-pub fn save_config(path: &Path, config: &Config) {
-    let config_data = serde_json::to_string_pretty(config).expect("❌  Failed to serialize config");
-    let mut file = File::create(path).expect("❌  Unable to create config file ");
+pub fn save_config(path: &Path, config: &Config) -> anyhow::Result<()> {
+    let config_data = serde_json::to_string_pretty(config).context("failed to serialize config")?;
+    let mut file = File::create(path)
+        .with_context(|| format!("unable to create config file at {}", path.display()))?;
     // Write the serialized config data to the file
     file.write_all(config_data.as_bytes())
-        .expect("❌  Unable to write to config file");
+        .context("unable to write to config file")?;
+    Ok(())
 }
 
 // Saves a default config.
 fn create_default_config(path: &Path) -> anyhow::Result<Config> {
     let default_config = Config::default();
-    save_config(path, &default_config);
+    save_config(path, &default_config).context("failed to save default config")?;
     println!("✅  Successfully created and saved new default config.");
     Ok(default_config)
 }
@@ -178,7 +180,7 @@ mod tests {
             window_title: Some("My CLI Menu".into()),
         };
 
-        save_config(&path, &original);
+        save_config(&path, &original).expect("Should save config");
 
         let loaded = load_config(&path).expect("Should load config");
         assert_eq!(original.commands.len(), loaded.commands.len());

src/config.rs

@@ -10,6 +10,15 @@ use std::path::PathBuf;
 use std::process;
 use textwrap::fill;
 
+// Utility function to parse command index from formatted string like "1. Command Name"
+fn parse_command_index(index_str: &str) -> Option<usize> {
+    index_str
+        .split('.')
+        .next()
+        .and_then(|num| num.trim().parse::<usize>().ok())
+        .and_then(|num| num.checked_sub(1))
+}
+
 pub fn edit_menu(config_path: &PathBuf) {
     let mut config = crate::config::load_config(config_path).unwrap_or_else(|e| {
         eprintln!("Error: {e}");
@@ -62,11 +71,18 @@ pub fn edit_menu(config_path: &PathBuf) {
                     match save_prompt {
                         Some("Yes") => {
                             if validate_json(&config) {
-                                save_config(config_path, &config);
-                                println!(
-                                    "✅  Changes Saved. Press any key to return to Main Menu..."
-                                );
-                                pause();
+                                match save_config(config_path, &config) {
+                                    Ok(_) => {
+                                        println!(
+                                            "✅  Changes Saved. Press any key to return to Main Menu..."
+                                        );
+                                        pause();
+                                    }
+                                    Err(e) => {
+                                        eprintln!("❌  Error saving config: {e}");
+                                        pause();
+                                    }
+                                }
                             } else {
                                 println!("❌  Error: Invalid JSON format. Changes not saved.");
                             }
@@ -133,13 +149,13 @@ pub fn edit_command(config: &mut Config, changes_made: &mut bool) {
             None => return,
         };
 
-    let command_number = command_index
-        .split('.')
-        .next()
-        .unwrap()
-        .parse::<usize>()
-        .unwrap()
-        - 1;
+    let command_number = match parse_command_index(&command_index) {
+        Some(num) => num,
+        None => {
+            println!("❌  Invalid command selection.");
+            return;
+        }
+    };
 
     let display_name = match prompt_or_return(|| {
         inquire::Text::new("Enter the new display name for the command:")
@@ -186,13 +202,13 @@ pub fn reorder_command(config: &mut Config, changes_made: &mut bool) {
         None => return,
     };
 
-    let command_number = command_index
-        .split('.')
-        .next()
-        .unwrap()
-        .parse::<usize>()
-        .unwrap()
-        - 1;
+    let command_number = match parse_command_index(&command_index) {
+        Some(num) => num,
+        None => {
+            println!("❌  Invalid command selection.");
+            return;
+        }
+    };
 
     let new_position: usize = match prompt_or_return(|| {
         inquire::Text::new("Enter the new position for this command:")
@@ -236,13 +252,13 @@ pub fn delete_command(config: &mut Config, changes_made: &mut bool) {
         None => return,
     };
 
-    let command_number = command_index
-        .split('.')
-        .next()
-        .unwrap()
-        .parse::<usize>()
-        .unwrap()
-        - 1;
+    let command_number = match parse_command_index(&command_index) {
+        Some(num) => num,
+        None => {
+            println!("❌  Invalid command selection.");
+            return;
+        }
+    };
 
     let deleted = config.commands.remove(command_number);
     println!(