Migrate Reporter to Status Dashboard API V2 for Incident Creation (#26)

Migrate Reporter to Status Dashboard API V2 for Incident Creation

This PR migrates the reporter from Status Dashboard API V1 to V2 for sending incidents. The migration introduces component ID resolution via a cached lookup system and updates the incident data structure to match the V2 API contract.
Changes
Core Migration

Replace /v1/component_status endpoint with /v2/incidents endpoint for incident creation
Implement new V2 incident data structure with fields: title, description, impact, components, start_date, system, and type
Use static title ("System incident from monitoring system") and description ("System-wide incident affecting one or multiple components. Created automatically.") to avoid exposing sensitive operational data on the public Status Dashboard

Component Cache System

Add component cache that fetches from /v2/components at startup
Map (component name, attributes) to component ID with subset attribute matching
Auto-refresh cache when a component is not found
Retry initial cache load up to 3 times with 60-second delays

Configuration Updates

Increase HTTP timeout from 2s to 5s to accommodate V2 API response times
No changes required to existing configuration file format or authorization mechanism (HMAC-signed JWT)

Logging Enhancements

Log comprehensive diagnostic details locally: timestamp, service name, environment, component details, impact value, and triggered metrics with values
Diagnostic details are intentionally excluded from API requests for security

Behavioral Notes

Creates new incident request for every detection; relies on Status Dashboard's duplicate handling
Continues monitoring other services if incident creation fails for one service
Fails to start only if initial component cache load fails after all retries

Testing

Verify incidents are created via V2 API with correct component IDs
Verify component cache refreshes correctly when components are added
Verify existing HMAC authorization works with V2 endpoints

Reviewed-by: Ilia Bakhterev

Author: sgmv

.github/agents/copilot-instructions.md

@@ -22,6 +22,7 @@ cargo test [ONLY COMMANDS FOR ACTIVE TECHNOLOGIES][ONLY COMMANDS FOR ACTIVE TECH
 Rust 1.75+ (edition 2021, per Cargo.toml): Follow standard conventions
 
 ## Recent Changes
+- 003-sd-api-v2-migration: Added [if applicable, e.g., PostgreSQL, CoreData, files or N/A]
 
 - 001-project-documentation: Added Rust 1.75+ (edition 2021, per Cargo.toml) + axum (0.6), tokio (1.28), serde (1.0), tracing (0.1), reqwest (0.11)
 

.github/workflows/ci.yml

@@ -18,12 +18,16 @@ jobs:
     steps:
     - uses: actions/checkout@v4
 
-# Temporarily disabled linting and formatting checks, to be re-enabled later.
-#    - name: Check formatting
-#      run: make fmt-check
-#
-#    - name: Run linter
-#      run: make lint
+    - name: Install Rust
+      uses: dtolnay/rust-toolchain@stable
+      with:
+        components: rustfmt, clippy
+
+    - name: Check formatting
+      run: make fmt-check
+
+    - name: Run linter
+      run: make lint
 
     - name: Run tests
       run: make test
@@ -37,6 +41,5 @@ jobs:
     steps:
     - uses: actions/checkout@v4
 
-
     - name: Run tests with coverage
       run: make coverage-check

.gitignore

@@ -28,3 +28,6 @@ docs/
 coverage/
 tarpaulin-report.html
 cobertura.xml
+
+# ai assistant files
+skills

Cargo.toml

@@ -18,6 +18,7 @@ path="src/bin/reporter.rs"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
+anyhow = "~1.0"
 axum = { version="~0.6" }
 axum-macros = { version="~0.3" }
 chrono = "~0.4"
@@ -45,15 +46,12 @@ uuid = { version = "~1.3", features = ["v4", "fast-rng"] }
 
 [dev-dependencies]
 mockito = "~1.0"
+serial_test = "3.3.1"
 tempfile = "~3.5"
 tokio-test = "*"
 tower = { version = "0.4", features = ["util"] }
 hyper = { version = "0.14", features = ["full"] }
 
-[build-dependencies]
-schemars = "~0.8"
-serde = { version = "~1.0", features = ["derive"] }
-serde_json = "~1.0"
 
 [target.'cfg(all(target_env = "musl", target_pointer_width = "64"))'.dependencies.jemallocator]
 version = "0.3"

Makefile

@@ -110,7 +110,7 @@ lint-fix:
 # ============================================================================
 
 ## Build mdbook documentation
-doc:
+doc: doc-schema
 	mdbook build doc/
 
 ## Serve documentation locally with live reload
@@ -129,6 +129,10 @@ doc-api:
 doc-api-open:
 	cargo doc --no-deps --open
 
+## Generate JSON schema for configuration
+doc-schema:
+	cargo test --lib -- generate_config_schema --ignored --nocapture
+
 ## Clean generated documentation
 doc-clean:
 	rm -rf docs/*
@@ -205,6 +209,7 @@ help:
 	@echo "    doc-open       - Build and open documentation in browser"
 	@echo "    doc-api        - Generate Rust API documentation"
 	@echo "    doc-api-open   - Generate and open Rust API docs in browser"
+	@echo "    doc-schema     - Generate JSON schema for configuration"
 	@echo "    doc-clean      - Clean generated documentation"
 	@echo ""
 	@echo "  Utilities:"

README.md

@@ -73,7 +73,7 @@ mdbook serve doc/
 ### Running Tests
 
 ```bash
-# Run all tests
+# Run all unit tests
 cargo test
 
 # Run tests with output
@@ -86,6 +86,31 @@ cargo test common::tests
 cargo test -- --test-threads=4
 ```
 
+### E2E Integration Tests
+
+End-to-end tests validate the complete pipeline using real Docker containers (go-carbon + carbonapi).
+
+#### Prerequisites
+- Docker installed and running
+- Ports available: 2003, 8080, 3005, 9999
+
+#### Running E2E Tests
+
+```bash
+# Run E2E tests (Docker containers are managed automatically)
+cargo test --test integration_e2e_reporter -- --ignored --nocapture
+```
+
+The E2E test validates 4 scenarios:
+| Scenario | Expected Weight | Description |
+|----------|-----------------|-------------|
+| healthy | 0 | All metrics within thresholds |
+| degraded_slow | 1 | API response time > 1200ms |
+| degraded_errors | 1 | Success rate < 65% |
+| outage | 2 | 100% API failures |
+
+For details, see [Testing Guide](doc/testing.md).
+
 ### Test Coverage
 
 ```bash
@@ -99,8 +124,6 @@ cargo tarpaulin --out Html
 open tarpaulin-report.html
 ```
 
-For detailed testing documentation, see [Testing Guide](doc/testing.md).
-
 ### JSON Schema for Configuration
 
 A JSON Schema for configuration validation is auto-generated during build:

build.rs

@@ -89,7 +89,33 @@ This section is providing capability to describe query templates to be later ref
 
 ## status_dashboard
 
-Configures URL and jwt secret for communication with the status dashboard
+Configures URL and JWT secret for communication with the status dashboard.
+
+```yaml
+status_dashboard:
+  url: "https://status-dashboard.example.com"
+  secret: "your-jwt-secret"
+```
+
+| Property | Type   | Required | Default | Description                           |
+|----------|--------|----------|---------|---------------------------------------|
+| `url`    | string | Yes      | -       | Status Dashboard API URL              |
+| `secret` | string | No       | -       | JWT signing secret for authentication |
+
+## health_query
+
+Configures the time window for health metric queries.
+
+```yaml
+health_query:
+  query_from: "-5min"
+  query_to: "-2min"
+```
+
+| Property     | Type   | Required | Default | Description                                                         |
+|--------------|--------|----------|---------|---------------------------------------------------------------------|
+| `query_from` | string | No       | `-5min` | Start time offset for health metric queries (e.g., "-10min", "-1h") |
+| `query_to`   | string | No       | `-2min` | End time offset for health metric queries (e.g., "-1min", "-30s")   |
 
 ## flag_metrics
 

doc/config.md

@@ -52,8 +52,8 @@ TSDB connection configuration.
 
 | Property | Type | Required | Default | Description |
 |----------|------|----------|---------|-------------|
-| `url` | string | Yes | - | TSDB URL (e.g., `http://graphite:8080`) |
-| `timeout` | integer | No | `10` | Query timeout in seconds |
+| `url` | string | Yes | -       | TSDB URL (e.g., `http://graphite:8080`) |
+| `timeout` | integer | No | `2`     | Query timeout in seconds |
 
 ```yaml
 datasource: