remove unused util funcs

Author: rubenhoenle

internal/pkg/services/postgresflex/utils/utils.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"fmt"
 	"slices"
-	"strings"
 
 	"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
 
@@ -18,12 +17,6 @@ var instanceTypeToReplicas = map[string]int32{
 	"Replica": 3,
 }
 
-type PostgresFlexClient interface {
-	ListVersions(ctx context.Context, projectId, region string) postgresflex.ApiListVersionsRequest
-	GetInstance(ctx context.Context, projectId, region, instanceId string) postgresflex.ApiGetInstanceRequest
-	GetUser(ctx context.Context, projectId, region, instanceId, userId string) postgresflex.ApiGetUserRequest
-}
-
 func AvailableInstanceTypes() []string {
 	instanceTypes := make([]string, len(instanceTypeToReplicas))
 	i := 0
@@ -37,40 +30,6 @@ func AvailableInstanceTypes() []string {
 	return instanceTypes
 }
 
-func GetInstanceReplicas(instanceType string) (int32, error) {
-	numReplicas, ok := instanceTypeToReplicas[instanceType]
-	if !ok {
-		return 0, fmt.Errorf("invalid instance type: %v", instanceType)
-	}
-	return numReplicas, nil
-}
-
-func GetInstanceType(numReplicas int32) (string, error) {
-	for k, v := range instanceTypeToReplicas {
-		if v == numReplicas {
-			return k, nil
-		}
-	}
-	return "", fmt.Errorf("invalid number of replicas: %v", numReplicas)
-}
-
-func ValidateFlavorId(flavorId string, flavors []postgresflex.ListFlavors) error {
-	if flavors == nil {
-		return fmt.Errorf("nil flavors")
-	}
-
-	for _, f := range flavors {
-		if strings.EqualFold(f.Id, flavorId) {
-			return nil
-		}
-	}
-
-	return &errors.DatabaseInvalidFlavorError{
-		Service: "postgresflex",
-		Details: fmt.Sprintf("You provided flavor ID '%s', which is invalid.", flavorId),
-	}
-}
-
 func LoadFlavorId(cpu, ram int64, flavors []postgresflex.ListFlavors) (*string, error) {
 	if flavors == nil {
 		return nil, fmt.Errorf("nil flavors")

internal/pkg/services/postgresflex/utils/utils_test.go

@@ -56,60 +56,6 @@ func newAPIMockClient(s mockSettings) postgresflex.DefaultAPI {
 	}
 }
 
-func TestValidateFlavorId(t *testing.T) {
-	tests := []struct {
-		description string
-		flavorId    string
-		flavors     []postgresflex.ListFlavors
-		isValid     bool
-	}{
-		{
-			description: "base",
-			flavorId:    "foo",
-			flavors: []postgresflex.ListFlavors{
-				{Id: "bar-1"},
-				{Id: "bar-2"},
-				{Id: "foo"},
-			},
-			isValid: true,
-		},
-		{
-			description: "nil flavors",
-			flavorId:    "foo",
-			flavors:     nil,
-			isValid:     false,
-		},
-		{
-			description: "no flavors",
-			flavorId:    "foo",
-			flavors:     []postgresflex.ListFlavors{},
-			isValid:     false,
-		},
-		{
-			description: "invalid flavor",
-			flavorId:    "foo",
-			flavors: []postgresflex.ListFlavors{
-				{Id: "bar-1"},
-				{Id: "bar-2"},
-				{Id: "bar-3"},
-			},
-			isValid: false,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.description, func(t *testing.T) {
-			err := ValidateFlavorId(tt.flavorId, tt.flavors)
-			if tt.isValid && err != nil {
-				t.Fatalf("should not have failed: %v", err)
-			}
-			if !tt.isValid && err == nil {
-				t.Fatalf("should have failed")
-			}
-		})
-	}
-}
-
 func TestLoadFlavorId(t *testing.T) {
 	tests := []struct {
 		description    string
@@ -358,49 +304,3 @@ func TestGetUserName(t *testing.T) {
 		})
 	}
 }
-
-func TestGetInstanceType(t *testing.T) {
-	tests := []struct {
-		description    string
-		numReplicas    int32
-		expectedOutput string
-		isValid        bool
-	}{
-		{
-			description:    "single",
-			numReplicas:    1,
-			expectedOutput: "Single",
-			isValid:        true,
-		},
-		{
-			description:    "replica set",
-			numReplicas:    3,
-			expectedOutput: "Replica",
-			isValid:        true,
-		},
-		{
-			description: "invalid",
-			numReplicas: 0,
-			isValid:     false,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.description, func(t *testing.T) {
-			output, err := GetInstanceType(tt.numReplicas)
-			if !tt.isValid {
-				if err == nil {
-					t.Fatalf("did not fail on invalid input")
-				}
-				return
-			}
-			if err != nil {
-				t.Fatalf("failed on valid input: %v", err)
-			}
-
-			if output != tt.expectedOutput {
-				t.Fatalf("expected output to be %s, got %s", tt.expectedOutput, output)
-			}
-		})
-	}
-}