From fd2154fcb2b6e865e665524580bea799aaebef0e Mon Sep 17 00:00:00 2001 From: Techassi Date: Mon, 12 Jan 2026 14:38:32 +0100 Subject: [PATCH 1/2] chore(webhook): Hide ByteString in instrumentation --- crates/stackable-webhook/src/webhooks/conversion_webhook.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/stackable-webhook/src/webhooks/conversion_webhook.rs b/crates/stackable-webhook/src/webhooks/conversion_webhook.rs index 0e779ee4e..37d871120 100644 --- a/crates/stackable-webhook/src/webhooks/conversion_webhook.rs +++ b/crates/stackable-webhook/src/webhooks/conversion_webhook.rs @@ -135,7 +135,7 @@ impl ConversionWebhook { } #[instrument( - skip(self, crd, crd_api), + skip(self, crd, crd_api, new_ca_bundle), fields( name = crd.name_any(), kind = &crd.spec.names.kind From 9d687cecbb518619c4dd8081f6550a7915acf868 Mon Sep 17 00:00:00 2001 From: Techassi Date: Mon, 12 Jan 2026 14:46:19 +0100 Subject: [PATCH 2/2] chore(webhook): Also hide the ByteString in the rotation handlers --- crates/stackable-webhook/src/webhooks/conversion_webhook.rs | 2 +- crates/stackable-webhook/src/webhooks/mutating_webhook.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/stackable-webhook/src/webhooks/conversion_webhook.rs b/crates/stackable-webhook/src/webhooks/conversion_webhook.rs index 37d871120..c0f11b7d0 100644 --- a/crates/stackable-webhook/src/webhooks/conversion_webhook.rs +++ b/crates/stackable-webhook/src/webhooks/conversion_webhook.rs @@ -244,7 +244,7 @@ where self.options.disable_crd_maintenance } - #[instrument(skip(self))] + #[instrument(skip(self, new_ca_bundle))] async fn handle_certificate_rotation( &mut self, new_ca_bundle: &ByteString, diff --git a/crates/stackable-webhook/src/webhooks/mutating_webhook.rs b/crates/stackable-webhook/src/webhooks/mutating_webhook.rs index a214356c7..1beb12cde 100644 --- a/crates/stackable-webhook/src/webhooks/mutating_webhook.rs +++ b/crates/stackable-webhook/src/webhooks/mutating_webhook.rs @@ -206,7 +206,7 @@ where self.options.disable_mwc_maintenance } - #[instrument(skip(self))] + #[instrument(skip(self, new_ca_bundle))] async fn handle_certificate_rotation( &mut self, new_ca_bundle: &ByteString,