Closing bug fixes

Closing a file-backed database no longer deletes the underlying file.

In WAL journal mode, closing the database causes a WAL checkpoint.

Author: stack

CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 2.1.2 2023-09-07
+### Fixed
+-   Closing a file-backed database no longer deletes the underlying file.
+-   In WAL journal mode, closing the database causes a WAL checkpoint.
+
 ## 2.1.1 2023-09-07
 ### Fixed
 -   Storing a `Statement` no longer causes a crash when cleaning up.

Sources/Restructure/Restructure.swift

@@ -139,18 +139,20 @@ public class Restructure {
             return
         }
 
-        preparedStatements.forEach {
-            sqlite3_finalize($0)
+        // Finalize all known statements
+        for statement in preparedStatements {
+            sqlite3_finalize(statement)
         }
 
         preparedStatements.removeAll()
 
-        sqlite3_close_v2(db)
-        
-        if let filePath = path {
-            try? FileManager.default.removeItem(atPath: filePath)
+        // In WAL mode, force a flush
+        if journalMode == .wal {
+            sqlite3_wal_checkpoint_v2(db, nil, SQLITE_CHECKPOINT_TRUNCATE, nil, nil)
         }
 
+        // Final close
+        sqlite3_close_v2(db)
         isOpen = false
     }
 

Tests/RestructureTests/RestructureInitializationTests.swift

@@ -54,24 +54,6 @@ class RestructureInitializationTests: XCTestCase {
         XCTAssertNotNil(restructure)
     }
 
-    func testClosingTemporaryDeletedFile() {
-        // Ensure the file doesn't exist
-        XCTAssertFalse(FileManager.default.fileExists(atPath: tempPath))
-        
-        // Build the structure
-        restructure = try! Restructure(path: tempPath)
-        restructure!.isTemporary = true
-        
-        // Ensure the file does exist
-        XCTAssertTrue(FileManager.default.fileExists(atPath: tempPath))
-        
-        // Close and clean up
-        restructure!.close()
-        
-        // Ensure the file doesn't exist
-        XCTAssertFalse(FileManager.default.fileExists(atPath: tempPath))
-    }
-    
     func testJournalModeDefault() {
         restructure = try! Restructure(path: tempPath)
         XCTAssertEqual(restructure!.journalMode, .wal)