Script browse facet not functioning correctly

[wlpotter]

The script facet currently is listing all of the scripts that appear in the manuscript record (physDesc/handDesc/handNote/@script) in a space-separated list. https://d2tcgfyrf82nxz.cloudfront.net/dev-browse.html

Instead, we want the dropdown menu to be a list of the individual scripts (using human-readable labels instead of the script codes themselves). Then when a script is selected, it returns any records whose scripts field contains the selected script. It's possible we want to restrict this to the @scope="major" handNote's script? (This would result in each result only having one script value, once #428 is implemented)

Question to discuss: is it possible to have the options in the script list update based on the other facets? (e.g., if no ms in the "Chemistry" classification has East Syriac script, would that option be listed in the dropdown?)

[wlpotter]

For the human-readable label, we can create a lookup table (we may already have that somewhere), but these are also in each TEI XML documents already: /TEI/teiHeader/profileDesc/langUsage/language (@ident is the value found in the handNote/@script attribute; with human-readable label as the language/text() node)

[emgeier]

I don't see the codes here, could you provide a screenshot? [https://d2tcgfyrf82nxz.cloudfront.net/browse.html]

[wlpotter]

Hmm it is working differently now and is showing the human-readable labels, which is great! (should I be using browse.html or dev-browse.html? the latter was what we had put in the meeting notes so just want to confirm).

It looks like we're missing a label for the ar-Syrc script. Do you know where the labels are coming from?

I think we also want to discuss whether we should limit the scripts to just the ones in the handDesc elements marked as @scope="major" or not, so I'll add this to the meeting agenda for next week

[wlpotter]

Please use this For labels: https://github.com/srophe/britishLibrary/blob/main/siteGenerator/xsl/helper-functions.xsl#L289

[wlpotter]

Restrict the script facet to handNote[@scope="major"] or handNote[@scope="sole"]. Relabel facet on browse.html "Primary Script"