Skip to content

Commit 642c433

Browse files
committed
SQUASHME: more PR feedback
1 parent 644e74d commit 642c433

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

core/src/checks/wycheproof_checks.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,15 +123,16 @@ static bool should_ignore_failure(size_t vector_label) {
123123

124124
// runs tests against each wycheproof vector and reports any failures
125125
int verify_wycheproof(void) {
126+
// inline the include to have the smallest scope possible for the variables defined in the include file.
126127
#include "wycheproof/ecdsa_secp256k1_sha256_bitcoin_test.h"
127128

128129
int failures = 0;
129130
for (size_t t = 0; t < SECP256K1_ECDSA_WYCHEPROOF_NUMBER_TESTVECTORS; t++) {
130131
// The json test vectors are 1-indexed.
131132
const size_t vector_label = t + 1;
132-
const unsigned char *msg;
133-
const unsigned char *der_sig;
134-
const unsigned char *pk;
133+
const uint8_t *msg = NULL;
134+
const uint8_t *der_sig = NULL;
135+
const uint8_t *pk = NULL;
135136
const ecdsa_curve *curve = &secp256k1;
136137
uint8_t sig[64] = {0};
137138
curve_point pub;

0 commit comments

Comments
 (0)