|
| 1 | +package golang |
| 2 | + |
| 3 | +import ( |
| 4 | + "strings" |
| 5 | + "testing" |
| 6 | +) |
| 7 | + |
| 8 | +func field(name, typ string) Field { |
| 9 | + return Field{Name: name, Type: typ, Tags: map[string]string{"json": name}} |
| 10 | +} |
| 11 | + |
| 12 | +func TestInternJSONTypes(t *testing.T) { |
| 13 | + t.Run("first occurrence is emitted", func(t *testing.T) { |
| 14 | + seen := map[string]JSONType{} |
| 15 | + toEmit, err := internJSONTypes(seen, modelTypeSet{}, []JSONType{ |
| 16 | + {Name: "Book", Fields: []Field{field("id", "int64")}}, |
| 17 | + }) |
| 18 | + if err != nil { |
| 19 | + t.Fatalf("unexpected error: %v", err) |
| 20 | + } |
| 21 | + if len(toEmit) != 1 { |
| 22 | + t.Fatalf("expected 1 type to emit, got %d", len(toEmit)) |
| 23 | + } |
| 24 | + }) |
| 25 | + |
| 26 | + t.Run("same name and shape is interned, not re-emitted", func(t *testing.T) { |
| 27 | + seen := map[string]JSONType{} |
| 28 | + book := JSONType{Name: "Book", Fields: []Field{field("id", "int64")}} |
| 29 | + if _, err := internJSONTypes(seen, modelTypeSet{}, []JSONType{book}); err != nil { |
| 30 | + t.Fatalf("unexpected error: %v", err) |
| 31 | + } |
| 32 | + toEmit, err := internJSONTypes(seen, modelTypeSet{}, []JSONType{book}) |
| 33 | + if err != nil { |
| 34 | + t.Fatalf("unexpected error: %v", err) |
| 35 | + } |
| 36 | + if len(toEmit) != 0 { |
| 37 | + t.Errorf("expected 0 types to emit on reuse, got %d", len(toEmit)) |
| 38 | + } |
| 39 | + }) |
| 40 | + |
| 41 | + t.Run("same name, different fields is a conflict", func(t *testing.T) { |
| 42 | + seen := map[string]JSONType{} |
| 43 | + if _, err := internJSONTypes(seen, modelTypeSet{}, []JSONType{ |
| 44 | + {Name: "Book", Fields: []Field{field("id", "int64")}}, |
| 45 | + }); err != nil { |
| 46 | + t.Fatalf("unexpected error: %v", err) |
| 47 | + } |
| 48 | + _, err := internJSONTypes(seen, modelTypeSet{}, []JSONType{ |
| 49 | + {Name: "Book", Fields: []Field{field("id", "int64"), field("title", "string")}}, |
| 50 | + }) |
| 51 | + if err == nil || !strings.Contains(err.Error(), "conflicting shapes") { |
| 52 | + t.Errorf("error = %v, want mention of conflicting shapes", err) |
| 53 | + } |
| 54 | + }) |
| 55 | + |
| 56 | + t.Run("scalar and array uses of the same name intern together", func(t *testing.T) { |
| 57 | + // The struct declaration is identical either way; only the |
| 58 | + // referencing field gains a [] prefix, so these aren't a conflict. |
| 59 | + seen := map[string]JSONType{} |
| 60 | + book := JSONType{Name: "Book", Fields: []Field{field("id", "int64")}} |
| 61 | + if _, err := internJSONTypes(seen, modelTypeSet{}, []JSONType{book}); err != nil { |
| 62 | + t.Fatalf("unexpected error: %v", err) |
| 63 | + } |
| 64 | + if _, err := internJSONTypes(seen, modelTypeSet{}, []JSONType{book}); err != nil { |
| 65 | + t.Errorf("unexpected error reusing the same shape: %v", err) |
| 66 | + } |
| 67 | + }) |
| 68 | + |
| 69 | + t.Run("name collides with an existing model", func(t *testing.T) { |
| 70 | + seen := map[string]JSONType{} |
| 71 | + models := modelTypeSet{"Book": struct{}{}} |
| 72 | + _, err := internJSONTypes(seen, models, []JSONType{ |
| 73 | + {Name: "Book", Fields: []Field{field("id", "int64")}}, |
| 74 | + }) |
| 75 | + if err == nil || !strings.Contains(err.Error(), "collides with an existing model") { |
| 76 | + t.Errorf("error = %v, want mention of model collision", err) |
| 77 | + } |
| 78 | + }) |
| 79 | +} |
| 80 | + |
| 81 | +func TestSameJSONShape(t *testing.T) { |
| 82 | + tests := []struct { |
| 83 | + name string |
| 84 | + a, b JSONType |
| 85 | + want bool |
| 86 | + }{ |
| 87 | + { |
| 88 | + name: "identical", |
| 89 | + a: JSONType{Fields: []Field{field("x", "int32")}}, |
| 90 | + b: JSONType{Fields: []Field{field("x", "int32")}}, |
| 91 | + want: true, |
| 92 | + }, |
| 93 | + { |
| 94 | + name: "different field count", |
| 95 | + a: JSONType{Fields: []Field{field("x", "int32")}}, |
| 96 | + b: JSONType{Fields: []Field{field("x", "int32"), field("y", "string")}}, |
| 97 | + want: false, |
| 98 | + }, |
| 99 | + { |
| 100 | + name: "different field type", |
| 101 | + a: JSONType{Fields: []Field{field("x", "int32")}}, |
| 102 | + b: JSONType{Fields: []Field{field("x", "string")}}, |
| 103 | + want: false, |
| 104 | + }, |
| 105 | + { |
| 106 | + name: "different field name", |
| 107 | + a: JSONType{Fields: []Field{field("x", "int32")}}, |
| 108 | + b: JSONType{Fields: []Field{field("y", "int32")}}, |
| 109 | + want: false, |
| 110 | + }, |
| 111 | + } |
| 112 | + for _, tt := range tests { |
| 113 | + t.Run(tt.name, func(t *testing.T) { |
| 114 | + if got := sameJSONShape(tt.a, tt.b); got != tt.want { |
| 115 | + t.Errorf("sameJSONShape() = %v, want %v", got, tt.want) |
| 116 | + } |
| 117 | + }) |
| 118 | + } |
| 119 | +} |
0 commit comments