Add UseStaticImport #48630

Signed-off-by: Vincent Potucek <vpotucek@me.com>

Author: Vincent Potucek

.github/actions/build/action.yml

@@ -69,6 +69,16 @@ runs:
         COMMERCIAL_REPO_USERNAME: ${{ inputs.commercial-repository-username }}
         COMMERCIAL_SNAPSHOT_REPO_URL: ${{ inputs.commercial-snapshot-repository-url }}
       run: ./gradlew build
+    - name: Sanity Check
+      id: sanity
+      if: ${{ inputs.publish == 'false' }}
+      shell: bash
+      env:
+        COMMERCIAL_RELEASE_REPO_URL: ${{ inputs.commercial-release-repository-url }}
+        COMMERCIAL_REPO_PASSWORD: ${{ inputs.commercial-repository-password }}
+        COMMERCIAL_REPO_USERNAME: ${{ inputs.commercial-repository-username }}
+        COMMERCIAL_SNAPSHOT_REPO_URL: ${{ inputs.commercial-snapshot-repository-url }}
+      run: ./gradlew rewriteDryRun -Dorg.gradle.jvmargs=-Xmx12G
     - name: Publish
       id: publish
       if: ${{ inputs.publish == 'true' }}

.github/workflows/build-pull-request.yml

@@ -13,6 +13,9 @@ jobs:
       - name: Build
         id: build
         uses: ./.github/actions/build
+      - name: Sanity
+        id: sanity
+        uses: ./.github/actions/build
       - name: Print JVM Thread Dumps When Cancelled
         if: cancelled()
         uses: ./.github/actions/print-jvm-thread-dumps

build-plugin/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/tasks/buildinfo/BuildInfoProperties.java

@@ -37,6 +37,8 @@
 import org.gradle.api.tasks.Optional;
 import org.jspecify.annotations.Nullable;
 
+import static java.util.Collections.emptySet;
+
 /**
  * The properties that are written into the {@code build-info.properties} file.
  *
@@ -148,7 +150,7 @@ Map<String, String> getAdditionalIfNotExcluded() {
 	}
 
 	private <T> @Nullable T getIfNotExcluded(Property<T> property, String name, Supplier<@Nullable T> defaultValue) {
-		if (this.excludes.getOrElse(Collections.emptySet()).contains(name)) {
+		if (this.excludes.getOrElse(emptySet()).contains(name)) {
 			return null;
 		}
 		if (property.isPresent()) {
@@ -172,7 +174,7 @@ private Map<String, String> coerceToStringValues(Map<String, Object> input) {
 
 	private Map<String, Object> applyExclusions(Map<String, Object> input) {
 		Map<String, Object> output = new HashMap<>();
-		Set<String> exclusions = this.excludes.getOrElse(Collections.emptySet());
+		Set<String> exclusions = this.excludes.getOrElse(emptySet());
 		input.forEach((key, value) -> {
 			boolean isExcluded = exclusions.contains(key);
 			if (!isExcluded) {

build-plugin/spring-boot-maven-plugin/src/test/java/org/springframework/boot/maven/ArtifactsLibrariesTests.java

@@ -41,6 +41,7 @@
 import org.springframework.boot.loader.tools.LibraryCoordinates;
 import org.springframework.boot.loader.tools.LibraryScope;
 
+import static java.util.Collections.emptySet;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.ArgumentMatchers.assertArg;
 import static org.mockito.BDDMockito.given;
@@ -200,7 +201,7 @@ void nonIncludedArtifact() throws IOException {
 		MavenProject mavenProject = mock(MavenProject.class);
 		given(mavenProject.getArtifact()).willReturn(artifact);
 		this.artifacts = Collections.singleton(artifact);
-		new ArtifactsLibraries(this.artifacts, Collections.emptySet(), Collections.singleton(mavenProject), null,
+		new ArtifactsLibraries(this.artifacts, emptySet(), Collections.singleton(mavenProject), null,
 				mock(Log.class))
 			.doWithLibraries((library) -> assertThat(library.isIncluded()).isFalse());
 	}

build.gradle

@@ -16,6 +16,7 @@
 
 plugins {
 	id "base"
+	id "org.openrewrite.rewrite" version "7.23.0" apply false
 }
 
 description = "Spring Boot Build"
@@ -46,3 +47,5 @@ subprojects {
 		resolutionStrategy.cacheChangingModulesFor 0, "minutes"
 	}
 }
+
+apply from: rootProject.file("gradle/plugins/config/sanity.gradle")

buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/io/FilePermissionsTests.java

@@ -23,7 +23,6 @@
 import java.nio.file.attribute.FileAttribute;
 import java.nio.file.attribute.PosixFilePermission;
 import java.nio.file.attribute.PosixFilePermissions;
-import java.util.Collections;
 import java.util.Set;
 
 import org.junit.jupiter.api.Test;
@@ -32,6 +31,7 @@
 import org.junit.jupiter.api.condition.OS;
 import org.junit.jupiter.api.io.TempDir;
 
+import static java.util.Collections.emptySet;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatIOException;
 import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
@@ -86,7 +86,7 @@ void posixPermissionsToUmask() {
 
 	@Test
 	void posixPermissionsToUmaskWithEmptyPermissions() {
-		Set<PosixFilePermission> permissions = Collections.emptySet();
+		Set<PosixFilePermission> permissions = emptySet();
 		assertThat(FilePermissions.posixPermissionsToUmask(permissions)).isZero();
 	}
 

configuration-metadata/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/fieldvalues/javac/VariableTree.java

@@ -16,11 +16,12 @@
 
 package org.springframework.boot.configurationprocessor.fieldvalues.javac;
 
-import java.util.Collections;
 import java.util.Set;
 
 import javax.lang.model.element.Modifier;
 
+import static java.util.Collections.emptySet;
+
 /**
  * Reflection based access to {@code com.sun.source.tree.VariableTree}.
  *
@@ -49,7 +50,7 @@ ExpressionTree getInitializer() throws Exception {
 	Set<Modifier> getModifierFlags() throws Exception {
 		Object modifiers = findMethod("getModifiers").invoke(getInstance());
 		if (modifiers == null) {
-			return Collections.emptySet();
+			return emptySet();
 		}
 		return (Set<Modifier>) findMethod(findClass("com.sun.source.tree.ModifiersTree"), "getFlags").invoke(modifiers);
 	}

core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/AutoConfigurationImportSelector.java

@@ -61,6 +61,8 @@
 import org.springframework.util.CollectionUtils;
 import org.springframework.util.StringUtils;
 
+import static java.util.Collections.emptySet;
+
 /**
  * {@link DeferredImportSelector} to handle {@link EnableAutoConfiguration
  * auto-configuration}. This class can also be subclassed if a custom variant of
@@ -546,7 +548,7 @@ protected static class AutoConfigurationEntry {
 
 		private AutoConfigurationEntry() {
 			this.configurations = Collections.emptyList();
-			this.exclusions = Collections.emptySet();
+			this.exclusions = emptySet();
 		}
 
 		/**

core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/AutoConfigurationSorter.java

@@ -37,6 +37,8 @@
 import org.springframework.core.type.classreading.MetadataReaderFactory;
 import org.springframework.util.Assert;
 
+import static java.util.Collections.emptySet;
+
 /**
  * Sort {@link EnableAutoConfiguration auto-configuration} classes into priority order by
  * reading {@link AutoConfigureOrder @AutoConfigureOrder},
@@ -226,7 +228,7 @@ private Set<String> getClassNames(String metadataKey, Class<? extends Annotation
 
 		private Set<String> getSet(String metadataKey) {
 			Assert.state(this.autoConfigurationMetadata != null, "'autoConfigurationMetadata' must not be null");
-			return this.autoConfigurationMetadata.getSet(this.className, metadataKey, Collections.emptySet());
+			return this.autoConfigurationMetadata.getSet(this.className, metadataKey, emptySet());
 		}
 
 		private Set<String> applyReplacements(Set<String> values) {
@@ -265,7 +267,7 @@ private Set<String> getAnnotationValue(Class<?> annotation) {
 			Map<String, @Nullable Object> attributes = getAnnotationMetadata()
 				.getAnnotationAttributes(annotation.getName(), true);
 			if (attributes == null) {
-				return Collections.emptySet();
+				return emptySet();
 			}
 			Set<String> result = new LinkedHashSet<>();
 			String[] value = (String[]) attributes.get("value");

core/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/OnBeanCondition.java

@@ -72,6 +72,8 @@
 import org.springframework.util.ReflectionUtils;
 import org.springframework.util.StringUtils;
 
+import static java.util.Collections.emptySet;
+
 /**
  * {@link Condition} that checks for the presence or absence of specific beans.
  *
@@ -315,7 +317,7 @@ private Set<String> getNamesOfBeansIgnoredByType(ListableBeanFactory beanFactory
 				.keySet();
 			result = addAll(result, ignoredNames);
 		}
-		return (result != null) ? result : Collections.emptySet();
+		return (result != null) ? result : emptySet();
 	}
 
 	private Map<String, @Nullable BeanDefinition> getBeanDefinitionsForType(ListableBeanFactory beanFactory,
@@ -607,7 +609,7 @@ protected Set<String> extractTypes(@Nullable MultiValueMap<String, @Nullable Obj
 		private Set<String> extract(@Nullable MultiValueMap<String, @Nullable Object> attributes,
 				String... attributeNames) {
 			if (CollectionUtils.isEmpty(attributes)) {
-				return Collections.emptySet();
+				return emptySet();
 			}
 			Set<String> result = new LinkedHashSet<>();
 			for (String attributeName : attributeNames) {
@@ -621,7 +623,7 @@ else if (value instanceof String string) {
 					}
 				}
 			}
-			return result.isEmpty() ? Collections.emptySet() : result;
+			return result.isEmpty() ? emptySet() : result;
 		}
 
 		private void merge(Set<String> result, String... additional) {