From 2e91fbf0a2a2a244d0155218700ed59089585520 Mon Sep 17 00:00:00 2001
From: brendandebeasi <brendandebeasi@users.noreply.github.com>
Date: Tue, 12 May 2026 19:20:54 -0700
Subject: [PATCH 1/2] feat(ai): add enterToSubmit prop to ChatComposer

Lets consumers opt into modifier-based send (Enter for newline,
Cmd/Ctrl/Alt+Enter to send) instead of Enter-to-send. Defaults to
true so existing usage is unchanged. Also guards against IME
composition events.
---
 packages/ai/src/ChatComposer.tsx | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/packages/ai/src/ChatComposer.tsx b/packages/ai/src/ChatComposer.tsx
index e3380ef..5ffc13d 100644
--- a/packages/ai/src/ChatComposer.tsx
+++ b/packages/ai/src/ChatComposer.tsx
@@ -10,7 +10,7 @@ import {
 	usePopover,
 } from "@spacedrive/primitives";
 import {AnimatePresence, motion} from "framer-motion";
-import {type ReactNode} from "react";
+import {type KeyboardEvent, type ReactNode} from "react";
 
 import {ModelSelector} from "./ModelSelector";
 import type {ModelOption} from "./types";
@@ -45,6 +45,11 @@ export interface ChatComposerProps {
 	onOpenVoice?: () => void;
 	/** Optional content rendered at the far right of the toolbar (before send) */
 	toolbarExtra?: ReactNode;
+	/**
+	 * If true (default), Enter sends and Shift+Enter inserts a newline.
+	 * If false, Enter inserts a newline and Cmd/Ctrl/Alt+Enter sends.
+	 */
+	enterToSubmit?: boolean;
 }
 
 /**
@@ -62,9 +67,23 @@ export function ChatComposer({
 	modelSelector,
 	onOpenVoice,
 	toolbarExtra,
+	enterToSubmit = true,
 }: ChatComposerProps) {
 	const canSend = !isSending && draft.trim().length > 0;
 
+	const handleKeyDown = (event: KeyboardEvent<HTMLTextAreaElement>) => {
+		if (event.key !== "Enter" || event.nativeEvent.isComposing) return;
+		const hasSubmitModifier = event.metaKey || event.ctrlKey || event.altKey;
+		if (enterToSubmit) {
+			if (event.shiftKey) return;
+			event.preventDefault();
+			onSend();
+		} else if (hasSubmitModifier) {
+			event.preventDefault();
+			onSend();
+		}
+	};
+
 	return (
 		<>
 			{heading && (
@@ -80,12 +99,7 @@ export function ChatComposer({
 				<textarea
 					value={draft}
 					onChange={(event) => onDraftChange(event.target.value)}
-					onKeyDown={(event) => {
-						if (event.key === "Enter" && !event.shiftKey) {
-							event.preventDefault();
-							onSend();
-						}
-					}}
+					onKeyDown={handleKeyDown}
 					placeholder={placeholder}
 					rows={2}
 					className="text-ink placeholder:text-ink-faint block w-full resize-none rounded-md border-0 bg-transparent text-sm leading-6 outline-none focus:border-0 focus:outline-none focus:ring-0"

From 17392f62c4b0bcb7ee1a46bda27dbd81a6d72067 Mon Sep 17 00:00:00 2001
From: brendandebeasi <brendandebeasi@users.noreply.github.com>
Date: Tue, 12 May 2026 19:33:56 -0700
Subject: [PATCH 2/2] fix(ai): gate ChatComposer send on canSend in keydown

Match the Send button's enabled state: keyboard-triggered send is now
suppressed when the draft is empty or isSending=true. In Enter-to-send
mode, Enter still preventDefaults so it never inserts a newline; in
modifier-to-send mode, we only preventDefault when we'll actually send.

Addresses CodeRabbit review on #4.
---
 packages/ai/src/ChatComposer.tsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/ai/src/ChatComposer.tsx b/packages/ai/src/ChatComposer.tsx
index 5ffc13d..4a961f2 100644
--- a/packages/ai/src/ChatComposer.tsx
+++ b/packages/ai/src/ChatComposer.tsx
@@ -77,8 +77,9 @@ export function ChatComposer({
 		if (enterToSubmit) {
 			if (event.shiftKey) return;
 			event.preventDefault();
-			onSend();
+			if (canSend) onSend();
 		} else if (hasSubmitModifier) {
+			if (!canSend) return;
 			event.preventDefault();
 			onSend();
 		}