From c163146ab8fba1ccad7d9fa3767536de6f11617b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 7 May 2026 21:48:11 +0000 Subject: [PATCH 1/2] Update tool-versions --- .tool-versions | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.tool-versions b/.tool-versions index eb3b2727..8799b85d 100644 --- a/.tool-versions +++ b/.tool-versions @@ -1,4 +1,4 @@ -golang 1.25.6 -golangci-lint 2.11.2 -nodejs 25.1.0 +golang 1.26.3 +golangci-lint 2.12.2 +nodejs 25.9.0 kind 0.31.0 From 70fe3b43db51c18f43b7432daba25e99ac9b8197 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=86gir=20M=C3=A1ni=20Hauksson?= <54936225+sourcehawk@users.noreply.github.com> Date: Sun, 31 May 2026 05:08:19 +0200 Subject: [PATCH 2/2] fix: satisfy golangci-lint 2.12.2 after toolchain bump golangci-lint 2.12.2 bundles a stricter goconst and the go:fix "inline" govet analyzer. Two adjustments keep the lint green: - Replace the deprecated reflect.Ptr with reflect.Pointer, which the inline analyzer now flags. - goconst now counts occurrences in _test.go files (already excluded from reporting) and flags short generic literals in example and e2e code. Set ignore-tests so test fixtures do not inflate counts, and scope goconst to pkg/ where shared constants prevent drift, leaving illustrative examples and e2e scaffolding to favour inline literals. Co-Authored-By: Claude Opus 4.8 (1M context) --- .golangci.yml | 7 +++++++ pkg/component/builder.go | 2 +- pkg/generic/builder_base.go | 2 +- pkg/recording/resource_event.go | 2 +- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index c8d26213..5fe63024 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -34,6 +34,8 @@ linters: - unused - whitespace settings: + goconst: + ignore-tests: true revive: rules: - name: blank-imports @@ -62,6 +64,11 @@ linters: - goconst - revive path: _test\.go + # Illustrative examples and e2e scaffolding favour inline literals for + # readability; goconst's value is in the reusable library code under pkg/. + - linters: + - goconst + path: ^(examples|e2e)/ - linters: - revive text: dot-imports diff --git a/pkg/component/builder.go b/pkg/component/builder.go index aa9bf776..cf93b36b 100644 --- a/pkg/component/builder.go +++ b/pkg/component/builder.go @@ -213,7 +213,7 @@ func isNilResource(r Resource) bool { } v := reflect.ValueOf(r) switch v.Kind() { - case reflect.Ptr, reflect.Map, reflect.Slice, reflect.Func, reflect.Chan, reflect.Interface: + case reflect.Pointer, reflect.Map, reflect.Slice, reflect.Func, reflect.Chan, reflect.Interface: return v.IsNil() default: return false diff --git a/pkg/generic/builder_base.go b/pkg/generic/builder_base.go index 49601836..f39ac125 100644 --- a/pkg/generic/builder_base.go +++ b/pkg/generic/builder_base.go @@ -14,7 +14,7 @@ func isNil(i any) bool { } v := reflect.ValueOf(i) switch v.Kind() { - case reflect.Chan, reflect.Func, reflect.Map, reflect.Ptr, reflect.UnsafePointer, reflect.Interface, reflect.Slice: + case reflect.Chan, reflect.Func, reflect.Map, reflect.Pointer, reflect.UnsafePointer, reflect.Interface, reflect.Slice: return v.IsNil() default: return false diff --git a/pkg/recording/resource_event.go b/pkg/recording/resource_event.go index 2e4db46f..39cffad4 100644 --- a/pkg/recording/resource_event.go +++ b/pkg/recording/resource_event.go @@ -25,7 +25,7 @@ func typeName(obj any) string { } t := reflect.TypeOf(obj) - for t.Kind() == reflect.Ptr { + for t.Kind() == reflect.Pointer { t = t.Elem() }