Discard changes: fatal error: ambiguous argument

[WelliSolutions]

Repro steps (Windows):

1. git init discard-changes
2. cd discard-changes
3. echo "">test.txt
4. Open the repo in SourceGit
5. For the local changes, click on the "discard all changes button" ⮪
6. Confirm the dialog with OK

Result:

fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Expected:

The untracked file test.txt is cleaned up.

Additional information:
Git Extensions shows the preview as

C:\Program Files\Git\bin\git.exe" clean -d --dry-run
Would remove test.txt
Done

[WelliSolutions]

Potentially, the source of the problem is in line 49 of Discard.cs:

await new Reset(repo, "HEAD", "--hard").Use(log).ExecAsync().ConfigureAwait(false);

Guessing that it runs a git reset command, I can reproduce the problem on command line:

>git reset HEAD --hard
fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

As stated in the error message, one can use -- to separate commands from file names.

>git reset HEAD --hard --

I could try to create a pull request for a change in Reset.cs, line 9 and line 16, adding -- as additional parameters.

But actually, I want to question, whether a git reset --hard is the right move here. IMHO, that would remove staged changes as well. The message says "All local changes in the working copy". I understand the term "working copy" as "working directory", which would exclude staged changes.

[love-linger]

fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

It is just because there is not a revision named HEAD in an empty repo. In fact, this error message does not affect the final result. Because for an empty repo, this command does not need to be executed.

I'll try to remove this error message.

But actually, I want to question, whether a git reset --hard is the right move here. IMHO, that would remove staged changes as well. The message says "All local changes in the working copy". I understand the term "working copy" as "working directory", which would exclude staged changes.

It is possible that the translation here is inaccurate. The original intention should be all local uncommitted changes, including staged ones.

[love-linger]

Fixed.