Fix possibly dangling reference to a temporary warning (#476)

lo-simon · web-flow · commit 3e8aa68f7479 · 2025-12-08T23:18:20.000Z
diff --git a/Development/nmos-cpp-node/node_implementation.cpp b/Development/nmos-cpp-node/node_implementation.cpp
@@ -1293,7 +1293,7 @@ void node_implementation_init(nmos::node_model& model, nmos::experimental::contr
 
                     utility::ostringstream_t role;
                     role << U("receiver-monitor-") << ++count;
-                    const auto& receiver = nmos::find_resource(model.node_resources, receiver_id);
+                    const auto receiver = nmos::find_resource(model.node_resources, receiver_id);
                     auto receiver_monitor = nmos::make_receiver_monitor(++oid, true, receivers_block_oid, role.str(), nmos::fields::label(receiver->data), nmos::fields::description(receiver->data), value_of({ { nmos::nc::details::make_touchpoint_nmos({nmos::ncp_touchpoint_resource_types::receiver, receiver_id}) } }));
                     // optionally indicate dependencies within the device model
                     nmos::set_object_dependency_paths(receiver_monitor, {{U("root"), U("receivers")}});
@@ -1314,7 +1314,7 @@ void node_implementation_init(nmos::node_model& model, nmos::experimental::contr
 
                     utility::ostringstream_t role;
                     role << U("sender-monitor-") << ++count;
-                    const auto& sender = nmos::find_resource(model.node_resources, sender_id);
+                    const auto sender = nmos::find_resource(model.node_resources, sender_id);
                     const auto sender_monitor = nmos::make_sender_monitor(++oid, true, nmos::root_block_oid, role.str(), nmos::fields::label(sender->data), nmos::fields::description(sender->data), value_of({ { nmos::nc::details::make_touchpoint_nmos({nmos::ncp_touchpoint_resource_types::sender, sender_id}) } }));
 
                     // add sender-monitor to root-block
diff --git a/Development/nmos/configuration_api.cpp b/Development/nmos/configuration_api.cpp
@@ -74,7 +74,7 @@ namespace nmos
                     {
                         // get resource based on the oid
                         const auto& oid = nmos::fields::nc::oid(member);
-                        const auto& found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));
+                        const auto found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));
                         if (resources.end() != found)
                         {
                             build_role_paths(resources, *found, role_path, role_paths);
diff --git a/Development/nmos/configuration_methods.cpp b/Development/nmos/configuration_methods.cpp
@@ -68,7 +68,7 @@ namespace nmos
 
                     for (const auto& member : members)
                     {
-                        const auto& found = find_resource(resources, utility::s2us(std::to_string(nmos::fields::nc::oid(member))));
+                        const auto found = find_resource(resources, utility::s2us(std::to_string(nmos::fields::nc::oid(member))));
 
                         if (resources.end() != found)
                         {
diff --git a/Development/nmos/configuration_utils.cpp b/Development/nmos/configuration_utils.cpp
@@ -326,7 +326,7 @@ namespace nmos
                     {
                         // If constant oid then check oid from property holder and verify with oid from block member
                         // Is this oid already in use?
-                        const auto& child = find_resource(resources, utility::s2us(std::to_string(oid)));
+                        const auto child = find_resource(resources, utility::s2us(std::to_string(oid)));
 
                         if (resources.end() != child)
                         {
@@ -577,7 +577,7 @@ namespace nmos
 
         while (utility::s2us(std::to_string(nmos::root_block_oid)) != oid.as_string())
         {
-            const auto& found = nmos::find_resource(resources, utility::s2us(std::to_string(nmos::fields::nc::owner(found_resource.data))));
+            const auto found = nmos::find_resource(resources, utility::s2us(std::to_string(nmos::fields::nc::owner(found_resource.data))));
             if (resources.end() == found)
             {
                 break;
diff --git a/Development/nmos/control_protocol_utils.cpp b/Development/nmos/control_protocol_utils.cpp
@@ -366,7 +366,7 @@ namespace nmos
                         {
                             // get resource based on the oid
                             const auto& oid = nmos::fields::nc::oid(*member_found);
-                            const auto& found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));
+                            const auto found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));
                             if (resources.end() != found)
                             {
                                 return get_nc_block_member_descriptor(resources, *found, role_path_segments);
@@ -411,7 +411,7 @@ namespace nmos
                     auto transition_counter = get_property(resources, oid, status_transition_counter_property_id, get_control_protocol_class_descriptor, gate).as_integer();
                     set_property_and_notify(resources, oid, status_transition_counter_property_id, ++transition_counter, get_control_protocol_class_descriptor, gate);
                 }
-                const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));
+                const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));
                 if (resources.end() != found)
                 {
                     if (nmos::nc::is_sender_monitor(parse_class_id(nmos::fields::nc::class_id(found->data))))
@@ -721,7 +721,7 @@ namespace nmos
                         {
                             // get resource based on the oid
                             const auto& oid = nmos::fields::nc::oid(member);
-                            const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));
+                            const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));
                             if (resources.end() != found)
                             {
                                 nc::get_member_descriptors(resources, *found, recurse, descriptors);
@@ -775,7 +775,7 @@ namespace nmos
                         {
                             // get resource based on the oid
                             const auto& oid = nmos::fields::nc::oid(member);
-                            const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));
+                            const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));
                             if (resources.end() != found)
                             {
                                 nc::find_members_by_role(resources, *found, role, match_whole_string, case_sensitive, recurse, descriptors);
@@ -823,7 +823,7 @@ namespace nmos
                         {
                             // get resource based on the oid
                             const auto& oid = nmos::fields::nc::oid(member);
-                            const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));
+                            const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));
                             if (resources.end() != found)
                             {
                                 nc::find_members_by_class_id(resources, *found, class_id_, include_derived, recurse, descriptors);
@@ -1025,7 +1025,7 @@ namespace nmos
                         if (!block_member_descriptor.is_null())
                         {
                             const auto& oid = nmos::fields::nc::oid(block_member_descriptor);
-                            const auto& found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));
+                            const auto found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));
                             if (resources.end() != found)
                             {
                                 return found;
@@ -1113,7 +1113,7 @@ namespace nmos
         web::json::value get_property(const resources& resources, nc_oid oid, const nc_property_id& property_id, get_control_protocol_class_descriptor_handler get_control_protocol_class_descriptor, slog::base_gate& gate)
         {
             // get resource based on the oid
-            const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));
+            const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));
             if (resources.end() != found)
             {
                 // find the relevant nc_property_descriptor
@@ -1130,7 +1130,7 @@ namespace nmos
 
         bool set_property_and_notify(resources& resources, nc_oid oid, const nc_property_id& property_id, const web::json::value& value, get_control_protocol_class_descriptor_handler get_control_protocol_class_descriptor, slog::base_gate& gate)
         {
-            const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));
+            const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));
             if (resources.end() != found)
             {
                 const auto& property = nc::find_property_descriptor(property_id, nc::details::parse_class_id(nmos::fields::nc::class_id(found->data)), get_control_protocol_class_descriptor);
@@ -1184,7 +1184,7 @@ namespace nmos
         web::json::value get_property(const resources& resources, nc_oid oid, const utility::string_t& property_name, slog::base_gate& gate)
         {
             // get resource based on the oid
-            const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));
+            const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));
             if (resources.end() != found)
             {
                 // find the relevant nc_property_descriptor
@@ -1323,7 +1323,7 @@ namespace nmos
             // domain specific statuses offering an Inactive option MUST transition immediately to the Healthy state.
             // Furthermore, after activation, as long as the monitor isn't being deactivated, it MUST delay the reporting
             // of non Healthy states for the duration specified by statusReportingDelay, and then transition to any other appropriate state.
-            const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));
+            const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));
             if (resources.end() != found && nc::is_status_monitor(nc::details::parse_class_id(nmos::fields::nc::class_id(found->data))))
             {
                 const auto& class_id = nc::details::parse_class_id(nmos::fields::nc::class_id(found->data));
@@ -1382,7 +1382,7 @@ namespace nmos
 
         bool deactivate_monitor(resources& resources, nc_oid oid, get_control_protocol_class_descriptor_handler get_control_protocol_class_descriptor, slog::base_gate& gate)
         {
-            const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));
+            const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));
             if (resources.end() != found && nc::is_status_monitor(nc::details::parse_class_id(nmos::fields::nc::class_id(found->data))))
             {
                 const auto& class_id = nc::details::parse_class_id(nmos::fields::nc::class_id(found->data));
diff --git a/Development/nmos/test/configuration_utils_test.cpp b/Development/nmos/test/configuration_utils_test.cpp
@@ -407,7 +407,7 @@ BST_TEST_CASE(testApplyBackupDataSet)
     };
 
     // Capture initial state of device model so we can reset after each check
-    const auto& root_resource = nmos::nc::find_resource_by_role_path(resources, value_of({ U("root") }).as_array());
+    const auto root_resource = nmos::nc::find_resource_by_role_path(resources, value_of({ U("root") }).as_array());
     auto initial_backup_dataset = nmos::get_properties_by_path(resources, *root_resource, true, false, get_control_protocol_class_descriptor, get_control_protocol_datatype_descriptor, nullptr);
     auto& initial_object_properties_holders = nmos::fields::nc::values(nmos::fields::nc::value(initial_backup_dataset));
 

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ namespace nmos`
`74`	`74`	`{`
`75`	`75`	`// get resource based on the oid`
`76`	`76`	`const auto& oid = nmos::fields::nc::oid(member);`
`77`		`- const auto& found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));`
	`77`	`+ const auto found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));`
`78`	`78`	`if (resources.end() != found)`
`79`	`79`	`{`
`80`	`80`	`build_role_paths(resources, *found, role_path, role_paths);`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ namespace nmos`
`68`	`68`
`69`	`69`	`for (const auto& member : members)`
`70`	`70`	`{`
`71`		`- const auto& found = find_resource(resources, utility::s2us(std::to_string(nmos::fields::nc::oid(member))));`
	`71`	`+ const auto found = find_resource(resources, utility::s2us(std::to_string(nmos::fields::nc::oid(member))));`
`72`	`72`
`73`	`73`	`if (resources.end() != found)`
`74`	`74`	`{`
Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,7 @@ namespace nmos`
`326`	`326`	`{`
`327`	`327`	`// If constant oid then check oid from property holder and verify with oid from block member`
`328`	`328`	`// Is this oid already in use?`
`329`		`- const auto& child = find_resource(resources, utility::s2us(std::to_string(oid)));`
	`329`	`+ const auto child = find_resource(resources, utility::s2us(std::to_string(oid)));`
`330`	`330`
`331`	`331`	`if (resources.end() != child)`
`332`	`332`	`{`
`@@ -577,7 +577,7 @@ namespace nmos`
`577`	`577`
`578`	`578`	`while (utility::s2us(std::to_string(nmos::root_block_oid)) != oid.as_string())`
`579`	`579`	`{`
`580`		`- const auto& found = nmos::find_resource(resources, utility::s2us(std::to_string(nmos::fields::nc::owner(found_resource.data))));`
	`580`	`+ const auto found = nmos::find_resource(resources, utility::s2us(std::to_string(nmos::fields::nc::owner(found_resource.data))));`
`581`	`581`	`if (resources.end() == found)`
`582`	`582`	`{`
`583`	`583`	`break;`
Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ namespace nmos`
`366`	`366`	`{`
`367`	`367`	`// get resource based on the oid`
`368`	`368`	`const auto& oid = nmos::fields::nc::oid(*member_found);`
`369`		`- const auto& found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));`
	`369`	`+ const auto found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));`
`370`	`370`	`if (resources.end() != found)`
`371`	`371`	`{`
`372`	`372`	`return get_nc_block_member_descriptor(resources, *found, role_path_segments);`
`@@ -411,7 +411,7 @@ namespace nmos`
`411`	`411`	`auto transition_counter = get_property(resources, oid, status_transition_counter_property_id, get_control_protocol_class_descriptor, gate).as_integer();`
`412`	`412`	`set_property_and_notify(resources, oid, status_transition_counter_property_id, ++transition_counter, get_control_protocol_class_descriptor, gate);`
`413`	`413`	`}`
`414`		`- const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));`
	`414`	`+ const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));`
`415`	`415`	`if (resources.end() != found)`
`416`	`416`	`{`
`417`	`417`	`if (nmos::nc::is_sender_monitor(parse_class_id(nmos::fields::nc::class_id(found->data))))`
`@@ -721,7 +721,7 @@ namespace nmos`
`721`	`721`	`{`
`722`	`722`	`// get resource based on the oid`
`723`	`723`	`const auto& oid = nmos::fields::nc::oid(member);`
`724`		`- const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));`
	`724`	`+ const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));`
`725`	`725`	`if (resources.end() != found)`
`726`	`726`	`{`
`727`	`727`	`nc::get_member_descriptors(resources, *found, recurse, descriptors);`
`@@ -775,7 +775,7 @@ namespace nmos`
`775`	`775`	`{`
`776`	`776`	`// get resource based on the oid`
`777`	`777`	`const auto& oid = nmos::fields::nc::oid(member);`
`778`		`- const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));`
	`778`	`+ const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));`
`779`	`779`	`if (resources.end() != found)`
`780`	`780`	`{`
`781`	`781`	`nc::find_members_by_role(resources, *found, role, match_whole_string, case_sensitive, recurse, descriptors);`
`@@ -823,7 +823,7 @@ namespace nmos`
`823`	`823`	`{`
`824`	`824`	`// get resource based on the oid`
`825`	`825`	`const auto& oid = nmos::fields::nc::oid(member);`
`826`		`- const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));`
	`826`	`+ const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));`
`827`	`827`	`if (resources.end() != found)`
`828`	`828`	`{`
`829`	`829`	`nc::find_members_by_class_id(resources, *found, class_id_, include_derived, recurse, descriptors);`
`@@ -1025,7 +1025,7 @@ namespace nmos`
`1025`	`1025`	`if (!block_member_descriptor.is_null())`
`1026`	`1026`	`{`
`1027`	`1027`	`const auto& oid = nmos::fields::nc::oid(block_member_descriptor);`
`1028`		`- const auto& found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));`
	`1028`	`+ const auto found = nmos::find_resource(resources, utility::s2us(std::to_string(oid)));`
`1029`	`1029`	`if (resources.end() != found)`
`1030`	`1030`	`{`
`1031`	`1031`	`return found;`
`@@ -1113,7 +1113,7 @@ namespace nmos`
`1113`	`1113`	`web::json::value get_property(const resources& resources, nc_oid oid, const nc_property_id& property_id, get_control_protocol_class_descriptor_handler get_control_protocol_class_descriptor, slog::base_gate& gate)`
`1114`	`1114`	`{`
`1115`	`1115`	`// get resource based on the oid`
`1116`		`- const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));`
	`1116`	`+ const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));`
`1117`	`1117`	`if (resources.end() != found)`
`1118`	`1118`	`{`
`1119`	`1119`	`// find the relevant nc_property_descriptor`
`@@ -1130,7 +1130,7 @@ namespace nmos`
`1130`	`1130`
`1131`	`1131`	`bool set_property_and_notify(resources& resources, nc_oid oid, const nc_property_id& property_id, const web::json::value& value, get_control_protocol_class_descriptor_handler get_control_protocol_class_descriptor, slog::base_gate& gate)`
`1132`	`1132`	`{`
`1133`		`- const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));`
	`1133`	`+ const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));`
`1134`	`1134`	`if (resources.end() != found)`
`1135`	`1135`	`{`
`1136`	`1136`	`const auto& property = nc::find_property_descriptor(property_id, nc::details::parse_class_id(nmos::fields::nc::class_id(found->data)), get_control_protocol_class_descriptor);`
`@@ -1184,7 +1184,7 @@ namespace nmos`
`1184`	`1184`	`web::json::value get_property(const resources& resources, nc_oid oid, const utility::string_t& property_name, slog::base_gate& gate)`
`1185`	`1185`	`{`
`1186`	`1186`	`// get resource based on the oid`
`1187`		`- const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));`
	`1187`	`+ const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));`
`1188`	`1188`	`if (resources.end() != found)`
`1189`	`1189`	`{`
`1190`	`1190`	`// find the relevant nc_property_descriptor`
`@@ -1323,7 +1323,7 @@ namespace nmos`
`1323`	`1323`	`// domain specific statuses offering an Inactive option MUST transition immediately to the Healthy state.`
`1324`	`1324`	`// Furthermore, after activation, as long as the monitor isn't being deactivated, it MUST delay the reporting`
`1325`	`1325`	`// of non Healthy states for the duration specified by statusReportingDelay, and then transition to any other appropriate state.`
`1326`		`- const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));`
	`1326`	`+ const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));`
`1327`	`1327`	`if (resources.end() != found && nc::is_status_monitor(nc::details::parse_class_id(nmos::fields::nc::class_id(found->data))))`
`1328`	`1328`	`{`
`1329`	`1329`	`const auto& class_id = nc::details::parse_class_id(nmos::fields::nc::class_id(found->data));`
`@@ -1382,7 +1382,7 @@ namespace nmos`
`1382`	`1382`
`1383`	`1383`	`bool deactivate_monitor(resources& resources, nc_oid oid, get_control_protocol_class_descriptor_handler get_control_protocol_class_descriptor, slog::base_gate& gate)`
`1384`	`1384`	`{`
`1385`		`- const auto& found = find_resource(resources, utility::s2us(std::to_string(oid)));`
	`1385`	`+ const auto found = find_resource(resources, utility::s2us(std::to_string(oid)));`
`1386`	`1386`	`if (resources.end() != found && nc::is_status_monitor(nc::details::parse_class_id(nmos::fields::nc::class_id(found->data))))`
`1387`	`1387`	`{`
`1388`	`1388`	`const auto& class_id = nc::details::parse_class_id(nmos::fields::nc::class_id(found->data));`