Update few specs with missing tests

Author: chaimann

admin/lib/solidus_admin/testing_support/feature_helpers.rb

@@ -49,6 +49,12 @@ def checkbox(locator)
       def selected_option(select_locator)
         find(:select, select_locator).find(:option, selected: true)
       end
+
+      def clear_search
+        within('div[role="search"]') do
+          find('button[aria-label="Clear"]').click
+        end
+      end
     end
   end
 end

admin/spec/features/product_spec.rb

@@ -40,9 +40,12 @@
     visit "/admin/products/just-a-prod"
 
     fill_in "Name", with: "Just a product (updated)"
+    uncheck 'Promotable'
     within('header') { click_button "Save" }
 
     expect(page).to have_content("Just a product (updated)")
+    expect(checkbox("Promotable")).not_to be_checked
+
     fill_in "Name", with: ""
     within('header') { click_button "Save" }
 

admin/spec/features/refund_reasons_spec.rb

@@ -22,7 +22,7 @@
   end
 
   context "when creating a new refund reason" do
-    let(:query) { "?page=1&q%5Bname_or_description_cont%5D=Ret" }
+    let(:query) { "?page=1&q%5Bname_or_code_cont%5D=Ret" }
 
     before do
       visit "/admin/refund_reasons/#{query}"
@@ -44,10 +44,13 @@
     context "with valid data" do
       it "successfully creates a new refund reason, keeping page and q params" do
         fill_in "Name", with: "Return process"
+        uncheck "Active"
 
         click_on "Add Refund Reason"
 
         expect(page).to have_content("Refund reason was successfully created.")
+        click_on "Return process"
+        expect(checkbox("Active")).not_to be_checked
         expect(Spree::RefundReason.find_by(name: "Return process")).to be_present
         expect(page.current_url).to include(query)
       end
@@ -64,10 +67,10 @@
   end
 
   context "when editing an existing refund reason" do
-    let(:query) { "?page=1&q%5Bname_or_description_cont%5D=Ret" }
+    let(:query) { "?page=1&q%5Bname_or_code_cont%5D=Ret" }
 
     before do
-      Spree::RefundReason.create(name: "Return process")
+      Spree::RefundReason.create(name: "Return process", active: false)
       visit "/admin/refund_reasons#{query}"
       click_on "Return process"
       expect(page).to have_css("dialog")
@@ -86,13 +89,20 @@
 
     it "successfully updates the existing refund reason" do
       fill_in "Name", with: "Customer complaint"
-
+      check "Active"
       click_on "Update Refund Reason"
+
+      expect(page.current_url).to include(query)
       expect(page).to have_content("Refund reason was successfully updated.")
+      expect(page).to have_content("No Refund Reasons found") # search query still applied, filters out updated name
+      clear_search
+
       expect(page).to have_content("Customer complaint")
       expect(page).not_to have_content("Return process")
+
+      click_on "Customer complaint"
+      expect(checkbox("Active")).to be_checked
       expect(Spree::RefundReason.find_by(name: "Customer complaint")).to be_present
-      expect(page.current_url).to include(query)
     end
   end
 end

admin/spec/features/tax_categories_spec.rb

@@ -46,10 +46,13 @@
     context "with valid data" do
       it "successfully creates a new tax category, keeping page and q params" do
         fill_in "Name", with: "Clothing"
+        check "Default"
 
         click_on "Add Tax Category"
 
         expect(page).to have_content("Tax category was successfully created.")
+        click_on "Clothing"
+        expect(checkbox("Default")).to be_checked
         expect(Spree::TaxCategory.find_by(name: "Clothing")).to be_present
         expect(page.current_url).to include(query)
       end
@@ -64,4 +67,39 @@
       end
     end
   end
+
+  context "when editing an existing tax category" do
+    let(:query) { "?page=1&q%5Bname_or_description_cont%5D=Cloth" }
+
+    before do
+      Spree::TaxCategory.create(name: "Clothing", is_default: true)
+      visit "/admin/tax_categories#{query}"
+      click_on "Clothing"
+      expect(page).to have_css("dialog")
+      expect(page).to have_content("Edit Tax Category")
+      expect(page).to be_axe_clean
+    end
+
+    it "closing the modal keeps query params" do
+      within("dialog") { click_on "Cancel" }
+      expect(page).not_to have_selector("dialog")
+      expect(page.current_url).to include(query)
+    end
+
+    it "successfully updates the existing tax category" do
+      fill_in "Name", with: "Other"
+      uncheck "Default"
+      click_on "Update Tax Category"
+
+      expect(page.current_url).to include(query)
+      expect(page).to have_content("Tax category was successfully updated.")
+      expect(page).to have_content("No Tax Categories found") # search query still applied, filters out updated name
+      clear_search
+
+      expect(page).to have_content("Other")
+      expect(page).not_to have_content("Clothing")
+      click_on "Other"
+      expect(checkbox("Default")).not_to be_checked
+    end
+  end
 end