Skip to content

Commit 8f9d2b2

Browse files
chaimanntvdeyen
authored andcommitted
Remove turbo frame tags from new and edit pages
We don't have to use turbo_frames on these pages since we are not loading content into it but always do a page visit to /new and /edit routes, and when server responds with 422 and templates with validation errors we can just place relevant "id" on the topmost element of the page so its content will be replaced with turbo stream.
1 parent 80b4f2c commit 8f9d2b2

2 files changed

Lines changed: 21 additions & 25 deletions

File tree

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
1-
<%= turbo_frame_tag :resource_form, target: "_top" do %>
2-
<%= page do %>
3-
<%= page_header do %>
4-
<%= page_header_back(back_url) %>
5-
<%= page_header_title(t('.title')) %>
6-
<%= page_header_actions do %>
7-
<%= render component("ui/button").discard(path: back_url) %>
8-
<%= render component("ui/button").save(form: form_id) %>
1+
<%= page id: :resource_form do %>
2+
<%= page_header do %>
3+
<%= page_header_back(back_url) %>
4+
<%= page_header_title(t('.title')) %>
5+
<%= page_header_actions do %>
6+
<%= render component("ui/button").discard(path: back_url) %>
7+
<%= render component("ui/button").save(form: form_id) %>
98
<% end %>
109
<% end %>
1110

12-
<%= render component("stock_locations/form").new(stock_location: @stock_location, url: form_url, id: form_id) %>
11+
<%= render component("stock_locations/form").new(stock_location: @stock_location, url: form_url, id: form_id) %>
1312

14-
<%= page_footer do %>
15-
<%= render component("ui/button").save(form: form_id) %>
16-
<% end %>
13+
<%= page_footer do %>
14+
<%= render component("ui/button").save(form: form_id) %>
1715
<% end %>
1816
<% end %>
Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
1-
<%= turbo_frame_tag :resource_form, target: "_top" do %>
2-
<%= page do %>
3-
<%= page_header do %>
4-
<%= page_header_back(back_url) %>
5-
<%= page_header_title(t('.title')) %>
6-
<%= page_header_actions do %>
7-
<%= render component("ui/button").discard(path: back_url) %>
8-
<%= render component("ui/button").save(form: form_id) %>
9-
<% end %>
1+
<%= page id: :resource_form do %>
2+
<%= page_header do %>
3+
<%= page_header_back(back_url) %>
4+
<%= page_header_title(t('.title')) %>
5+
<%= page_header_actions do %>
6+
<%= render component("ui/button").discard(path: back_url) %>
7+
<%= render component("ui/button").save(form: form_id) %>
108
<% end %>
9+
<% end %>
1110

12-
<%= render component("stock_locations/form").new(stock_location: @stock_location, url: form_url, id: form_id) %>
11+
<%= render component("stock_locations/form").new(stock_location: @stock_location, url: form_url, id: form_id) %>
1312

14-
<%= page_footer do %>
15-
<%= render component("ui/button").save(form: form_id) %>
16-
<% end %>
13+
<%= page_footer do %>
14+
<%= render component("ui/button").save(form: form_id) %>
1715
<% end %>
1816
<% end %>

0 commit comments

Comments
 (0)