Rename "fieldset_name" to "form_field_name"

As per this discussion #6191 (comment).

Author: chaimann

admin/app/components/solidus_admin/orders/show/address/component.html.erb

@@ -28,7 +28,7 @@
 
           <div class="w-full flex gap-4">
             <%= turbo_frame_tag address_frame_id do %>
-              <%= render component('ui/forms/address').new(addressable: @address, fieldset_name: "order[#{@type}_address_attributes]") %>
+              <%= render component('ui/forms/address').new(addressable: @address, form_field_name: "order[#{@type}_address_attributes]") %>
             <% end %>
           </div>
 

admin/app/components/solidus_admin/ui/forms/address/component.html.erb

@@ -3,16 +3,16 @@
   <%= :disabled if @disabled %>
 >
   <div class="<%= stimulus_id %>--address-form flex flex-wrap gap-4 pb-4">
-    <%= render component("ui/forms/field").text_field(@fieldset_name, :name, object: @addressable) if @include_name_field %>
-    <%= render component("ui/forms/field").text_field(@fieldset_name, :address1, object: @addressable) %>
-    <%= render component("ui/forms/field").text_field(@fieldset_name, :address2, object: @addressable) %>
+    <%= render component("ui/forms/field").text_field(@form_field_name, :name, object: @addressable) if @include_name_field %>
+    <%= render component("ui/forms/field").text_field(@form_field_name, :address1, object: @addressable) %>
+    <%= render component("ui/forms/field").text_field(@form_field_name, :address2, object: @addressable) %>
     <div class="flex gap-4 w-full">
-      <%= render component("ui/forms/field").text_field(@fieldset_name, :city, object: @addressable) %>
-      <%= render component("ui/forms/field").text_field(@fieldset_name, :zipcode, object: @addressable) %>
+      <%= render component("ui/forms/field").text_field(@form_field_name, :city, object: @addressable) %>
+      <%= render component("ui/forms/field").text_field(@form_field_name, :zipcode, object: @addressable) %>
     </div>
 
     <%= render component("ui/forms/field").select(
-      @fieldset_name,
+      @form_field_name,
       :country_id,
       Spree::Country.all.map { |c| [c.name, c.id] },
       object: @addressable,
@@ -26,21 +26,21 @@
       class: (@addressable.country&.states&.empty? ? "flex flex-col gap-2 w-full" : "hidden flex flex-col gap-2 w-full")
         ) do %>
       <%= render component("ui/forms/field").text_field(
-        @fieldset_name,
+        @form_field_name,
         :state_name,
         object: @addressable,
         value: @addressable.try(:state_name),
         "data-#{stimulus_id}-target": "stateName"
       ) %>
     <% end %>
-    <input autocomplete="off" type="hidden" name=<%= "#{@fieldset_name}[state_id]" %>>
+    <input autocomplete="off" type="hidden" name=<%= "#{@form_field_name}[state_id]" %>>
 
     <%= content_tag(:div,
       data: { "#{stimulus_id}-target": "stateWrapper" },
       class: (@addressable.country&.states&.empty? ? "hidden flex flex-col gap-2 w-full" : "flex flex-col gap-2 w-full")
         ) do %>
       <%= render component("ui/forms/field").select(
-        @fieldset_name,
+        @form_field_name,
         :state_id,
         state_options,
         object: @addressable,
@@ -49,6 +49,6 @@
       ) %>
     <% end %>
 
-    <%= render component("ui/forms/field").text_field(@fieldset_name, :phone,  object: @addressable) %>
+    <%= render component("ui/forms/field").text_field(@form_field_name, :phone,  object: @addressable) %>
   </div>
 </fieldset>

admin/app/components/solidus_admin/ui/forms/address/component.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 class SolidusAdmin::UI::Forms::Address::Component < SolidusAdmin::BaseComponent
-  def initialize(addressable:, fieldset_name:, disabled: false, include_name_field: true)
+  def initialize(addressable:, form_field_name:, disabled: false, include_name_field: true)
     @addressable = addressable
-    @fieldset_name = fieldset_name
+    @form_field_name = form_field_name
     @disabled = disabled
     @include_name_field = include_name_field
   end

admin/app/components/solidus_admin/users/addresses/component.html.erb

@@ -19,7 +19,7 @@
       <%= render component('ui/panel').new(title: t(".billing_address")) do %>
         <%= form_for @user, url: solidus_admin.update_addresses_user_path(@user), method: :put, html: { id: "#{form_id}_billing", autocomplete: "off", class: "bill_address" } do |f| %>
 
-          <%= render component('ui/forms/address').new(addressable: @bill_address, fieldset_name: "user[bill_address_attributes]") %>
+          <%= render component('ui/forms/address').new(addressable: @bill_address, form_field_name: "user[bill_address_attributes]") %>
           <div class="py-1.5 text-center">
             <%= render component("ui/button").new(tag: :button, text: t(".update"), form: "#{form_id}_billing") %>
             <%= render component("ui/button").new(tag: :a, text: t(".cancel"), href: solidus_admin.addresses_user_path(@user), scheme: :secondary) %>
@@ -30,7 +30,7 @@
       <%= render component('ui/panel').new(title: t(".shipping_address")) do %>
         <%= form_for @user, url: solidus_admin.update_addresses_user_path(@user), method: :put, html: { id: "#{form_id}_shipping", autocomplete: "off", class: "ship_address"  } do |f| %>
 
-          <%= render component('ui/forms/address').new(addressable: @ship_address, fieldset_name: "user[ship_address_attributes]") %>
+          <%= render component('ui/forms/address').new(addressable: @ship_address, form_field_name: "user[ship_address_attributes]") %>
           <div class="py-1.5 text-center">
             <%= render component("ui/button").new(tag: :button, text: t(".update"), form: "#{form_id}_shipping") %>
             <%= render component("ui/button").new(tag: :a, text: t(".cancel"), href: solidus_admin.addresses_user_path(@user), scheme: :secondary) %>

admin/spec/components/previews/solidus_admin/ui/forms/address/component_preview.rb

@@ -11,7 +11,7 @@ def overview
   # @param disabled toggle
   def playground(disabled: false)
     render component("ui/forms/address").new(
-      fieldset_name: "",
+      form_field_name: "",
       addressable: fake_address,
       disabled:
     )

admin/spec/components/previews/solidus_admin/ui/forms/address/component_preview/overview.html.erb

@@ -1 +1 @@
-<%= render current_component.new(fieldset_name: "", addressable:) %>
+<%= render current_component.new(form_field_name: "", addressable:) %>

admin/spec/components/solidus_admin/ui/forms/address/component_spec.rb

@@ -10,7 +10,7 @@
   context "with include_name_field: false" do
     it "does not render name field" do
       component = described_class.new(
-        fieldset_name: "",
+        form_field_name: "",
         addressable: Spree::Address.new(country: Spree::Country.find_or_initialize_by(iso: "US")),
         include_name_field: false
       )