test(helpdesk): refactor fixtures to replace chat_id with created_chat

Author: jentyk

e2e_config.test.json

@@ -56,8 +56,6 @@
   "commerce.product.listing.id": "LST-5489-0806",
   "commerce.product.template.id": "TPL-1767-7355-0002",
   "commerce.user.id": "USR-4303-2348",
-  "helpdesk.chat.id": "CHT-5064-0262-3671",
-  "helpdesk.channel.id": "CHL-5064-0262-3671",
   "commerce.subscription.agreement.id": "AGR-2473-3299-1721",
   "commerce.subscription.id": "SUB-3678-1831-2188",
   "commerce.subscription.product.item.id": "ITM-1767-7355-0001",

tests/e2e/helpdesk/channels/conftest.py

@@ -6,11 +6,6 @@
 )
 
 
-@pytest.fixture(scope="session")
-def channel_id(e2e_config):
-    return e2e_config["helpdesk.channel.id"]  # FIXME: seed data
-
-
 @pytest.fixture(scope="session")
 def invalid_channel_id():
     return "CHN-0000-0000-0000"

tests/e2e/helpdesk/chats/conftest.py

@@ -6,11 +6,6 @@
 )
 
 
-@pytest.fixture(scope="session")
-def chat_id(e2e_config):
-    return e2e_config["helpdesk.chat.id"]
-
-
 @pytest.fixture(scope="session")
 def invalid_chat_id():
     return "CHT-0000-0000-0000"

tests/e2e/helpdesk/chats/participants/conftest.py

@@ -7,13 +7,13 @@
 
 
 @pytest.fixture
-def chat_participants_service(mpt_ops, chat_id):
-    return mpt_ops.helpdesk.chats.participants(chat_id)
+def chat_participants_service(mpt_ops, created_chat):
+    return mpt_ops.helpdesk.chats.participants(created_chat.id)
 
 
 @pytest.fixture
-def async_chat_participants_service(async_mpt_ops, chat_id):
-    return async_mpt_ops.helpdesk.chats.participants(chat_id)
+def async_chat_participants_service(async_mpt_ops, created_chat):
+    return async_mpt_ops.helpdesk.chats.participants(created_chat.id)
 
 
 @pytest.fixture

tests/e2e/helpdesk/chats/test_async_chats.py

@@ -8,12 +8,12 @@
 pytestmark = [pytest.mark.flaky]
 
 
-async def test_get_chat(async_mpt_ops, chat_id):
+async def test_get_chat(async_mpt_ops, created_chat):
     service = async_mpt_ops.helpdesk.chats
 
-    result = await service.get(chat_id)
+    result = await service.get(created_chat.id)
 
-    assert result.id == chat_id
+    assert result.id == created_chat.id
 
 
 async def test_list_chats(async_mpt_ops):
@@ -25,13 +25,13 @@ async def test_list_chats(async_mpt_ops):
     assert all(isinstance(chat, Chat) for chat in result)
 
 
-async def test_update_chat(async_mpt_ops, chat_id, short_uuid):
+async def test_update_chat(async_mpt_ops, created_chat, short_uuid):
     service = async_mpt_ops.helpdesk.chats
     new_description = f"e2e update {short_uuid}"
 
-    result = await service.update(chat_id, {"description": new_description})
+    result = await service.update(created_chat.id, {"description": new_description})
 
-    assert result.id == chat_id
+    assert result.id == created_chat.id
     assert result.to_dict().get("description") == new_description
 
 

tests/e2e/helpdesk/chats/test_sync_chats.py

@@ -8,12 +8,12 @@
 pytestmark = [pytest.mark.flaky]
 
 
-def test_get_chat(mpt_ops, chat_id):
+def test_get_chat(mpt_ops, created_chat):
     service = mpt_ops.helpdesk.chats
 
-    result = service.get(chat_id)
+    result = service.get(created_chat.id)
 
-    assert result.id == chat_id
+    assert result.id == created_chat.id
 
 
 def test_list_chats(mpt_ops):
@@ -25,13 +25,13 @@ def test_list_chats(mpt_ops):
     assert all(isinstance(chat, Chat) for chat in result)
 
 
-def test_update_chat(mpt_ops, chat_id, short_uuid):
+def test_update_chat(mpt_ops, created_chat, short_uuid):
     service = mpt_ops.helpdesk.chats
     new_description = f"e2e update {short_uuid}"
 
-    result = service.update(chat_id, {"description": new_description})
+    result = service.update(created_chat.id, {"description": new_description})
 
-    assert result.id == chat_id
+    assert result.id == created_chat.id
     assert result.to_dict().get("description") == new_description