MPT-18701 Improve base model tests (improvements)

Author: albertsola

tests/unit/models/test_model.py

@@ -181,9 +181,11 @@ def test_append():
     agreement.parameters.ordering.append(new_param)  # act
 
     assert agreement.id == "AGR-123"
-    assert agreement.parameters.ordering[0].external_id == "contact"
-    assert agreement.parameters.ordering[1].external_id == "address"
-    assert agreement.parameters.ordering[2].external_id == "email"
+    assert [agr_param.external_id for agr_param in agreement.parameters.ordering] == [
+        "contact",
+        "address",
+        "email",
+    ]
     agreement_data["parameters"]["ordering"].append(new_param)
     assert agreement.to_dict() == agreement_data
 
@@ -202,8 +204,10 @@ def test_overwrite_list():
     agreement.parameters.ordering = ordering_parameters  # act
 
     assert agreement.id == "AGR-123"
-    assert agreement.parameters.ordering[0].external_id == "contact"
-    assert agreement.parameters.ordering[1].external_id == "address"
+    assert [agr_param.external_id for agr_param in agreement.parameters.ordering] == [
+        "contact",
+        "address",
+    ]
     assert agreement.to_dict() == agreement_data
 
 
@@ -222,8 +226,10 @@ def test_advanced_mapping():
     agreement.parameters.ordering = ordering_parameters  # act
 
     assert isinstance(agreement.contact, ContactDummy)
-    assert agreement.parameters.ordering[0].external_id == "contact"
-    assert agreement.parameters.ordering[1].external_id == "address"
+    assert [agr_param.external_id for agr_param in agreement.parameters.ordering] == [
+        "contact",
+        "address",
+    ]
     assert agreement.to_dict() == agreement_data
 
 
@@ -246,10 +252,7 @@ def test_model_list_insert():
 
     ml.insert(1, {"id": "2"})  # act
 
-    assert len(ml) == 3
-    assert ml[0].id == "1"
-    assert ml[1].id == "2"
-    assert ml[2].id == "3"
+    assert [ml_item.id for ml_item in ml] == ["1", "2", "3"]
 
 
 def test_model_list_process_item_nested_list():
@@ -264,9 +267,7 @@ def test_model_list_process_item_nested_list():
 def test_model_list_process_item_scalar():
     ml = ModelList(["a", "b", "c"])  # act
 
-    assert ml[0] == "a"
-    assert ml[1] == "b"
-    assert ml[2] == "c"
+    assert ml == ["a", "b", "c"]
 
 
 def test_base_model_getattr_from_dict():
@@ -298,10 +299,8 @@ def test_to_dict_excludes_private_attrs():
 def test_process_value_typed_list():
     container = TypedListContainerDummy(entries=[{"name": "one"}, {"name": "two"}])  # act
 
-    assert isinstance(container.entries[0], TypedListItemDummy)
-    assert container.entries[0].name == "one"
-    assert isinstance(container.entries[1], TypedListItemDummy)
-    assert container.entries[1].name == "two"
+    assert all(isinstance(entry, TypedListItemDummy) for entry in container.entries)
+    assert [entry.name for entry in container.entries] == ["one", "two"]
 
 
 def test_process_value_existing_base_model():
@@ -326,5 +325,4 @@ def test_process_value_scalar_list_elements():
     container = ScalarListContainerDummy(tags=["a", "b", "c"])  # act
 
     assert isinstance(container.tags, ModelList)
-    assert container.tags[0] == "a"
-    assert container.tags[1] == "b"
+    assert list(container.tags) == ["a", "b", "c"]