test(helpdesk): add TODOs and FIXMEs for improving e2e assertions

jentyk · jentyk · commit 0ccaf4c9a78e · 2026-03-26T10:39:19.000Z
diff --git a/e2e_config.test.json b/e2e_config.test.json
@@ -57,6 +57,7 @@
   "commerce.product.template.id": "TPL-1767-7355-0002",
   "commerce.user.id": "USR-4303-2348",
   "helpdesk.chat.id": "CHT-5064-0262-3671",
+  "helpdesk.channel.id": "CHL-5064-0262-3671",
   "commerce.subscription.agreement.id": "AGR-2473-3299-1721",
   "commerce.subscription.id": "SUB-3678-1831-2188",
   "commerce.subscription.product.item.id": "ITM-1767-7355-0001",
diff --git a/tests/e2e/helpdesk/cases/test_async_cases.py b/tests/e2e/helpdesk/cases/test_async_cases.py
@@ -12,13 +12,12 @@ async def test_get_case(async_mpt_ops, async_created_case):
     assert result.id == async_created_case.id
 
 
-@pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 async def test_list_cases(async_mpt_ops):
     limit = 1
 
     result = await async_mpt_ops.helpdesk.cases.fetch_page(limit=limit)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
@@ -65,7 +64,6 @@ async def test_complete_case(async_mpt_ops, async_created_case):
     assert result is not None
 
 
-@pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 async def test_not_found(async_mpt_ops, invalid_case_id):
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError):  # FIXME: should specifically check for not found
         await async_mpt_ops.helpdesk.cases.get(invalid_case_id)
diff --git a/tests/e2e/helpdesk/cases/test_sync_cases.py b/tests/e2e/helpdesk/cases/test_sync_cases.py
@@ -12,13 +12,12 @@ def test_get_case(mpt_ops, created_case):
     assert result.id == created_case.id
 
 
-@pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 def test_list_cases(mpt_ops):
     limit = 1
 
     result = mpt_ops.helpdesk.cases.fetch_page(limit=limit)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
@@ -65,7 +64,6 @@ def test_complete_case(mpt_ops, created_case):
     assert result is not None
 
 
-@pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 def test_not_found(mpt_ops, invalid_case_id):
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError):  # FIXME: should specifically check for not found
         mpt_ops.helpdesk.cases.get(invalid_case_id)
diff --git a/tests/e2e/helpdesk/channels/conftest.py b/tests/e2e/helpdesk/channels/conftest.py
@@ -8,7 +8,7 @@
 
 @pytest.fixture
 def channel_id(e2e_config):
-    return e2e_config["helpdesk.channel.id"]
+    return e2e_config["helpdesk.channel.id"]  # FIXME: seed data
 
 
 @pytest.fixture
diff --git a/tests/e2e/helpdesk/channels/messages/__init__.py b/tests/e2e/helpdesk/channels/messages/__init__.py
@@ -1 +0,0 @@
-
diff --git a/tests/e2e/helpdesk/channels/messages/test_async_messages.py b/tests/e2e/helpdesk/channels/messages/test_async_messages.py
@@ -9,10 +9,12 @@
 async def test_list_channel_messages(async_channel_messages_service):
     result = await async_channel_messages_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 async def test_list_channel_messages_not_found(async_mpt_ops, invalid_channel_id):
-    with pytest.raises(MPTAPIError, match=r"404 Not Found"):
+    with pytest.raises(
+        MPTAPIError, match=r"404 Not Found"
+    ):  # FIXME: should specifically check for not found
         await async_mpt_ops.helpdesk.channels.messages(invalid_channel_id).fetch_page(limit=1)
diff --git a/tests/e2e/helpdesk/channels/messages/test_sync_messages.py b/tests/e2e/helpdesk/channels/messages/test_sync_messages.py
@@ -9,10 +9,12 @@
 def test_list_channel_messages(channel_messages_service):
     result = channel_messages_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 def test_list_channel_messages_not_found(mpt_ops, invalid_channel_id):
-    with pytest.raises(MPTAPIError, match=r"404 Not Found"):
+    with pytest.raises(
+        MPTAPIError, match=r"404 Not Found"
+    ):  # FIXME: should specifically check for not found
         mpt_ops.helpdesk.channels.messages(invalid_channel_id).fetch_page(limit=1)
diff --git a/tests/e2e/helpdesk/channels/test_async_channels.py b/tests/e2e/helpdesk/channels/test_async_channels.py
@@ -20,7 +20,7 @@ async def test_list_channels(async_mpt_ops):
 
     result = await service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
@@ -51,5 +51,5 @@ async def test_delete_channel(async_mpt_ops, async_created_channel):
 async def test_not_found(async_mpt_ops, invalid_channel_id):
     service = async_mpt_ops.helpdesk.channels
 
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError):  # FIXME: should specifically check for not found
         await service.get(invalid_channel_id)
diff --git a/tests/e2e/helpdesk/channels/test_sync_channels.py b/tests/e2e/helpdesk/channels/test_sync_channels.py
@@ -20,7 +20,7 @@ def test_list_channels(mpt_ops):
 
     result = service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
@@ -51,5 +51,5 @@ def test_delete_channel(mpt_ops, created_channel):
 def test_not_found(mpt_ops, invalid_channel_id):
     service = mpt_ops.helpdesk.channels
 
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError):  # FIXME: should specifically check for not found
         service.get(invalid_channel_id)
diff --git a/tests/e2e/helpdesk/chats/answers/parameters/test_async_parameters.py b/tests/e2e/helpdesk/chats/answers/parameters/test_async_parameters.py
@@ -24,5 +24,5 @@ async def test_iterate_chat_answer_parameters(async_chat_answer_parameters_servi
 async def test_not_found(async_mpt_ops, chat_id):
     service = async_mpt_ops.helpdesk.chats.answers(chat_id).parameters("ANS-0000-0000")
 
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError):  # FIXME: should specifically check for not found
         await service.fetch_page(limit=20)
diff --git a/tests/e2e/helpdesk/chats/answers/parameters/test_sync_parameters.py b/tests/e2e/helpdesk/chats/answers/parameters/test_sync_parameters.py
@@ -25,5 +25,5 @@ def test_iterate_chat_answer_parameters(chat_answer_parameters_service):
 def test_not_found(mpt_ops, chat_id):
     service = mpt_ops.helpdesk.chats.answers(chat_id).parameters("ANS-0000-0000")
 
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError):  # FIXME: should specifically check for not found
         service.fetch_page(limit=20)
diff --git a/tests/e2e/helpdesk/chats/answers/test_async_answers.py b/tests/e2e/helpdesk/chats/answers/test_async_answers.py
@@ -2,10 +2,7 @@
 
 from mpt_api_client.exceptions import MPTAPIError
 
-pytestmark = [
-    pytest.mark.flaky,
-    pytest.mark.skip(reason="Unskip after MPT-19124 completed"),
-]
+pytestmark = [pytest.mark.flaky]
 
 
 async def test_get_chat_answer(async_chat_answers_service, async_created_chat_answer):
@@ -17,7 +14,7 @@ async def test_get_chat_answer(async_chat_answers_service, async_created_chat_an
 async def test_list_chat_answers(async_chat_answers_service):
     result = await async_chat_answers_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 def test_create_chat_answer(async_created_chat_answer):
@@ -71,5 +68,5 @@ async def test_delete_chat_answer(async_chat_answers_service, async_created_chat
 
 
 async def test_not_found(async_chat_answers_service, invalid_chat_answer_id):
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError):  # FIXME: should specifically check for not found
         await async_chat_answers_service.get(invalid_chat_answer_id)
diff --git a/tests/e2e/helpdesk/chats/answers/test_sync_answers.py b/tests/e2e/helpdesk/chats/answers/test_sync_answers.py
@@ -2,10 +2,7 @@
 
 from mpt_api_client.exceptions import MPTAPIError
 
-pytestmark = [
-    pytest.mark.flaky,
-    pytest.mark.skip(reason="Unskip after MPT-19124 completed"),
-]
+pytestmark = [pytest.mark.flaky]
 
 
 def test_get_chat_answer(chat_answers_service, created_chat_answer):
@@ -17,7 +14,7 @@ def test_get_chat_answer(chat_answers_service, created_chat_answer):
 def test_list_chat_answers(chat_answers_service):
     result = chat_answers_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 def test_create_chat_answer(created_chat_answer):
@@ -66,5 +63,5 @@ def test_delete_chat_answer(chat_answers_service, created_chat_answer):
 
 
 def test_not_found(chat_answers_service, invalid_chat_answer_id):
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError):  # FIXME: should specifically check for not found
         chat_answers_service.get(invalid_chat_answer_id)
diff --git a/tests/e2e/helpdesk/chats/attachment/test_async_attachment.py b/tests/e2e/helpdesk/chats/attachment/test_async_attachment.py
@@ -9,7 +9,7 @@
 async def test_list_chat_attachments(async_chat_attachments_service, async_created_chat_attachment):
     result = await async_chat_attachments_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")  # noqa: AAA01
@@ -82,5 +82,7 @@ async def test_update_chat_attachment_not_found(
 async def test_delete_chat_attachment_not_found(
     async_chat_attachments_service, invalid_chat_attachment_id
 ):
-    with pytest.raises(MPTAPIError, match=r"404 Not Found"):
+    with pytest.raises(
+        MPTAPIError, match=r"404 Not Found"
+    ):  # FIXME: should specifically check for not found
         await async_chat_attachments_service.delete(invalid_chat_attachment_id)
diff --git a/tests/e2e/helpdesk/chats/attachment/test_sync_attachment.py b/tests/e2e/helpdesk/chats/attachment/test_sync_attachment.py
@@ -9,7 +9,7 @@
 def test_list_chat_attachments(chat_attachments_service, created_chat_attachment):
     result = chat_attachments_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")  # noqa: AAA01
@@ -69,5 +69,7 @@ def test_update_chat_attachment_not_found(chat_attachments_service, invalid_chat
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 def test_delete_chat_attachment_not_found(chat_attachments_service, invalid_chat_attachment_id):
-    with pytest.raises(MPTAPIError, match=r"404 Not Found"):
+    with pytest.raises(
+        MPTAPIError, match=r"404 Not Found"
+    ):  # FIXME: should specifically check for not found
         chat_attachments_service.delete(invalid_chat_attachment_id)
diff --git a/tests/e2e/helpdesk/chats/links/test_async_links.py b/tests/e2e/helpdesk/chats/links/test_async_links.py
@@ -9,7 +9,7 @@
 async def test_list_chat_links(async_chat_links_service):
     result = await async_chat_links_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")  # noqa: AAA01
@@ -49,5 +49,7 @@ async def test_update_chat_link_not_found(async_chat_links_service, invalid_chat
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 async def test_delete_chat_link_not_found(async_chat_links_service, invalid_chat_link_id):
-    with pytest.raises(MPTAPIError, match=r"404 Not Found"):
+    with pytest.raises(
+        MPTAPIError, match=r"404 Not Found"
+    ):  # FIXME: should specifically check for not found
         await async_chat_links_service.delete(invalid_chat_link_id)
diff --git a/tests/e2e/helpdesk/chats/links/test_sync_links.py b/tests/e2e/helpdesk/chats/links/test_sync_links.py
@@ -9,7 +9,7 @@
 def test_list_chat_links(chat_links_service):
     result = chat_links_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")  # noqa: AAA01
@@ -44,4 +44,6 @@ def test_update_chat_link_not_found(chat_links_service, invalid_chat_link_id):
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 def test_delete_chat_link_not_found(chat_links_service, invalid_chat_link_id):
     with pytest.raises(MPTAPIError, match=r"404 Not Found"):
-        chat_links_service.delete(invalid_chat_link_id)
+        chat_links_service.delete(
+            invalid_chat_link_id
+        )  # FIXME: should specifically check for not found
diff --git a/tests/e2e/helpdesk/chats/messages/test_async_messages.py b/tests/e2e/helpdesk/chats/messages/test_async_messages.py
@@ -9,7 +9,7 @@
 async def test_list_chat_messages(async_chat_messages_service):
     result = await async_chat_messages_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")  # noqa: AAA01
@@ -48,5 +48,7 @@ async def test_update_chat_message_not_found(async_chat_messages_service, invali
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 async def test_delete_chat_message_not_found(async_chat_messages_service, invalid_chat_message_id):
-    with pytest.raises(MPTAPIError, match=r"404 Not Found"):
+    with pytest.raises(
+        MPTAPIError, match=r"404 Not Found"
+    ):  # FIXME: should specifically check for not found
         await async_chat_messages_service.delete(invalid_chat_message_id)
diff --git a/tests/e2e/helpdesk/chats/messages/test_sync_messages.py b/tests/e2e/helpdesk/chats/messages/test_sync_messages.py
@@ -9,7 +9,7 @@
 def test_list_chat_messages(chat_messages_service):
     result = chat_messages_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")  # noqa: AAA01
@@ -40,5 +40,7 @@ def test_update_chat_message_not_found(chat_messages_service, invalid_chat_messa
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 def test_delete_chat_message_not_found(chat_messages_service, invalid_chat_message_id):
-    with pytest.raises(MPTAPIError, match=r"404 Not Found"):
+    with pytest.raises(
+        MPTAPIError, match=r"404 Not Found"
+    ):  # FIXME: should specifically check for not found
         chat_messages_service.delete(invalid_chat_message_id)
diff --git a/tests/e2e/helpdesk/chats/participants/test_async_participants.py b/tests/e2e/helpdesk/chats/participants/test_async_participants.py
@@ -9,7 +9,7 @@
 async def test_list_chat_participants(async_chat_participants_service):
     result = await async_chat_participants_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")  # noqa: AAA01
@@ -53,5 +53,7 @@ async def test_update_chat_participant_not_found(
 async def test_delete_chat_participant_not_found(
     async_chat_participants_service, invalid_chat_participant_id
 ):
-    with pytest.raises(MPTAPIError, match=r"404 Not Found"):
+    with pytest.raises(
+        MPTAPIError, match=r"404 Not Found"
+    ):  # FIXME: should specifically check for not found
         await async_chat_participants_service.delete(invalid_chat_participant_id)
diff --git a/tests/e2e/helpdesk/chats/participants/test_sync_participants.py b/tests/e2e/helpdesk/chats/participants/test_sync_participants.py
@@ -9,7 +9,7 @@
 def test_list_chat_participants(chat_participants_service):
     result = chat_participants_service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")  # noqa: AAA01
@@ -39,5 +39,7 @@ def test_update_chat_participant_not_found(chat_participants_service, invalid_ch
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
 def test_delete_chat_participant_not_found(chat_participants_service, invalid_chat_participant_id):
-    with pytest.raises(MPTAPIError, match=r"404 Not Found"):
+    with pytest.raises(
+        MPTAPIError, match=r"404 Not Found"
+    ):  # FIXME: should specifically check for not found
         chat_participants_service.delete(invalid_chat_participant_id)
diff --git a/tests/e2e/helpdesk/chats/test_async_chats.py b/tests/e2e/helpdesk/chats/test_async_chats.py
@@ -18,7 +18,7 @@ async def test_list_chats(async_mpt_ops):
 
     result = await service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 async def test_update_chat(async_mpt_ops, chat_id, short_uuid):
@@ -34,5 +34,5 @@ async def test_update_chat(async_mpt_ops, chat_id, short_uuid):
 async def test_not_found(async_mpt_ops, invalid_chat_id):
     service = async_mpt_ops.helpdesk.chats
 
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError):  # FIXME: should specifically check for not found
         await service.get(invalid_chat_id)
diff --git a/tests/e2e/helpdesk/chats/test_sync_chats.py b/tests/e2e/helpdesk/chats/test_sync_chats.py
@@ -18,7 +18,7 @@ def test_list_chats(mpt_ops):
 
     result = service.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 def test_update_chat(mpt_ops, chat_id, short_uuid):
@@ -34,5 +34,5 @@ def test_update_chat(mpt_ops, chat_id, short_uuid):
 def test_not_found(mpt_ops, invalid_chat_id):
     service = mpt_ops.helpdesk.chats
 
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError):  # FIXME: should specifically check for not found
         service.get(invalid_chat_id)
diff --git a/tests/e2e/helpdesk/forms/test_async_forms.py b/tests/e2e/helpdesk/forms/test_async_forms.py
@@ -16,7 +16,7 @@ async def test_get_form(async_mpt_ops, async_created_form):
 async def test_list_forms(async_mpt_ops):
     result = await async_mpt_ops.helpdesk.forms.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
diff --git a/tests/e2e/helpdesk/forms/test_sync_forms.py b/tests/e2e/helpdesk/forms/test_sync_forms.py
@@ -16,7 +16,7 @@ def test_get_form(mpt_ops, created_form):
 def test_list_forms(mpt_ops):
     result = mpt_ops.helpdesk.forms.fetch_page(limit=1)
 
-    assert len(result) > 0
+    assert len(result) > 0  # TODO: do more specific check
 
 
 @pytest.mark.skip(reason="Unskip after MPT-19124 completed")
diff --git a/tests/e2e/helpdesk/parameter_groups/test_async_parameter_groups.py b/tests/e2e/helpdesk/parameter_groups/test_async_parameter_groups.py
diff --git a/tests/e2e/helpdesk/parameter_groups/test_sync_parameter_groups.py b/tests/e2e/helpdesk/parameter_groups/test_sync_parameter_groups.py
diff --git a/tests/e2e/helpdesk/parameters/test_async_parameters.py b/tests/e2e/helpdesk/parameters/test_async_parameters.py
diff --git a/tests/e2e/helpdesk/parameters/test_sync_parameters.py b/tests/e2e/helpdesk/parameters/test_sync_parameters.py
diff --git a/tests/e2e/helpdesk/queues/test_async_queues.py b/tests/e2e/helpdesk/queues/test_async_queues.py
diff --git a/tests/e2e/helpdesk/queues/test_sync_queues.py b/tests/e2e/helpdesk/queues/test_sync_queues.py
