Added emplogin docs, added verify option to config

Author: allmightyspiff

SoftLayer/API.py

@@ -153,7 +153,7 @@ def employee_client(username=None,
                     proxy=None,
                     user_agent=None,
                     transport=None,
-                    verify=False):
+                    verify=True):
     """Creates an INTERNAL SoftLayer API client using your environment.
 
     Settings are loaded via keyword arguments, environemtal variables and config file.
@@ -178,10 +178,11 @@ def employee_client(username=None,
                                           endpoint_url=endpoint_url,
                                           timeout=timeout,
                                           proxy=proxy,
-                                          verify=verify,
+                                          verify=None,
                                           config_file=config_file)
 
     url = settings.get('endpoint_url')
+    verify = settings.get('verify', True)
 
     if 'internal' not in url:
         raise exceptions.SoftLayerError(f"{url} does not look like an Internal Employee url.")

SoftLayer/CLI/login.py

@@ -4,6 +4,7 @@
 
 import click
 
+from SoftLayer.API import employee_client
 from SoftLayer.CLI.command import SLCommand as SLCommand
 from SoftLayer.CLI import environment
 from SoftLayer import config
@@ -30,7 +31,7 @@ def cli(env):
     username = settings.get('username') or os.environ.get('SLCLI_USER', None)
     password = os.environ.get('SLCLI_PASSWORD', '')
     yubi = None
-    client = env.client
+    client = employee_client()
 
     # Might already be logged in, try and refresh token
     if settings.get('access_token') and settings.get('userid'):

SoftLayer/config.py

@@ -60,7 +60,8 @@ def get_client_settings_config_file(**kwargs):  # pylint: disable=inconsistent-r
         'timeout': '0',
         'proxy': '',
         'userid': '',
-        'access_token': ''
+        'access_token': '',
+        'verify': True
     })
     config.read(config_files)
 
@@ -73,6 +74,7 @@ def get_client_settings_config_file(**kwargs):  # pylint: disable=inconsistent-r
             'api_key': config.get('softlayer', 'api_key'),
             'userid': config.get('softlayer', 'userid'),
             'access_token': config.get('softlayer', 'access_token'),
+            'verify':   config.get('softlayer', 'verify')
         }
 
 

SoftLayer/transports/rest.py

@@ -108,7 +108,6 @@ def __call__(self, request):
         request.url = '%s.%s' % ('/'.join(url_parts), 'json')
 
         # Prefer the request setting, if it's not None
-
         if request.verify is None:
             request.verify = self.verify
 

SoftLayer/transports/transport.py

@@ -56,7 +56,9 @@ def __init__(self):
         #: Transport headers.
         self.transport_headers = {}
 
-        #: Boolean specifying if the server certificate should be verified.
+        #: False -> Don't verify the SSL certificate
+        #: True -> Verify the SSL certificate
+        #: Path String -> Verify the SSL certificate with the .pem file at path
         self.verify = None
 
         #: Client certificate file path. (Used by X509Authentication)

SoftLayer/transports/xmlrpc.py

@@ -84,8 +84,7 @@ def __call__(self, request):
                                               encoding="iso-8859-1")
 
         # Prefer the request setting, if it's not None
-        verify = request.verify
-        if verify is None:
+        if request.verify is None:
             request.verify = self.verify
 
         try: