Skip to content

Commit 2068864

Browse files
fix: support discriminators used with oneOf (#704)
* fix: support discriminators used with oneOf * fix: seperate out the nested discriminator rule
1 parent 9a54938 commit 2068864

File tree

4 files changed

+800
-28
lines changed

4 files changed

+800
-28
lines changed

src/rulesets/rest/2022-05-25/__tests__/__snapshots__/end-end.test.ts.snap

Lines changed: 50 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,31 @@ exports[`end-end-tests fails for the right reason with invalid parameters 1`] =
107107
"expected": undefined,
108108
"isMust": true,
109109
"isShould": false,
110-
"name": "no mapping objects in discriminators",
110+
"name": "discriminator usage rules",
111+
"passed": true,
112+
"received": undefined,
113+
"severity": 2,
114+
"sourcemap": {
115+
"endLine": 362,
116+
"endPosition": 12008,
117+
"filePath": "/end-end-tests/api-standards/resources/repos/2022-04-04/spec.yaml",
118+
"preview": "",
119+
"startLine": 1,
120+
"startPosition": 0,
121+
},
122+
"type": "changed",
123+
"where": "specification",
124+
},
125+
{
126+
"change": null,
127+
"condition": undefined,
128+
"docsLink": "https://github.com/snyk/sweater-comb/blob/main/docs/standards/rest.md#polymorphic-objects",
129+
"error": undefined,
130+
"exempted": false,
131+
"expected": undefined,
132+
"isMust": true,
133+
"isShould": false,
134+
"name": "no nested discriminators",
111135
"passed": true,
112136
"received": undefined,
113137
"severity": 2,
@@ -166750,7 +166774,31 @@ exports[`end-end-tests passes valid bulk POST operation 1`] = `
166750166774
"expected": undefined,
166751166775
"isMust": true,
166752166776
"isShould": false,
166753-
"name": "no mapping objects in discriminators",
166777+
"name": "discriminator usage rules",
166778+
"passed": true,
166779+
"received": undefined,
166780+
"severity": 2,
166781+
"sourcemap": {
166782+
"endLine": 120,
166783+
"endPosition": 3986,
166784+
"filePath": "/end-end-tests/api-standards/resources/thing/2021-11-10/000-batch-post.yaml",
166785+
"preview": "",
166786+
"startLine": 1,
166787+
"startPosition": 0,
166788+
},
166789+
"type": "changed",
166790+
"where": "specification",
166791+
},
166792+
{
166793+
"change": null,
166794+
"condition": undefined,
166795+
"docsLink": "https://github.com/snyk/sweater-comb/blob/main/docs/standards/rest.md#polymorphic-objects",
166796+
"error": undefined,
166797+
"exempted": false,
166798+
"expected": undefined,
166799+
"isMust": true,
166800+
"isShould": false,
166801+
"name": "no nested discriminators",
166754166802
"passed": true,
166755166803
"received": undefined,
166756166804
"severity": 2,

0 commit comments

Comments
 (0)