Merge pull request #81 from cloudskiff/fix_crash_for_s3_buckets

Fix crash for buckets in us-east-1

Author: eliecharra

pkg/remote/aws/s3_bucket_supplier.go

@@ -68,6 +68,13 @@ func readBucketRegion(client *s3iface.S3API, name string) (string, error) {
 		}
 		return "", err
 	}
+
+	// Buckets in Region us-east-1 have a LocationConstraint of null.
+	// https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLocation.html#API_GetBucketLocation_ResponseSyntax
+	if bucketLocationResponse.LocationConstraint == nil {
+		return "us-east-1", err
+	}
+
 	return *bucketLocationResponse.LocationConstraint, nil
 }
 

pkg/resource/aws/aws_s3_bucket_test.go

@@ -0,0 +1,26 @@
+package aws_test
+
+import (
+	"testing"
+
+	"github.com/cloudskiff/driftctl/test/acceptance"
+)
+
+func TestAcc_AwsS3Bucket_BucketInUsEast1(t *testing.T) {
+	acceptance.Run(t, acceptance.AccTestCase{
+		Path: "./testdata/acc/aws_s3_bucket",
+		Args: []string{"scan", "--filter", "Type=='aws_s3_bucket'"},
+		Checks: []acceptance.AccCheck{
+			{
+				Check: func(result *acceptance.ScanResult, stdout string, err error) {
+					if err != nil {
+						t.Fatal(err)
+					}
+					result.Equal(1, result.Summary().TotalManaged)
+					result.Equal("aws_s3_bucket", result.Analysis.Managed()[0].TerraformType())
+					result.Equal("foobar.driftctl-test.com", result.Analysis.Managed()[0].TerraformId())
+				},
+			},
+		},
+	})
+}

pkg/resource/aws/testdata/acc/aws_s3_bucket/.terraform.lock.hcl

@@ -0,0 +1,10 @@
+provider "aws" {
+  region  = "us-east-1"
+}
+terraform {
+  required_providers {
+    aws = {
+      version = "~> 3.19.0"
+    }
+  }
+}

pkg/resource/aws/testdata/acc/aws_s3_bucket/providers.tf

@@ -0,0 +1,3 @@
+resource "aws_s3_bucket" "foobar" {
+  bucket = "foobar.driftctl-test.com"
+}