turn canLookupByIssuer into variable

darkfronza · darkfronza · commit b78b8bba5796 · 2026-01-08T11:20:35.000-03:00
The function was a relic from past refactoring code, not necessary
anymore.
diff --git a/kms/capi/capi.go b/kms/capi/capi.go
@@ -353,9 +353,7 @@ func (k *CAPIKMS) getCertContext(req *apiv1.LoadCertificateRequest) (*windows.Ce
 		return nil, fmt.Errorf("CertOpenStore for the %q store %q returned: %w", storeLocation, storeName, err)
 	}
 
-	canLookupByIssuer := func() bool {
-		return issuerName != "" && (serialNumber != "" || subjectCN != "" || friendlyName != "" || description != "")
-	}
+	canLookupByIssuer := issuerName != "" && (serialNumber != "" || subjectCN != "" || friendlyName != "" || description != "")
 
 	var handle *windows.CertContext
 

Original file line number	Diff line number	Diff line change
`@@ -353,9 +353,7 @@ func (k CAPIKMS) getCertContext(req apiv1.LoadCertificateRequest) (*windows.Ce`
`353`	`353`	`return nil, fmt.Errorf("CertOpenStore for the %q store %q returned: %w", storeLocation, storeName, err)`
`354`	`354`	`}`
`355`	`355`
`356`		`- canLookupByIssuer := func() bool {`
`357`		`- return issuerName != "" && (serialNumber != "" \|\| subjectCN != "" \|\| friendlyName != "" \|\| description != "")`
`358`		`- }`
	`356`	`+ canLookupByIssuer := issuerName != "" && (serialNumber != "" \|\| subjectCN != "" \|\| friendlyName != "" \|\| description != "")`
`359`	`357`
`360`	`358`	`var handle *windows.CertContext`
`361`	`359`