SK-2618: Fix build script to correctly include compiled lib output in published package (#130)

* SK-2618: update build command to include ts, common and modules libraries in build

Author: saileshwar-skyflow

.github/workflows/internal-release.yml

@@ -23,17 +23,8 @@ jobs:
       - uses: actions/setup-node@v1
         with:
           node-version: 14.21.3
-      - run: npm install
-
-      - name: npm build
-        run: npm run build
 
-      - name: build react-native-sdk
-        run: |
-          curl -u ${{ secrets.JFROG_USERNAME }}:${{ secrets.JFROG_PASSWORD }} https://prekarilabs.jfrog.io/prekarilabs/api/npm/auth/ > ~/.npmrc
-          npm config set registry https://prekarilabs.jfrog.io/prekarilabs/api/npm/npm/
-          npm config set unsafe-perm true
-          npm run build
+      - run: npm install
 
       - name: Get Previous tag
         id: previoustag
@@ -54,6 +45,12 @@ jobs:
           git commit -m "[AUTOMATED] Private Release ${{ steps.previoustag.outputs.tag }}-dev.$(git rev-parse --short $GITHUB_SHA)"
           git push origin -f
 
-      - name: publish to jfrog
+      - name: build react-native-sdk
         run: |
-          npm publish
+          curl -u ${{ secrets.JFROG_USERNAME }}:${{ secrets.JFROG_PASSWORD }} https://prekarilabs.jfrog.io/prekarilabs/api/npm/auth/ > ~/.npmrc
+          npm config set registry https://prekarilabs.jfrog.io/prekarilabs/api/npm/npm/
+          npm config set unsafe-perm true
+          npm run build
+
+      - name: publish to jfrog
+        run: npm publish

.github/workflows/release.yml

@@ -20,14 +20,11 @@ jobs:
         with:
           node-version: 14.21.3
           registry-url: 'https://registry.npmjs.org'
-      - run: npm install
+
 
       - name: install modules
         run: npm install
 
-      - name: Build
-        run: npm run build
-
       - name: Get Previous tag
         id: previoustag
         uses: WyriHaximus/github-action-get-previous-tag@v1
@@ -47,6 +44,9 @@ jobs:
           git commit -m "[AUTOMATED] Public Release - ${{ steps.previoustag.outputs.tag }}"
           git push
 
+      - name: Build
+        run: npm run build
+
       - name: publish to npm
         run: npm publish
         env:

package.json

@@ -4,14 +4,7 @@
   "description": "Skyflow React Native SDK",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",
-  "types": "lib/typescript/src/index.d.ts",
-  "exports": {
-    ".": {
-      "types": "./lib/typescript/src/index.d.ts",
-      "import": "./lib/module/index.js",
-      "require": "./lib/commonjs/index.js"
-    }
-  },
+  "types": "lib/typescript/index.d.ts",
   "react-native": "src/index",
   "source": "src/index",
   "files": [
@@ -36,7 +29,7 @@
     "prepare": "bob build",
     "example": "yarn --cwd example",
     "bootstrap": "yarn example && yarn && yarn example pods",
-    "build": "bob build && cp -r assets lib/ && cp package.json lib/"
+    "build": "node scripts/generateSdkDetails.js && bob build && cp -r assets lib/"
   },
   "keywords": [
     "react-native",

scripts/generateSdkDetails.js

@@ -0,0 +1,12 @@
+const fs = require('fs');
+const pkg = require('../package.json');
+
+const content = `
+export const sdkDetails = {
+  name: "${pkg.name}",
+  version: "${pkg.version}",
+  reactNativeVersion: "${pkg.devDependencies['react-native']}"
+};
+`;
+
+fs.writeFileSync('src/sdkDetails.ts', content);

src/core-utils/client/index.ts

@@ -7,7 +7,7 @@ import SkyflowError from '../../utils/skyflow-error';
 import SKYFLOW_ERROR_CODE from '../../utils/skyflow-error-code';
 import { getMetaObject } from '../../utils/helpers';
 import { Platform } from 'react-native';
-import sdkDetails from '../../../package.json';
+import { sdkDetails } from '../../sdkDetails';
 
 export interface IClientRequest {
   body?: any;

src/core/constants/index.ts

@@ -13,7 +13,7 @@ import maseterCardIcon from '../../../assets/mastercard.png';
 import unionPayIcon from '../../../assets/unionpay.png';
 import visaCardIcon from '../../../assets/visa.png';
 import cartesBancairesIcon from '../../../assets/carter-banceris.png'
-import sdkDetails from '../../../package.json';
+import { sdkDetails } from '../../sdkDetails';
 
 export const SDK_DETAILS = {
   sdkName: 'React Native',

src/sdkDetails.ts

@@ -0,0 +1,5 @@
+export const sdkDetails = {
+  name: '',
+  version: '',
+  reactNativeVersion: '',
+};