[codex] Add length axis option to size plots#345
Open
gustavdelius wants to merge 3 commits into
Open
Conversation
7a4ca83 to
8d84886
Compare
Member
Author
|
Fixed the example-check failure from Root cause: the shared comparison helpers were defaulting to size-axis conversion and assumed a Validation rerun:
|
8d84886 to
07266b8
Compare
Member
Author
|
Fixed the Rd warning for Updated branch head: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
size_axis = c("w", "l")to size-based plotting APIs so users can show length in cm instead of weight in grams on the size axis. Length values are derived from the species-specific allometric weight-length relationship via the existingw2l()helper.Details
size_axis = "w"as the default to preserve existing plot behaviour.ResourceandTotalcurves for length-axis plots because they do not have a species-specific weight-length relationship.return_data = TRUEoutput so the plotted size column islwhensize_axis = "l".Validation
devtools::load_all(); testthat::test_file("tests/testthat/test-plots.R")plotlySpectra(..., size_axis = "l")andanimate(..., size_axis = "l").