fix(connectors): address PR review comments

- github: skip blob fetch for empty 0-byte files
- salesforce: add fallback message for empty error
- zendesk: warn on invalid statusFilter instead of silent fallthrough
- evernote: remove dead content.trim() guard

Author: waleedlatif1

apps/sim/connectors/evernote/evernote.ts

@@ -464,7 +464,6 @@ export const evernoteConnector: ConnectorConfig = {
       const plainText = htmlToPlainText(note.content)
       const title = note.title || 'Untitled'
       const content = plainText.trim() ? plainText : title
-      if (!content.trim()) return null
 
       const shardId = extractShardId(accessToken)
       const userId = extractUserId(accessToken)

apps/sim/connectors/github/github.ts

@@ -312,7 +312,7 @@ export const githubConnector: ConnectorConfig = {
       let content: string
       if (encoding === 'base64' && rawContent.length > 0) {
         content = Buffer.from(rawContent, 'base64').toString('utf8')
-      } else if ((encoding === 'none' || rawContent.length === 0) && data.sha) {
+      } else if (encoding === 'none' && data.sha && size > 0) {
         content = await fetchBlobContent(accessToken, owner, repo, data.sha as string)
       } else {
         content = ''

apps/sim/connectors/salesforce/salesforce.ts

@@ -479,7 +479,7 @@ export const salesforceConnector: ConnectorConfig = {
 
       return { valid: true }
     } catch (error) {
-      return { valid: false, error: toError(error).message }
+      return { valid: false, error: toError(error).message || 'Failed to validate configuration' }
     }
   },
 

apps/sim/connectors/zendesk/zendesk.ts

@@ -134,17 +134,23 @@ async function fetchTickets(
   const limit = maxTickets || DEFAULT_MAX_TICKETS
   let url: string | null = `${baseUrl}/api/v2/tickets.json?per_page=${TICKETS_PER_PAGE}`
 
-  if (statusFilter && statusFilter !== 'all' && VALID_TICKET_STATUSES.has(statusFilter)) {
-    if (limit > SEARCH_API_RESULT_CAP) {
+  if (statusFilter && statusFilter !== 'all') {
+    if (VALID_TICKET_STATUSES.has(statusFilter)) {
+      if (limit > SEARCH_API_RESULT_CAP) {
+        logger.warn(
+          `Zendesk Search API caps at ${SEARCH_API_RESULT_CAP} results; requested limit ${limit} will be truncated. Remove status filter to use the unbounded tickets endpoint.`
+        )
+      }
+      const params = new URLSearchParams({
+        query: `type:ticket status:${statusFilter}`,
+        per_page: String(TICKETS_PER_PAGE),
+      })
+      url = `${baseUrl}/api/v2/search.json?${params.toString()}`
+    } else {
       logger.warn(
-        `Zendesk Search API caps at ${SEARCH_API_RESULT_CAP} results; requested limit ${limit} will be truncated. Remove status filter to use the unbounded tickets endpoint.`
+        `Invalid Zendesk statusFilter "${statusFilter}"; falling back to all tickets. Valid values: ${[...VALID_TICKET_STATUSES].join(', ')}.`
       )
     }
-    const params = new URLSearchParams({
-      query: `type:ticket status:${statusFilter}`,
-      per_page: String(TICKETS_PER_PAGE),
-    })
-    url = `${baseUrl}/api/v2/search.json?${params.toString()}`
   }
 
   while (url && allTickets.length < limit) {