fix(uploads): read the not-found label from code as well as name

Azure raises a RestError whose name carries the class and whose code carries the
reason, so testing name first and falling back to code only when name was absent
missed BlobNotFound outright — narrower than the per-provider check it replaced.

Author: waleedlatif1

apps/sim/lib/uploads/core/errors.test.ts

@@ -24,6 +24,12 @@ describe('isObjectNotFoundError', () => {
     expect(isObjectNotFoundError({ code: 404 })).toBe(true)
   })
 
+  it('reads the label from code when name carries the error class instead', () => {
+    /** Azure raises a `RestError`; the reason lives in `code`, not `name`. */
+    expect(isObjectNotFoundError({ name: 'RestError', code: 'BlobNotFound' })).toBe(true)
+    expect(isObjectNotFoundError({ name: 'Error', code: 'NoSuchKey' })).toBe(true)
+  })
+
   it('matches on status alone when the provider sends no label', () => {
     expect(isObjectNotFoundError({ $metadata: { httpStatusCode: 404 } })).toBe(true)
     expect(isObjectNotFoundError({ statusCode: 404 })).toBe(true)

apps/sim/lib/uploads/core/errors.ts

@@ -1,3 +1,5 @@
+const NOT_FOUND_LABELS = new Set(['NotFound', 'NoSuchKey', 'BlobNotFound'])
+
 /**
  * True when a storage provider reports that an object simply does not exist.
  *
@@ -13,19 +15,20 @@
 export function isObjectNotFoundError(error: unknown): boolean {
   if (!error || typeof error !== 'object') return false
 
-  const candidate = error as {
+  const { name, code, statusCode, $metadata } = error as {
     name?: unknown
     code?: unknown
     statusCode?: unknown
     $metadata?: { httpStatusCode?: unknown }
   }
 
-  const label = typeof candidate.name === 'string' ? candidate.name : candidate.code
-  if (label === 'NotFound' || label === 'NoSuchKey' || label === 'BlobNotFound') return true
+  /**
+   * `name` and `code` are checked independently: Azure raises a `RestError` whose
+   * `name` says nothing useful and whose `code` carries the reason, while the AWS
+   * SDK puts the reason in `name`.
+   */
+  if (typeof name === 'string' && NOT_FOUND_LABELS.has(name)) return true
+  if (typeof code === 'string' && NOT_FOUND_LABELS.has(code)) return true
 
-  return (
-    candidate.code === 404 ||
-    candidate.statusCode === 404 ||
-    candidate.$metadata?.httpStatusCode === 404
-  )
+  return code === 404 || statusCode === 404 || $metadata?.httpStatusCode === 404
 }

apps/sim/lib/uploads/providers/blob/client.ts

@@ -7,6 +7,7 @@ import {
   readNodeStreamToBufferWithLimit,
 } from '@/lib/core/utils/stream-limits'
 import { BLOB_CONFIG } from '@/lib/uploads/config'
+import { isObjectNotFoundError } from '@/lib/uploads/core/errors'
 import type {
   AzureMultipartPart,
   AzureMultipartUploadInit,
@@ -20,7 +21,6 @@ import type {
 } from '@/lib/uploads/shared/types'
 import { sanitizeStorageMetadata } from '@/lib/uploads/utils/file-utils'
 import { sanitizeFileName } from '@/executor/constants'
-import { isObjectNotFoundError } from '@/lib/uploads/core/errors'
 
 const logger = createLogger('BlobClient')
 const MULTIPART_UPLOAD_ID_METADATA_KEY = 'sim_upload_id'

apps/sim/lib/uploads/providers/gcs/client.ts

@@ -8,6 +8,7 @@ import {
   readNodeStreamToBufferWithLimit,
 } from '@/lib/core/utils/stream-limits'
 import { GCS_CONFIG } from '@/lib/uploads/config'
+import { isObjectNotFoundError } from '@/lib/uploads/core/errors'
 import type {
   GcsConfig,
   GcsMultipartPart,
@@ -24,7 +25,6 @@ import {
   sanitizeStorageMetadata,
 } from '@/lib/uploads/utils/file-utils'
 import { sanitizeFileName } from '@/executor/constants'
-import { isObjectNotFoundError } from '@/lib/uploads/core/errors'
 
 const logger = createLogger('GcsClient')
 

apps/sim/lib/uploads/providers/s3/client.ts

@@ -20,6 +20,7 @@ import {
   readNodeStreamToBufferWithLimit,
 } from '@/lib/core/utils/stream-limits'
 import { S3_CONFIG, S3_KB_CONFIG } from '@/lib/uploads/config'
+import { isObjectNotFoundError } from '@/lib/uploads/core/errors'
 import type {
   S3Config,
   S3MultipartPart,
@@ -36,7 +37,6 @@ import {
   sanitizeStorageMetadata,
 } from '@/lib/uploads/utils/file-utils'
 import { sanitizeFileName } from '@/executor/constants'
-import { isObjectNotFoundError } from '@/lib/uploads/core/errors'
 
 let _s3Client: S3Client | null = null