fix state machine issue

Author: icecrasher321

apps/sim/lib/copilot/chat/stream-liveness.test.ts

@@ -127,26 +127,24 @@ describe('reconcileChatStreamMarkers', () => {
     })
   })
 
-  it('detects a live lock before the persisted marker has been written', async () => {
+  it('treats a null persisted marker as inactive even when Redis still holds a lock (post-completion teardown window)', async () => {
     mockGetChatStreamLockOwners.mockResolvedValueOnce({
       status: 'verified',
       ownersByChatId: new Map([['chat-starting', 'stream-starting']]),
     })
 
     const markers = await reconcileChatStreamMarkers([{ chatId: 'chat-starting', streamId: null }])
 
-    expect(mockGetChatStreamLockOwners).toHaveBeenCalledWith(['chat-starting'])
     expect(markers.get('chat-starting')).toEqual({
       chatId: 'chat-starting',
-      streamId: 'stream-starting',
-      status: 'active',
+      streamId: null,
+      status: 'inactive',
     })
   })
 
-  it('queries locks even when no persisted markers exist', async () => {
+  it('does not query locks when no chats have persisted stream markers', async () => {
     const markers = await reconcileChatStreamMarkers([{ chatId: 'chat-idle', streamId: null }])
 
-    expect(mockGetChatStreamLockOwners).toHaveBeenCalledWith(['chat-idle'])
     expect(markers.get('chat-idle')).toEqual({
       chatId: 'chat-idle',
       streamId: null,

apps/sim/lib/copilot/chat/stream-liveness.ts

@@ -38,27 +38,33 @@ export async function reconcileChatStreamMarkers(
   const results = new Map<string, ReconciledChatStreamMarker>()
 
   for (const candidate of candidates) {
+    if (candidate.streamId === null) {
+      results.set(candidate.chatId, {
+        chatId: candidate.chatId,
+        streamId: null,
+        status: 'inactive',
+      })
+      continue
+    }
     results.set(candidate.chatId, {
       chatId: candidate.chatId,
       streamId: candidate.streamId,
-      status: candidate.streamId ? 'unknown' : 'inactive',
+      status: 'unknown',
     })
   }
 
-  if (candidates.length === 0) {
+  const candidatesWithMarkers = candidates.filter((candidate) => candidate.streamId !== null)
+  if (candidatesWithMarkers.length === 0) {
     return results
   }
 
   const { status, ownersByChatId } = await getChatStreamLockOwners(
-    candidates.map((candidate) => candidate.chatId)
+    candidatesWithMarkers.map((candidate) => candidate.chatId)
   )
 
-  for (const candidate of candidates) {
+  for (const candidate of candidatesWithMarkers) {
     const owner = ownersByChatId.get(candidate.chatId)
-    if (
-      owner &&
-      (status === 'verified' || owner === candidate.streamId || candidate.streamId === null)
-    ) {
+    if (owner && (status === 'verified' || owner === candidate.streamId)) {
       results.set(candidate.chatId, {
         chatId: candidate.chatId,
         streamId: owner,
@@ -67,7 +73,7 @@ export async function reconcileChatStreamMarkers(
       continue
     }
 
-    if (status === 'verified' && candidate.streamId !== null) {
+    if (status === 'verified') {
       results.set(candidate.chatId, {
         chatId: candidate.chatId,
         streamId: null,
@@ -79,7 +85,7 @@ export async function reconcileChatStreamMarkers(
     results.set(candidate.chatId, {
       chatId: candidate.chatId,
       streamId: candidate.streamId,
-      status: candidate.streamId ? 'unknown' : 'inactive',
+      status: 'unknown',
     })
   }