Skip to content

Commit e6f17ca

Browse files
committed
fix(kb-connectors): only merge changed fields into sourceConfig on edit save
Avoids writing spurious empty-string keys for untouched optional fields when another field triggers a save.
1 parent 13faa16 commit e6f17ca

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/edit-connector-modal/edit-connector-modal.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,12 @@ export function EditConnectorModal({
122122
}
123123

124124
const resolved = resolveSourceConfig()
125-
const configChanged = Object.entries(resolved).some(
126-
([key, value]) => String(connector.sourceConfig[key] ?? '') !== value
127-
)
128-
if (configChanged) {
129-
updates.sourceConfig = { ...connector.sourceConfig, ...resolved }
125+
const changedEntries: Record<string, string> = {}
126+
for (const [key, value] of Object.entries(resolved)) {
127+
if (String(connector.sourceConfig[key] ?? '') !== value) changedEntries[key] = value
128+
}
129+
if (Object.keys(changedEntries).length > 0) {
130+
updates.sourceConfig = { ...connector.sourceConfig, ...changedEntries }
130131
}
131132

132133
if (Object.keys(updates).length === 0) {

0 commit comments

Comments
 (0)