fix(quickbooks): require recipient for payment email

Author: Bill Leoutsakos

apps/docs/content/docs/en/integrations/quickbooks.mdx

@@ -2692,7 +2692,7 @@ Send a supported QuickBooks transaction by email. This causes an external email
 | --------- | ---- | -------- | ----------- |
 | `transactionType` | string | Yes | Supported transaction type to email |
 | `transactionId` | string | Yes | QuickBooks transaction ID |
-| `recipient` | string | No | Optional single recipient override; otherwise QuickBooks uses the stored recipient |
+| `recipient` | string | No | Required for Customer Payments; otherwise an optional single recipient override |
 | `confirmSend` | boolean | Yes | Explicit confirmation that an external email should be sent |
 
 #### Output

apps/sim/blocks/blocks/quickbooks.ts

@@ -496,11 +496,17 @@ export const QuickBooksBlock: BlockConfig<QuickBooksResponse> = {
     },
     {
       id: 'recipientOverride',
-      title: 'Recipient Override',
+      title: 'Recipient',
       type: 'short-input',
-      placeholder: 'Optional single email address',
+      placeholder: 'Required for Customer Payments; otherwise optional',
       condition: { field: 'operation', value: EMAIL_TRANSACTION_OPERATION },
-      mode: 'advanced',
+      required: {
+        field: 'operation',
+        value: EMAIL_TRANSACTION_OPERATION,
+        and: { field: 'documentTransactionType', value: 'payment' },
+      },
+      description:
+        'Required for Customer Payments. For other transactions, leave blank to use the email stored in QuickBooks or provide one override address.',
     },
     {
       id: 'documentFileName',

apps/sim/tools/generated/tool-metadata.ts

@@ -68,6 +68,10 @@ describe('QuickBooks document tools', () => {
     expect(() => requestUrl({ ...base, recipient: 'a@example.com\r\nBcc:x@example.com' })).toThrow(
       'one valid email'
     )
+    expect(() => requestUrl({ ...base, transactionType: 'payment' })).toThrow(
+      'recipient is required when emailing a QuickBooks Customer Payment'
+    )
+    expect(new URL(requestUrl(base)).searchParams.has('sendTo')).toBe(false)
   })
 
   it('preserves a verified native record from a successful email response', async () => {
@@ -343,6 +347,13 @@ describe('QuickBooks document validation and block parity', () => {
       'attachmentFileReference',
     ])
     expect(fileBlocks.every((block) => block.required !== undefined)).toBe(true)
+    const recipient = QuickBooksBlock.subBlocks.find((block) => block.id === 'recipientOverride')
+    expect(recipient?.mode).toBeUndefined()
+    expect(recipient?.required).toEqual({
+      field: 'operation',
+      value: 'quickbooks_email_transaction',
+      and: { field: 'documentTransactionType', value: 'payment' },
+    })
   })
 
   it('maps document params after dynamic references resolve', () => {

apps/sim/tools/quickbooks/documents.test.ts

@@ -56,7 +56,7 @@ export const quickbooksEmailTransactionTool: ToolConfig<
       required: false,
       visibility: 'user-or-llm',
       description:
-        'Optional single recipient override; otherwise QuickBooks uses the stored recipient',
+        'Required for Customer Payments; otherwise an optional single recipient override',
     },
     confirmSend: {
       type: 'boolean',
@@ -82,6 +82,9 @@ export const quickbooksEmailTransactionTool: ToolConfig<
         `${resource}/${encodeURIComponent(id)}/send`
       )
       const recipient = validateQuickBooksRecipient(params.recipient)
+      if (params.transactionType === 'payment' && !recipient) {
+        throw new Error('recipient is required when emailing a QuickBooks Customer Payment')
+      }
       if (recipient) url.searchParams.set('sendTo', recipient)
       return url.toString()
     },