Skip to content

Commit dabf2d1

Browse files
committed
fix(tables): fit the whole column-type list in the New column dropdown
Adding currency made the list nine items (295px with its separator and padding), past the shared dropdown's 240px cap — so Select and Workflow sat below a scrollbar. Sized on this dropdown rather than on the shared `DropdownMenuContent`, which every other menu in the app relies on. Also gave the sidebar's type combobox headroom, since it gained the same entry and was within 4px of its own cap.
1 parent f234c67 commit dabf2d1

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-config-sidebar/column-config-sidebar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ function ColumnConfigBody({
282282
value={typeInput}
283283
onChange={(v) => setTypeInput(v as ColumnDefinition['type'])}
284284
placeholder='Select type'
285-
maxHeight={260}
285+
maxHeight={300}
286286
/>
287287
</div>
288288
</>

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/new-column-dropdown/new-column-dropdown.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,11 @@ export function NewColumnDropdown({
8686
const menu = (
8787
<DropdownMenu>
8888
<DropdownMenuTrigger asChild>{triggerButton}</DropdownMenuTrigger>
89-
<DropdownMenuContent align='start' side='bottom' sideOffset={4}>
89+
{/* Taller than the 240px shared default: the full type list is 9 items
90+
(295px with its separator and padding), so the default cut the last
91+
two off behind a scrollbar. Sized here rather than in the shared
92+
component, which every other dropdown in the app relies on. */}
93+
<DropdownMenuContent align='start' side='bottom' sideOffset={4} className='max-h-[320px]'>
9094
<>
9195
<DropdownMenuItem onSelect={onPickEnrichment}>
9296
<Sparkles className='size-[14px] text-[var(--text-icon)]' />

0 commit comments

Comments
 (0)