fix ui shape

Author: TheodoreSpeaks

apps/sim/app/api/table/[tableId]/columns/run/route.ts

@@ -0,0 +1,48 @@
+import { createLogger } from '@sim/logger'
+import { type NextRequest, NextResponse } from 'next/server'
+import { runColumnContract } from '@/lib/api/contracts/tables'
+import { parseRequest } from '@/lib/api/server'
+import { checkSessionOrInternalAuth } from '@/lib/auth/hybrid'
+import { generateRequestId } from '@/lib/core/utils/request'
+import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
+import { runWorkflowColumn } from '@/lib/table/workflow-columns'
+import { accessError, checkAccess } from '@/app/api/table/utils'
+
+const logger = createLogger('TableRunColumnAPI')
+
+interface RouteParams {
+  params: Promise<{ tableId: string }>
+}
+
+/** POST /api/table/[tableId]/columns/run */
+export const POST = withRouteHandler(async (request: NextRequest, { params }: RouteParams) => {
+  const requestId = generateRequestId()
+  try {
+    const auth = await checkSessionOrInternalAuth(request, { requireWorkflowId: false })
+    if (!auth.success || !auth.userId) {
+      return NextResponse.json({ error: 'Authentication required' }, { status: 401 })
+    }
+    const parsed = await parseRequest(runColumnContract, request, { params })
+    if (!parsed.success) return parsed.response
+    const { tableId } = parsed.data.params
+    const { workspaceId, groupIds, runMode, rowIds } = parsed.data.body
+    const access = await checkAccess(tableId, auth.userId, 'write')
+    if (!access.ok) return accessError(access, requestId, tableId)
+
+    const { triggered } = await runWorkflowColumn({
+      tableId,
+      workspaceId,
+      groupIds,
+      mode: runMode,
+      rowIds,
+      requestId,
+    })
+    return NextResponse.json({ success: true, data: { triggered } })
+  } catch (error) {
+    if (error instanceof Error && error.message === 'Invalid workspace ID') {
+      return NextResponse.json({ error: 'Invalid workspace ID' }, { status: 400 })
+    }
+    logger.error(`run-column failed:`, error)
+    return NextResponse.json({ error: 'Failed to run columns' }, { status: 500 })
+  }
+})

apps/sim/app/api/table/[tableId]/groups/[groupId]/run/route.ts

@@ -0,0 +1,47 @@
+import { createLogger } from '@sim/logger'
+import { type NextRequest, NextResponse } from 'next/server'
+import { runCellContract } from '@/lib/api/contracts/tables'
+import { parseRequest } from '@/lib/api/server'
+import { checkSessionOrInternalAuth } from '@/lib/auth/hybrid'
+import { generateRequestId } from '@/lib/core/utils/request'
+import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
+import { runWorkflowCell } from '@/lib/table/workflow-columns'
+import { accessError, checkAccess } from '@/app/api/table/utils'
+
+const logger = createLogger('TableRunCellAPI')
+
+interface RouteParams {
+  params: Promise<{ tableId: string; rowId: string; groupId: string }>
+}
+
+/** POST /api/table/[tableId]/rows/[rowId]/cells/[groupId]/run */
+export const POST = withRouteHandler(async (request: NextRequest, { params }: RouteParams) => {
+  const requestId = generateRequestId()
+  try {
+    const auth = await checkSessionOrInternalAuth(request, { requireWorkflowId: false })
+    if (!auth.success || !auth.userId) {
+      return NextResponse.json({ error: 'Authentication required' }, { status: 401 })
+    }
+    const parsed = await parseRequest(runCellContract, request, { params })
+    if (!parsed.success) return parsed.response
+    const { tableId, rowId, groupId } = parsed.data.params
+    const { workspaceId } = parsed.data.body
+    const access = await checkAccess(tableId, auth.userId, 'write')
+    if (!access.ok) return accessError(access, requestId, tableId)
+
+    const { triggered } = await runWorkflowCell({
+      tableId,
+      workspaceId,
+      rowId,
+      groupId,
+      requestId,
+    })
+    return NextResponse.json({ success: true, data: { triggered } })
+  } catch (error) {
+    if (error instanceof Error && error.message === 'Invalid workspace ID') {
+      return NextResponse.json({ error: 'Invalid workspace ID' }, { status: 400 })
+    }
+    logger.error(`run-cell failed:`, error)
+    return NextResponse.json({ error: 'Failed to run cell' }, { status: 500 })
+  }
+})

apps/sim/app/api/table/[tableId]/rows/[rowId]/cells/[groupId]/run/route.ts

@@ -0,0 +1,46 @@
+import { createLogger } from '@sim/logger'
+import { type NextRequest, NextResponse } from 'next/server'
+import { runRowContract } from '@/lib/api/contracts/tables'
+import { parseRequest } from '@/lib/api/server'
+import { checkSessionOrInternalAuth } from '@/lib/auth/hybrid'
+import { generateRequestId } from '@/lib/core/utils/request'
+import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
+import { runWorkflowRow } from '@/lib/table/workflow-columns'
+import { accessError, checkAccess } from '@/app/api/table/utils'
+
+const logger = createLogger('TableRunRowAPI')
+
+interface RouteParams {
+  params: Promise<{ tableId: string }>
+}
+
+/** POST /api/table/[tableId]/rows/run */
+export const POST = withRouteHandler(async (request: NextRequest, { params }: RouteParams) => {
+  const requestId = generateRequestId()
+  try {
+    const auth = await checkSessionOrInternalAuth(request, { requireWorkflowId: false })
+    if (!auth.success || !auth.userId) {
+      return NextResponse.json({ error: 'Authentication required' }, { status: 401 })
+    }
+    const parsed = await parseRequest(runRowContract, request, { params })
+    if (!parsed.success) return parsed.response
+    const { tableId } = parsed.data.params
+    const { workspaceId, rowIds } = parsed.data.body
+    const access = await checkAccess(tableId, auth.userId, 'write')
+    if (!access.ok) return accessError(access, requestId, tableId)
+
+    const { triggered } = await runWorkflowRow({
+      tableId,
+      workspaceId,
+      rowIds,
+      requestId,
+    })
+    return NextResponse.json({ success: true, data: { triggered } })
+  } catch (error) {
+    if (error instanceof Error && error.message === 'Invalid workspace ID') {
+      return NextResponse.json({ error: 'Invalid workspace ID' }, { status: 400 })
+    }
+    logger.error(`run-row failed:`, error)
+    return NextResponse.json({ error: 'Failed to run rows' }, { status: 500 })
+  }
+})

apps/sim/app/api/table/[tableId]/rows/[rowId]/run-workflow-group/route.ts

@@ -48,10 +48,10 @@ interface ColumnOptionsMenuProps {
   onDeleteGroup?: () => void
   /** When provided, the menu is being opened from a workflow-group header and
    *  exposes group-level run actions above the column actions. */
-  onRunGroupAll?: () => void
-  onRunGroupIncomplete?: () => void
+  onRunColumnAll?: () => void
+  onRunColumnIncomplete?: () => void
   /** When set, surfaces a "Run N selected rows" item above Run all. */
-  onRunGroupSelected?: () => void
+  onRunColumnSelected?: () => void
   selectedRowCount?: number
   /** When set, the menu surfaces a "View workflow" item that opens a popup
    *  preview of the configured workflow. */
@@ -76,14 +76,14 @@ export function ColumnOptionsMenu({
   onInsertRight,
   onDeleteColumn,
   onDeleteGroup,
-  onRunGroupAll,
-  onRunGroupIncomplete,
-  onRunGroupSelected,
+  onRunColumnAll,
+  onRunColumnIncomplete,
+  onRunColumnSelected,
   selectedRowCount = 0,
   onViewWorkflow,
 }: ColumnOptionsMenuProps) {
-  const showRunActions = Boolean(onRunGroupAll && onRunGroupIncomplete)
-  const showRunSelected = Boolean(onRunGroupSelected) && selectedRowCount > 0
+  const showRunActions = Boolean(onRunColumnAll && onRunColumnIncomplete)
+  const showRunSelected = Boolean(onRunColumnSelected) && selectedRowCount > 0
   return (
     <DropdownMenu open={open} onOpenChange={onOpenChange}>
       <DropdownMenuTrigger asChild>
@@ -116,12 +116,14 @@ export function ColumnOptionsMenu({
               </DropdownMenuSubTrigger>
               <DropdownMenuSubContent>
                 {showRunSelected && (
-                  <DropdownMenuItem onSelect={() => onRunGroupSelected?.()}>
+                  <DropdownMenuItem onSelect={() => onRunColumnSelected?.()}>
                     {`Run ${selectedRowCount} selected ${selectedRowCount === 1 ? 'row' : 'rows'}`}
                   </DropdownMenuItem>
                 )}
-                <DropdownMenuItem onSelect={() => onRunGroupAll?.()}>Run all rows</DropdownMenuItem>
-                <DropdownMenuItem onSelect={() => onRunGroupIncomplete?.()}>
+                <DropdownMenuItem onSelect={() => onRunColumnAll?.()}>
+                  Run all rows
+                </DropdownMenuItem>
+                <DropdownMenuItem onSelect={() => onRunColumnIncomplete?.()}>
                   Run empty rows
                 </DropdownMenuItem>
               </DropdownMenuSubContent>
@@ -172,12 +174,7 @@ interface WorkflowGroupMetaCellProps {
   isGroupSelected: boolean
   onSelectGroup: (startColIndex: number, size: number) => void
   onOpenConfig: (columnName: string) => void
-  onRunGroup?: (
-    groupId: string,
-    workflowId: string,
-    mode?: 'all' | 'incomplete',
-    rowIds?: string[]
-  ) => void
+  onRunColumn?: (groupId: string, mode?: 'all' | 'incomplete', rowIds?: string[]) => void
   onInsertLeft?: (columnName: string) => void
   onInsertRight?: (columnName: string) => void
   onDeleteColumn?: (columnName: string) => void
@@ -215,7 +212,7 @@ export function WorkflowGroupMetaCell({
   isGroupSelected,
   onSelectGroup,
   onOpenConfig,
-  onRunGroup,
+  onRunColumn,
   onInsertLeft,
   onInsertRight,
   onDeleteColumn,
@@ -240,18 +237,18 @@ export function WorkflowGroupMetaCell({
   const selectedCount = selectedRowIds?.length ?? 0
 
   const handleRunAll = useCallback(() => {
-    if (groupId && workflowId) onRunGroup?.(groupId, workflowId, 'all')
-  }, [groupId, workflowId, onRunGroup])
+    if (groupId) onRunColumn?.(groupId, 'all')
+  }, [groupId, onRunColumn])
 
   const handleRunIncomplete = useCallback(() => {
-    if (groupId && workflowId) onRunGroup?.(groupId, workflowId, 'incomplete')
-  }, [groupId, workflowId, onRunGroup])
+    if (groupId) onRunColumn?.(groupId, 'incomplete')
+  }, [groupId, onRunColumn])
 
   const handleRunSelected = useCallback(() => {
-    if (groupId && workflowId && selectedRowIds && selectedRowIds.length > 0) {
-      onRunGroup?.(groupId, workflowId, 'all', selectedRowIds)
+    if (groupId && selectedRowIds && selectedRowIds.length > 0) {
+      onRunColumn?.(groupId, 'all', selectedRowIds)
     }
-  }, [groupId, workflowId, onRunGroup, selectedRowIds])
+  }, [groupId, onRunColumn, selectedRowIds])
 
   const handleContextMenu = useCallback(
     (e: React.MouseEvent) => {
@@ -380,7 +377,7 @@ export function WorkflowGroupMetaCell({
         <span className='min-w-0 truncate font-medium text-[11px] text-[var(--text-secondary)]'>
           {name}
         </span>
-        {onRunGroup && (
+        {onRunColumn && (
           <DropdownMenu open={runMenuOpen} onOpenChange={setRunMenuOpen}>
             <DropdownMenuTrigger asChild>
               <button
@@ -421,9 +418,9 @@ export function WorkflowGroupMetaCell({
           onInsertRight={onInsertRight}
           onDeleteColumn={onDeleteColumn}
           onDeleteGroup={onDeleteGroup ? () => onDeleteGroup(groupId) : undefined}
-          onRunGroupAll={onRunGroup ? handleRunAll : undefined}
-          onRunGroupIncomplete={onRunGroup ? handleRunIncomplete : undefined}
-          onRunGroupSelected={onRunGroup && selectedCount > 0 ? handleRunSelected : undefined}
+          onRunColumnAll={onRunColumn ? handleRunAll : undefined}
+          onRunColumnIncomplete={onRunColumn ? handleRunIncomplete : undefined}
+          onRunColumnSelected={onRunColumn && selectedCount > 0 ? handleRunSelected : undefined}
           selectedRowCount={selectedCount}
           onViewWorkflow={onViewWorkflow ? () => onViewWorkflow(workflowId) : undefined}
         />