Skip to content

Commit d450b97

Browse files
committed
address comments
1 parent b987ce6 commit d450b97

3 files changed

Lines changed: 282 additions & 176 deletions

File tree

apps/sim/app/api/workspaces/[id]/files/folders/[folderId]/route.ts

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { createLogger } from '@sim/logger'
2+
import { getPostgresErrorCode } from '@sim/utils/errors'
23
import { type NextRequest, NextResponse } from 'next/server'
34
import {
45
deleteWorkspaceFileFolderContract,
@@ -45,10 +46,24 @@ export const PATCH = withRouteHandler(
4546
return NextResponse.json({ success: true, folder })
4647
} catch (error) {
4748
logger.error('Failed to update workspace file folder:', error)
48-
const message = error instanceof Error ? error.message : 'Failed to update folder'
49+
if (error instanceof WorkspaceFileFolderConflictError) {
50+
return NextResponse.json({ success: false, error: error.message }, { status: 409 })
51+
}
52+
if (getPostgresErrorCode(error) === '23505') {
53+
return NextResponse.json(
54+
{
55+
success: false,
56+
error: 'A folder with this name already exists in this location',
57+
},
58+
{ status: 409 }
59+
)
60+
}
4961
return NextResponse.json(
50-
{ success: false, error: message },
51-
{ status: error instanceof WorkspaceFileFolderConflictError ? 409 : 400 }
62+
{
63+
success: false,
64+
error: error instanceof Error ? error.message : 'Failed to update folder',
65+
},
66+
{ status: 400 }
5267
)
5368
}
5469
}

0 commit comments

Comments
 (0)