refactor(logs): centralize workflow-id resolution and editor path

The logs list, its context menu, and the details panel each resolved a
log's workflow id with their own copy of `workflow?.id || workflowId`,
and the list disagreed with the details panel on what counts as a
deleted workflow. Extract `resolveLogWorkflowId` and
`workflowEditorPath` so the three surfaces cannot drift.

`resolveLogWorkflowId` also returns null for Sim agent jobs, which have
no workflow of their own. Only the context menu's "Open Workflow" item
adopts that stricter predicate; cancel and retry keep using the previous
`hasWorkflow` check so their gating is unchanged.

Author: mzxchandra

apps/sim/app/workspace/[workspaceId]/logs/components/log-row-context-menu/log-row-context-menu.tsx

@@ -16,6 +16,7 @@ import {
   X,
 } from '@sim/emcn'
 import type { WorkflowLogSummary } from '@/lib/api/contracts/logs'
+import { resolveLogWorkflowId } from '@/app/workspace/[workspaceId]/logs/utils'
 
 interface LogRowContextMenuProps {
   isOpen: boolean
@@ -58,6 +59,12 @@ export const LogRowContextMenu = memo(function LogRowContextMenu({
 }: LogRowContextMenuProps) {
   const hasExecutionId = Boolean(log?.executionId)
   const hasWorkflow = Boolean(log?.workflow?.id || log?.workflowId)
+  /**
+   * "Open Workflow" needs a navigable target, which is stricter than
+   * `hasWorkflow`: Sim agent jobs have no workflow of their own. Cancel/retry
+   * keep using `hasWorkflow` so their gating is unchanged.
+   */
+  const hasOpenableWorkflow = Boolean(log && resolveLogWorkflowId(log))
   const isCancellable =
     (log?.status === 'running' || log?.status === 'pending') && hasExecutionId && hasWorkflow
   const isRetryable = log?.status === 'failed' && hasWorkflow && log?.trigger !== 'mothership'
@@ -112,7 +119,7 @@ export const LogRowContextMenu = memo(function LogRowContextMenu({
         </DropdownMenuItem>
 
         <DropdownMenuSeparator />
-        <DropdownMenuItem disabled={!hasWorkflow} onSelect={onOpenWorkflow}>
+        <DropdownMenuItem disabled={!hasOpenableWorkflow} onSelect={onOpenWorkflow}>
           <SquareArrowUpRight />
           Open Workflow
         </DropdownMenuItem>

apps/sim/app/workspace/[workspaceId]/logs/logs.tsx

@@ -92,9 +92,11 @@ import {
   getDisplayStatus,
   type LogStatus,
   parseDuration,
+  resolveLogWorkflowId,
   STATUS_CONFIG,
   StatusBadge,
   TriggerBadge,
+  workflowEditorPath,
 } from './utils'
 
 const LOGS_PER_PAGE = 50 as const
@@ -524,9 +526,9 @@ export default function Logs() {
   }, [contextMenuLog, workspaceId])
 
   const handleOpenWorkflow = useCallback(() => {
-    const wfId = contextMenuLog?.workflow?.id || contextMenuLog?.workflowId
+    const wfId = contextMenuLog ? resolveLogWorkflowId(contextMenuLog) : null
     if (wfId) {
-      window.open(`/workspace/${workspaceId}/w/${wfId}`, '_blank')
+      window.open(workflowEditorPath(workspaceId, wfId), '_blank')
     }
   }, [contextMenuLog, workspaceId])
 

apps/sim/app/workspace/[workspaceId]/logs/utils.test.ts

@@ -0,0 +1,55 @@
+/**
+ * @vitest-environment jsdom
+ */
+import { describe, expect, it } from 'vitest'
+import { resolveLogWorkflowId, workflowEditorPath } from './utils'
+
+describe('resolveLogWorkflowId', () => {
+  it('returns the nested workflow id when present', () => {
+    expect(
+      resolveLogWorkflowId({ trigger: 'manual', workflowId: 'wf-1', workflow: { id: 'wf-1' } })
+    ).toBe('wf-1')
+  })
+
+  it('falls back to workflowId when the workflow object is absent', () => {
+    expect(resolveLogWorkflowId({ trigger: 'api', workflowId: 'wf-2', workflow: null })).toBe(
+      'wf-2'
+    )
+  })
+
+  it('prefers the nested workflow id over workflowId when both are set', () => {
+    expect(
+      resolveLogWorkflowId({ trigger: 'manual', workflowId: 'stale', workflow: { id: 'fresh' } })
+    ).toBe('fresh')
+  })
+
+  it('returns null for Sim agent jobs even when a workflow id exists', () => {
+    expect(
+      resolveLogWorkflowId({
+        trigger: 'mothership',
+        workflowId: 'wf-3',
+        workflow: { id: 'wf-3' },
+      })
+    ).toBeNull()
+  })
+
+  it('returns null for a deleted workflow (both id fields empty)', () => {
+    expect(resolveLogWorkflowId({ trigger: 'manual', workflowId: null, workflow: null })).toBeNull()
+  })
+
+  it('returns null when ids are present but empty strings', () => {
+    expect(
+      resolveLogWorkflowId({ trigger: 'manual', workflowId: '', workflow: { id: '' } })
+    ).toBeNull()
+  })
+
+  it('treats a missing trigger as a normal workflow run', () => {
+    expect(resolveLogWorkflowId({ workflowId: 'wf-4' })).toBe('wf-4')
+  })
+})
+
+describe('workflowEditorPath', () => {
+  it('builds the workspace-scoped editor path', () => {
+    expect(workflowEditorPath('ws-1', 'wf-1')).toBe('/workspace/ws-1/w/wf-1')
+  })
+})

apps/sim/app/workspace/[workspaceId]/logs/utils.ts

@@ -17,6 +17,29 @@ export const LOG_COLUMNS = {
 
 export const DELETED_WORKFLOW_LABEL = 'Deleted Workflow'
 
+/**
+ * Resolves the workflow a log row points at, or null when there is nowhere to
+ * navigate. Sim agent jobs have no workflow of their own, and a deleted
+ * workflow leaves both id fields empty.
+ *
+ * Single source of truth for "is this log's workflow reachable" — the list row,
+ * its context menu, and the details panel must agree, or a row can render as
+ * "Deleted Workflow" while still linking somewhere.
+ */
+export function resolveLogWorkflowId(log: {
+  trigger?: string | null
+  workflowId?: string | null
+  workflow?: { id?: string } | null
+}): string | null {
+  if (log.trigger === 'mothership') return null
+  return log.workflow?.id || log.workflowId || null
+}
+
+/** Path to a workflow in the editor. */
+export function workflowEditorPath(workspaceId: string, workflowId: string): string {
+  return `/workspace/${workspaceId}/w/${workflowId}`
+}
+
 export type LogStatus =
   | 'error'
   | 'pending'