fix(log-view): keep the tab local when the host wired no setter

Cursor caught a real regression, and it was mine. The execution slideout
forwarded the table's `host` into `LogView` while deliberately passing no
`tab`/`onTabChange` — so on the tables page `hostOwnsUrl` was true, `activeTab`
was pinned to `tab ?? 'overview'`, and `setActiveTab` called an undefined
callback. The Trace tab was unreachable when opening a run from the tables page.
The panel host was unaffected, which is why the suite stayed green.

The slideout's own TSDoc already claimed the tab stayed local. The doc described
the intent; forwarding `host` contradicted it.

Fixed at both levels:

- The slideout mounts the log as `host='panel'` outright and no longer takes a
  `host` prop. A run slid in beside a table is embedded no matter where that
  table renders — it has no address on either surface, so the tab is local state
  by definition, not by inheritance from whatever the table happens to be.
- `LogView` treats the tab as URL-owned only when the host actually wired the
  controlled pair (`hostOwnsUrl(host) && onTabChange !== undefined`). A host that
  owns its URL but supplies no setter is embedding this view somewhere
  unaddressable; degrading to local state keeps the tabs working. Dead tabs are
  strictly worse than a tab that does not persist.

The guard rather than a discriminated union on `host`, because the table passes
`host` as a variable — a type-level union would not have fired at that mount.

Suite: 20951 passed.

Author: waleedlatif1

apps/sim/components/resources/log-view/log-view.tsx

@@ -324,7 +324,15 @@ export function LogView({
    * through `tab`/`onTabChange`; an embedded one keeps it local, so the panel
    * stops writing an unnamespaced key into its host's address bar.
    */
-  const urlOwned = hostOwnsUrl(host)
+  /**
+   * URL-owned only when the host actually wired the controlled pair. A host that
+   * owns its URL but passes no `onTabChange` is not deep-linking the tab — it is
+   * embedding this view somewhere unaddressable (the tables page's execution
+   * slideout), and treating it as controlled would leave `activeTab` pinned to
+   * the default with a setter that no-ops. Degrading to local state keeps the
+   * tabs working; dead tabs are strictly worse than a tab that does not persist.
+   */
+  const urlOwned = hostOwnsUrl(host) && onTabChange !== undefined
   const [localTab, setLocalTab] = useState<LogViewTab>('overview')
   const activeTab = urlOwned ? (tab ?? 'overview') : localTab
   const setActiveTab = useCallback(

apps/sim/components/resources/table-view/components/execution-slideout/execution-slideout.tsx

@@ -6,7 +6,7 @@ import { X } from '@sim/emcn/icons'
 import { LogView } from '@/components/resources/log-view'
 import type { WorkflowLogRow } from '@/lib/api/contracts/logs'
 import { useLogDetailsResize } from '@/hooks/use-log-details-resize'
-import { type ResourceGrants, type ResourceHost, workspaceSource } from '@/resources'
+import { type ResourceGrants, workspaceSource } from '@/resources'
 import { useLogDetailsUIStore } from '@/stores/logs/store'
 import { MAX_LOG_DETAILS_WIDTH_RATIO, MIN_LOG_DETAILS_WIDTH } from '@/stores/logs/utils'
 
@@ -16,7 +16,6 @@ interface ExecutionSlideoutProps {
   onClose: () => void
   workspaceId: string
   grants: ResourceGrants
-  host: ResourceHost
   /**
    * Whether this viewer may see trace internals. Required, not
    * optional-defaulting-to-true: forgetting it must fail to compile rather than
@@ -35,9 +34,13 @@ interface ExecutionSlideoutProps {
  * `useQueryState` and the permission context — four route couplings a table has
  * no use for — and it deep-links its active tab, which meant opening a run from
  * the tables page wrote `?tab` onto the tables URL, and onto the host page's URL
- * from the chat panel. This slideout omits `tab`/`onTabChange` entirely, so the
- * view keeps the tab local, which is correct for a panel that was never
- * addressable.
+ * from the chat panel. This slideout omits `tab`/`onTabChange` entirely and
+ * mounts the log as `host='panel'` — deliberately NOT the host the table itself
+ * is on. A run slid in beside a table is embedded no matter where that table
+ * renders: it has no address of its own on either surface, so its tab must stay
+ * local state. Forwarding the table's host instead made `hostOwnsUrl` true on
+ * the tables page, where the view then read a `tab` prop nobody passes and the
+ * Trace tab became unreachable.
  *
  * Only the chrome is reproduced: the frame, the resize handle, and a close
  * button. The logs page's prev/next and retry controls belong to a list this
@@ -49,7 +52,6 @@ export function ExecutionSlideout({
   onClose,
   workspaceId,
   grants,
-  host,
   showExecutionInternals,
   onNavigate,
 }: ExecutionSlideoutProps) {
@@ -99,7 +101,7 @@ export function ExecutionSlideout({
             <LogView
               source={source}
               grants={grants}
-              host={host}
+              host='panel'
               log={log}
               showExecutionInternals={showExecutionInternals}
               onNavigate={handleNavigate}

apps/sim/components/resources/table-view/table-view.tsx

@@ -1599,7 +1599,6 @@ export function TableView({
         onClose={onCloseSlideout}
         workspaceId={workspaceId}
         grants={grants}
-        host={host}
         showExecutionInternals={showExecutionInternals}
         onNavigate={onNavigate}
       />