improvement(chat): address cleanup-pass findings on the Chat gate

Effects: the panel's auto-select effect read the copilot chat list while the
list query was deliberately skipped, took "empty" for "deleted in another tab",
and cleared the user's selection — latching a ref that stopped it ever being
restored. Guarded on the same condition as the handoff listener.

Memo: `/w` filtered workflows through a useMemo whose array dependency was a
fresh `[]` on every render while the query had no data — the exact window the
page exists for — so it memoized nothing and re-fired the redirect effect. Keyed
on the workflow id instead. Same unstable-default problem on the sidebar's chat
list, where it invalidated five downstream memos; given a stable empty constant.

Callback: `handleCreateWorkflow` listed the whole mutation object in its deps,
which TanStack recreates every render. Harmless until this branch wired it into
the top nav, where it defeated `memo(SidebarNavItem)`.

React Query: Recently Deleted still fetched archived chats unconditionally and
offered restores into routes that now 404.

Also surfaces an error state on `/w` — it is the landing route now, so a failed
list fetch would otherwise spin forever behind a log line — fixes a spinner
using a token undefined in dark mode, and trims comments that restated code.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012ErcRgvi7VQBeKDQ3MBMha

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/page.tsx

@@ -2,9 +2,8 @@ import { redirect } from 'next/navigation'
 import { isChatEnabled } from '@/lib/core/config/env-flags'
 
 /**
- * Resolves the workspace landing route. With Chat enabled that is the chat
- * composer; otherwise `/w`, which selects the first workflow from the workflow
- * list the layout already prefetched.
+ * Resolves the workspace landing route: the chat composer, or `/w`, which
+ * selects the first workflow from the list the layout already prefetched.
  *
  * Deliberately does no work of its own. Resolving the workflow here would mean
  * a session lookup, an access check, and a query before anything renders — and

apps/sim/app/workspace/[workspaceId]/settings/components/recently-deleted/recently-deleted.tsx

@@ -9,6 +9,7 @@ import { useParams, useRouter } from 'next/navigation'
 import { useQueryStates } from 'nuqs'
 import { canMutateWorkspaceSettingsSection } from '@/components/settings/navigation'
 import type { ServedFolderResourceType } from '@/lib/api/contracts/folders'
+import { isChatEnabled } from '@/lib/core/config/env-flags'
 import { type ColumnOption, SortDropdown } from '@/app/workspace/[workspaceId]/components'
 import { RESOURCE_REGISTRY } from '@/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-registry'
 import type { MothershipResourceType } from '@/app/workspace/[workspaceId]/home/types'
@@ -226,7 +227,12 @@ export function RecentlyDeleted() {
   const tableFoldersQuery = useFolders(workspaceId, { scope: 'archived', resourceType: 'table' })
   const filesQuery = useWorkspaceFiles(workspaceId, 'archived')
   const workspaceFoldersQuery = useWorkspaceFileFolders(workspaceId, 'archived')
-  const chatsQuery = useMothershipChats(workspaceId, { scope: 'archived' })
+  // Restoring a chat navigates to a route that 404s with Chat off, and this
+  // query's loading/error state feeds the whole panel's.
+  const chatsQuery = useMothershipChats(workspaceId, {
+    scope: 'archived',
+    enabled: isChatEnabled,
+  })
 
   const restoreWorkflow = useRestoreWorkflow()
   const restoreFolder = useRestoreFolder()

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/panel.tsx

@@ -294,7 +294,10 @@ export const Panel = memo(function Panel() {
   // chat was deleted in another tab).
   const autoSelectAttemptedForRef = useRef<Set<string>>(new Set())
   useEffect(() => {
-    if (!activeWorkflowId) return
+    // The list query is skipped when the tab is unavailable, so an empty list
+    // there means "not fetched", not "deleted elsewhere" — clearing on it would
+    // discard the selection and latch the ref against ever restoring it.
+    if (!activeWorkflowId || !isCopilotTabAvailable) return
 
     if (copilotChatId && !copilotChatList.find((c) => c.id === copilotChatId)) {
       setCopilotChatId(undefined)
@@ -306,7 +309,7 @@ export const Panel = memo(function Panel() {
     if (copilotChatList.length === 0) return
     autoSelectAttemptedForRef.current.add(activeWorkflowId)
     setCopilotChatId(copilotChatList[0].id)
-  }, [copilotChatList, copilotChatId, activeWorkflowId, setCopilotChatId])
+  }, [copilotChatList, copilotChatId, activeWorkflowId, isCopilotTabAvailable, setCopilotChatId])
 
   useEffect(() => {
     posthogRef.current = posthog

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/hooks/use-workflow-operations.ts

@@ -23,14 +23,18 @@ export function useWorkflowOperations({ workspaceId }: UseWorkflowOperationsProp
     [workflows, workspaceId]
   )
 
+  // `mutate` is stable; the mutation object it hangs off is a new literal every
+  // render, so depending on the object would leave this callback unmemoized.
+  const createWorkflowMutate = createWorkflowMutation.mutate
+
   const handleCreateWorkflow = useCallback((): Promise<string | null> => {
     const { clearDiff } = useWorkflowDiffStore.getState()
     clearDiff()
 
     const name = generateCreativeWorkflowName()
     const id = generateId()
 
-    createWorkflowMutation.mutate({
+    createWorkflowMutate({
       workspaceId,
       name,
       id,
@@ -39,7 +43,7 @@ export function useWorkflowOperations({ workspaceId }: UseWorkflowOperationsProp
     useWorkflowRegistry.getState().markWorkflowCreating(id)
     router.push(`/workspace/${workspaceId}/w/${id}`)
     return Promise.resolve(id)
-  }, [createWorkflowMutation, workspaceId, router])
+  }, [createWorkflowMutate, workspaceId, router])
 
   return {
     workflows,

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx

@@ -92,6 +92,7 @@ import { useCustomBlockOverlayVersion } from '@/blocks/custom/client-overlay'
 import { useWorkspaceCredentials } from '@/hooks/queries/credentials'
 import { useFolderMap, useFolders } from '@/hooks/queries/folders'
 import { useKnowledgeBasesQuery } from '@/hooks/queries/kb/knowledge'
+import type { MothershipChatMetadata } from '@/hooks/queries/mothership-chats'
 import {
   useDeleteMothershipChat,
   useDeleteMothershipChats,
@@ -117,6 +118,13 @@ import { useSidebarStore } from '@/stores/sidebar/store'
 
 const logger = createLogger('Sidebar')
 
+/**
+ * Stable identity for the chat list's "no data" case. With Chat disabled the
+ * query never runs, so a `= []` default would mint a new array every render and
+ * invalidate every memo downstream of it.
+ */
+const EMPTY_CHATS: MothershipChatMetadata[] = []
+
 const SLACK_COMMUNITY_URL =
   'https://join.slack.com/t/sim-ott9864/shared_invite/zt-43lp8tc5v-0qrrqHGBKUsvQlpoouH~TA'
 
@@ -733,8 +741,6 @@ export const Sidebar = memo(function Sidebar({
   const topNavItems = useMemo(
     () =>
       [
-        // Same slot either way: the primary "start something new" action. With
-        // Chat off that is a workflow, since there is no composer to open.
         {
           id: 'home',
           label: isChatEnabled ? 'New chat' : 'New workflow',
@@ -824,24 +830,23 @@ export const Sidebar = memo(function Sidebar({
     [navigateToSettings, getSettingsHref, setSidebarWidth]
   )
 
-  const { data: fetchedChats = [], isLoading: chatsLoading } = useMothershipChats(workspaceId, {
-    enabled: isChatEnabled,
-  })
+  const { data: fetchedChats = EMPTY_CHATS, isLoading: chatsLoading } = useMothershipChats(
+    workspaceId,
+    { enabled: isChatEnabled }
+  )
 
   useMothershipChatEvents(workspaceId)
 
   /**
-   * Empty when Chat is disabled, which also drops the command palette's Chats
-   * group — `SearchGroups` renders nothing for an empty list.
+   * Stays empty when Chat is disabled, which also drops the command palette's
+   * Chats group — `SearchGroups` renders nothing for an empty list.
    */
   const chats = useMemo(
     () =>
-      isChatEnabled && fetchedChats
-        ? fetchedChats.map((t) => ({
-            ...t,
-            href: `/workspace/${workspaceId}/chat/${t.id}`,
-          }))
-        : [],
+      fetchedChats.map((t) => ({
+        ...t,
+        href: `/workspace/${workspaceId}/chat/${t.id}`,
+      })),
     [fetchedChats, workspaceId]
   )
 
@@ -1406,7 +1411,7 @@ export const Sidebar = memo(function Sidebar({
                           >
                             {chatsLoading ? (
                               <DropdownMenuItem disabled>
-                                <Loader className='h-[14px] w-[14px]' animate />
+                                <Loader className='size-[14px]' animate />
                                 Loading...
                               </DropdownMenuItem>
                             ) : chats.length === 0 ? (

apps/sim/app/workspace/[workspaceId]/w/page.tsx

@@ -1,6 +1,6 @@
 'use client'
 
-import { useEffect, useMemo } from 'react'
+import { useEffect } from 'react'
 import { Chip } from '@sim/emcn'
 import { createLogger } from '@sim/logger'
 import { useParams, useRouter } from 'next/navigation'
@@ -17,7 +17,7 @@ function Spinner() {
       className='size-[18px] animate-spin rounded-full'
       style={{
         background:
-          'conic-gradient(from 0deg, hsl(var(--muted-foreground)) 0deg 120deg, transparent 120deg 180deg, hsl(var(--muted-foreground)) 180deg 300deg, transparent 300deg 360deg)',
+          'conic-gradient(from 0deg, var(--text-icon) 0deg 120deg, transparent 120deg 180deg, var(--text-icon) 180deg 300deg, transparent 300deg 360deg)',
         mask: 'radial-gradient(farthest-side, transparent calc(100% - 1.5px), black calc(100% - 1.5px))',
         WebkitMask:
           'radial-gradient(farthest-side, transparent calc(100% - 1.5px), black calc(100% - 1.5px))',
@@ -34,10 +34,10 @@ export default function WorkflowsPage() {
   const { data: workflows = [], isLoading, isError, isPlaceholderData } = useWorkflows(workspaceId)
   const { handleCreateWorkflow, isCreatingWorkflow } = useWorkflowOperations({ workspaceId })
 
-  const workspaceWorkflows = useMemo(
-    () => workflows.filter((w) => w.workspaceId === workspaceId),
-    [workflows, workspaceId]
-  )
+  // An id rather than the filtered array: `data` defaults to a fresh `[]` while
+  // the query has no data, so an array dependency would re-fire this on every
+  // render — exactly during the load this page exists to cover.
+  const firstWorkflowId = workflows.find((w) => w.workspaceId === workspaceId)?.id
   const isResolving = isLoading || isPlaceholderData
 
   useEffect(() => {
@@ -48,30 +48,42 @@ export default function WorkflowsPage() {
       return
     }
 
-    if (workspaceWorkflows.length > 0) {
-      router.replace(`/workspace/${workspaceId}/w/${workspaceWorkflows[0].id}`)
+    if (firstWorkflowId) {
+      router.replace(`/workspace/${workspaceId}/w/${firstWorkflowId}`)
     }
-  }, [isResolving, isError, workspaceWorkflows, workspaceId, router])
+  }, [isResolving, isError, firstWorkflowId, workspaceId, router])
 
   /**
    * A workspace can legitimately reach zero workflows — deleting the last one,
    * archiving them all, or creating a workspace with `skipDefaultWorkflow`. This
    * is the terminal state for those paths now that the chat composer is no
    * longer a landing option, so it has to offer a way out rather than spin.
    */
-  const isEmpty = !isResolving && !isError && workspaceWorkflows.length === 0
+  const isEmpty = !isResolving && !isError && !firstWorkflowId
 
   return (
     <div className='flex h-full w-full flex-col overflow-hidden bg-[var(--bg)]'>
       <div className='relative h-full w-full flex-1 bg-[var(--bg)]'>
         <div className='workflow-container flex h-full items-center justify-center bg-[var(--bg)]'>
-          {isEmpty ? (
+          {isError ? (
+            // This is the landing route now, so a failed list fetch would
+            // otherwise spin forever with nothing but a log line.
+            <div className='flex flex-col items-center gap-3 text-center text-[var(--text-secondary)]'>
+              <div>
+                <p className='font-medium text-small'>Couldn't load workflows</p>
+                <p className='mt-1 text-caption'>Check your connection and try again.</p>
+              </div>
+              <Chip variant='primary' onClick={() => router.refresh()}>
+                Retry
+              </Chip>
+            </div>
+          ) : isEmpty ? (
             <div className='flex flex-col items-center gap-3 text-center text-[var(--text-secondary)]'>
               <div>
                 <p className='font-medium text-small'>No workflows yet</p>
                 <p className='mt-1 text-caption'>Create one to start building.</p>
               </div>
-              <Chip onClick={handleCreateWorkflow} disabled={isCreatingWorkflow}>
+              <Chip variant='primary' onClick={handleCreateWorkflow} disabled={isCreatingWorkflow}>
                 {isCreatingWorkflow ? 'Creating…' : 'Create workflow'}
               </Chip>
             </div>

apps/sim/lib/core/config/env-flags.ts

@@ -67,10 +67,9 @@ export const isCopilotBillingProtocolRequired = isTruthy(env.COPILOT_BILLING_PRO
  * This governs presentation only. Whether Chat can actually reach the mothership
  * is a separate question answered by `COPILOT_API_KEY`, which gates the paths
  * that need it (the Sim Chat block, prompt-job claims, inbox execution). Keeping
- * them separate is what lets this be a single variable: the key is a secret and
- * could never be read in the browser, but `NEXT_PUBLIC_CHAT_DISABLED` is not, so
- * `getEnv` resolves the same value from `process.env` on the server and
- * `window.__ENV` on the client — no twin to keep in sync.
+ * them separate is what lets this be a single variable: the secret key could
+ * never be read in the browser, but `NEXT_PUBLIC_CHAT_DISABLED` can — no twin to
+ * keep in sync.
  *
  * Read at module scope or inline during render only. Resolving it through
  * `useState`/`useEffect` would render chat surfaces before removing them.

apps/sim/lib/core/config/env.ts

@@ -605,7 +605,7 @@ export const env = createEnv({
     NEXT_PUBLIC_DISABLE_INVITATIONS:       z.boolean().optional(),                   // Disable workspace invitations globally (for self-hosted deployments)
     NEXT_PUBLIC_DISABLE_PUBLIC_API:        z.boolean().optional(),                   // Disable public API access UI toggle globally
     NEXT_PUBLIC_INBOX_ENABLED:             z.boolean().optional(),                   // Enable inbox (Sim Mailer) on self-hosted
-    NEXT_PUBLIC_CHAT_DISABLED:             z.boolean().optional(),                   // Hide the Chat module. Not a secret, so it is read via getEnv() on both server and client
+    NEXT_PUBLIC_CHAT_DISABLED:             z.boolean().optional(),                   // Hide the Chat module (Chat is shown when unset)
     NEXT_PUBLIC_SANDBOXES_ENABLED:         z.boolean().optional(),                   // Enable custom sandboxes on self-hosted
     NEXT_PUBLIC_EMAIL_PASSWORD_SIGNUP_ENABLED: z.boolean().optional().default(true), // Control visibility of email/password login forms
     NEXT_PUBLIC_TURNSTILE_SITE_KEY:        z.string().min(1).optional(),           // Cloudflare Turnstile site key for captcha widget

scripts/setup/modes/k8s.ts

@@ -282,7 +282,6 @@ interface ReleaseValues {
   postgresql?: { auth?: { password?: string } }
 }
 
-/** Values of the installed release, or `null` when there is no release yet. */
 function existingReleaseValues(context: string): ReleaseValues | null {
   const scope = ['--kube-context', context, '-n', NAMESPACE]
   const status = spawnSync('helm', ['status', RELEASE, ...scope], { stdio: 'ignore' })