fix

Author: icecrasher321

apps/sim/lib/execution/sandbox/bundles/docx.cjs

@@ -132,12 +132,18 @@ export class KnowledgeBaseFileOwnershipError extends Error {
  * referenced bindings are resolved in one query (no N+1 inside the `FOR UPDATE`
  * window). Single-document callers pass a one-element array.
  */
+function isKnowledgeBaseOwnedStorageKey(key: string): boolean {
+  return key.startsWith('kb/') || key.startsWith('knowledge-base/')
+}
+
 function getKnowledgeBaseStorageKeys(fileUrls: readonly string[]): string[] {
   return [
     ...new Set(
       fileUrls
         .map((url) => getKnowledgeBaseStorageKey(url))
-        .filter((key): key is string => typeof key === 'string' && key.startsWith('kb/'))
+        .filter(
+          (key): key is string => typeof key === 'string' && isKnowledgeBaseOwnedStorageKey(key)
+        )
     ),
   ]
 }

apps/sim/lib/execution/sandbox/bundles/pdf-lib.cjs

@@ -167,39 +167,43 @@ describe('knowledge document storage attribution', () => {
     )
   })
 
-  it('uses server-known file metadata size for quota, ledger, and document row', async () => {
-    const fileUrl = '/api/files/serve/kb%2Fverified-file?context=knowledge-base'
-    mockGetFileMetadataByKeys.mockResolvedValue([
-      {
-        key: 'kb/verified-file',
-        workspaceId: 'workspace-1',
-        userId: 'external-collaborator',
-        size: 8,
-      },
-    ])
-    mockIncrementStorageUsageForBillingContextInTx.mockResolvedValue(13)
+  it.each(['kb', 'knowledge-base'])(
+    'uses server-known %s file metadata size for quota, ledger, and document row',
+    async (keyPrefix) => {
+      const storageKey = `${keyPrefix}/verified-file`
+      const fileUrl = `/api/files/serve/${encodeURIComponent(storageKey)}?context=knowledge-base`
+      mockGetFileMetadataByKeys.mockResolvedValue([
+        {
+          key: storageKey,
+          workspaceId: 'workspace-1',
+          userId: 'external-collaborator',
+          size: 8,
+        },
+      ])
+      mockIncrementStorageUsageForBillingContextInTx.mockResolvedValue(13)
 
-    const result = await createSingleDocument(
-      {
-        filename: 'note.txt',
-        fileUrl,
-        fileSize: 5,
-        mimeType: 'text/plain',
-      },
-      'knowledge-base-1',
-      'request-1',
-      'external-collaborator'
-    )
+      const result = await createSingleDocument(
+        {
+          filename: 'note.txt',
+          fileUrl,
+          fileSize: 5,
+          mimeType: 'text/plain',
+        },
+        'knowledge-base-1',
+        'request-1',
+        'external-collaborator'
+      )
 
-    expect(mockCheckStorageQuotaForBillingContext).toHaveBeenCalledWith(STORAGE_CONTEXT, 8)
-    expect(mockIncrementStorageUsageForBillingContextInTx).toHaveBeenCalledWith(
-      expect.anything(),
-      STORAGE_CONTEXT,
-      8
-    )
-    expect(result.fileSize).toBe(8)
-    expect(dbChainMockFns.values).toHaveBeenCalledWith(expect.objectContaining({ fileSize: 8 }))
-  })
+      expect(mockCheckStorageQuotaForBillingContext).toHaveBeenCalledWith(STORAGE_CONTEXT, 8)
+      expect(mockIncrementStorageUsageForBillingContextInTx).toHaveBeenCalledWith(
+        expect.anything(),
+        STORAGE_CONTEXT,
+        8
+      )
+      expect(result.fileSize).toBe(8)
+      expect(dbChainMockFns.values).toHaveBeenCalledWith(expect.objectContaining({ fileSize: 8 }))
+    }
+  )
 
   it('decrements only exact bytes for document rows actually deleted', async () => {
     dbChainMockFns.where.mockResolvedValueOnce([