fix(tables): fire triggers for virtual table mutations

kerrylu · kerrylu · commit b3588ad100b5 · 2026-07-31T18:29:57.000-07:00
diff --git a/apps/sim/app/api/memory/[id]/route.ts b/apps/sim/app/api/memory/[id]/route.ts
@@ -13,6 +13,7 @@ import { parseRequest } from '@/lib/api/server'
 import { checkInternalAuth } from '@/lib/auth/hybrid'
 import { generateRequestId } from '@/lib/core/utils/request'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
+import { fireMemoryTableTrigger } from '@/lib/virtual-tables/memory-virtual-table.server'
 import { checkWorkspaceAccess } from '@/lib/workspaces/permissions/utils'
 
 const logger = createLogger('MemoryByIdAPI')
@@ -241,6 +242,7 @@ export const PUT = withRouteHandler(async (request: NextRequest, context: Memory
       .limit(1)
 
     const mem = updatedMemories[0]
+    void fireMemoryTableTrigger(mem, existingMemories[0], requestId)
 
     logger.info(`[${requestId}] Memory updated: ${id} for workspace: ${validatedWorkspaceId}`)
     return NextResponse.json(
diff --git a/apps/sim/app/api/memory/route.ts b/apps/sim/app/api/memory/route.ts
@@ -15,6 +15,7 @@ import { parseRequest } from '@/lib/api/server'
 import { checkInternalAuth } from '@/lib/auth/hybrid'
 import { generateRequestId } from '@/lib/core/utils/request'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
+import { fireMemoryTableTrigger } from '@/lib/virtual-tables/memory-virtual-table.server'
 import { checkWorkspaceAccess } from '@/lib/workspaces/permissions/utils'
 
 const logger = createLogger('MemoryAPI')
@@ -181,6 +182,12 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
     const now = new Date()
     const id = `mem_${generateId().replace(/-/g, '')}`
 
+    const previousMemories = await db
+      .select()
+      .from(memory)
+      .where(and(eq(memory.key, key), eq(memory.workspaceId, workspaceId)))
+      .limit(1)
+
     const { sql } = await import('drizzle-orm')
 
     await db
@@ -219,6 +226,7 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
     }
 
     const memoryRecord = allMemories[0]
+    void fireMemoryTableTrigger(memoryRecord, previousMemories[0] ?? null, requestId)
 
     return NextResponse.json(
       { success: true, data: { conversationId: memoryRecord.key, data: memoryRecord.data } },
diff --git a/apps/sim/executor/handlers/agent/memory.test.ts b/apps/sim/executor/handlers/agent/memory.test.ts
@@ -1,7 +1,17 @@
+import { dbChainMockFns, resetDbChainMock } from '@sim/testing'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { MEMORY } from '@/executor/constants'
 import { Memory } from '@/executor/handlers/agent/memory'
 import type { Message } from '@/executor/handlers/agent/types'
+import type { ExecutionContext } from '@/executor/types'
+
+const { mockFireMemoryTableTrigger } = vi.hoisted(() => ({
+  mockFireMemoryTableTrigger: vi.fn(),
+}))
+
+vi.mock('@/lib/virtual-tables/memory-virtual-table.server', () => ({
+  fireMemoryTableTrigger: mockFireMemoryTableTrigger,
+}))
 
 vi.mock('@/lib/tokenization/estimators', () => ({
   getAccurateTokenCount: vi.fn((text: string) => {
@@ -13,9 +23,46 @@ describe('Memory', () => {
   let memoryService: Memory
 
   beforeEach(() => {
+    vi.clearAllMocks()
+    resetDbChainMock()
     memoryService = new Memory()
   })
 
+  it('fires an update trigger when appending to an existing virtual-table row', async () => {
+    const previousRecord = {
+      id: 'memory-1',
+      workspaceId: 'workspace-1',
+      key: 'conversation-1',
+      data: [{ role: 'user', content: 'Hello' }],
+      createdAt: new Date('2026-01-01T00:00:00.000Z'),
+      updatedAt: new Date('2026-01-01T00:00:00.000Z'),
+      deletedAt: null,
+    }
+    const updatedRecord = {
+      ...previousRecord,
+      data: [...previousRecord.data, { role: 'assistant', content: 'Hi' }],
+      updatedAt: new Date('2026-01-02T00:00:00.000Z'),
+    }
+    dbChainMockFns.limit.mockResolvedValueOnce([previousRecord])
+    dbChainMockFns.returning.mockResolvedValueOnce([updatedRecord])
+
+    await memoryService.appendToMemory(
+      {
+        workspaceId: 'workspace-1',
+        executionId: 'execution-1',
+        metadata: { requestId: 'request-1' },
+      } as ExecutionContext,
+      { memoryType: 'conversation', conversationId: 'conversation-1' },
+      { role: 'assistant', content: 'Hi' }
+    )
+
+    expect(mockFireMemoryTableTrigger).toHaveBeenCalledWith(
+      updatedRecord,
+      previousRecord,
+      'request-1'
+    )
+  })
+
   describe('applyWindow (message-based)', () => {
     it('should keep last N messages', () => {
       const messages: Message[] = [
diff --git a/apps/sim/executor/handlers/agent/memory.ts b/apps/sim/executor/handlers/agent/memory.ts
@@ -5,6 +5,7 @@ import { generateId } from '@sim/utils/id'
 import { and, eq, sql } from 'drizzle-orm'
 import { redactObjectStrings } from '@/lib/logs/execution/pii-redaction'
 import { getAccurateTokenCount } from '@/lib/tokenization/estimators'
+import { fireMemoryTableTrigger } from '@/lib/virtual-tables/memory-virtual-table.server'
 import { MEMORY } from '@/executor/constants'
 import type { AgentInputs, Message } from '@/executor/handlers/agent/types'
 import type { ExecutionContext } from '@/executor/types'
@@ -66,7 +67,12 @@ export class Memory {
 
     const key = inputs.conversationId!
 
-    await this.appendMessage(workspaceId, key, message)
+    await this.appendMessage(
+      workspaceId,
+      key,
+      message,
+      ctx.metadata.requestId ?? ctx.executionId ?? ctx.workflowId
+    )
 
     logger.debug('Appended message to memory', {
       workspaceId,
@@ -110,7 +116,12 @@ export class Memory {
       messagesToStore.map((message) => this.maskContentForStorage(ctx, message))
     )
 
-    await this.seedMemoryRecord(workspaceId, key, messagesToStore)
+    await this.seedMemoryRecord(
+      workspaceId,
+      key,
+      messagesToStore,
+      ctx.metadata.requestId ?? ctx.executionId ?? ctx.workflowId
+    )
 
     logger.debug('Seeded memory', {
       workspaceId,
@@ -227,13 +238,14 @@ export class Memory {
   private async seedMemoryRecord(
     workspaceId: string,
     key: string,
-    messages: Message[]
+    messages: Message[],
+    requestId: string
   ): Promise<void> {
     const now = new Date()
 
     const sanitizedMessages = messages.map((message) => this.sanitizeMessageForStorage(message))
 
-    await db
+    const insertedRecords = await db
       .insert(memory)
       .values({
         id: generateId(),
@@ -244,14 +256,31 @@ export class Memory {
         updatedAt: now,
       })
       .onConflictDoNothing()
+      .returning()
+
+    const insertedRecord = insertedRecords[0]
+    if (insertedRecord) {
+      void fireMemoryTableTrigger(insertedRecord, null, requestId)
+    }
   }
 
-  private async appendMessage(workspaceId: string, key: string, message: Message): Promise<void> {
+  private async appendMessage(
+    workspaceId: string,
+    key: string,
+    message: Message,
+    requestId: string
+  ): Promise<void> {
     const now = new Date()
 
     const sanitizedMessage = this.sanitizeMessageForStorage(message)
 
-    await db
+    const previousRecords = await db
+      .select()
+      .from(memory)
+      .where(and(eq(memory.workspaceId, workspaceId), eq(memory.key, key)))
+      .limit(1)
+
+    const updatedRecords = await db
       .insert(memory)
       .values({
         id: generateId(),
@@ -268,6 +297,12 @@ export class Memory {
           updatedAt: now,
         },
       })
+      .returning()
+
+    const updatedRecord = updatedRecords[0]
+    if (updatedRecord) {
+      void fireMemoryTableTrigger(updatedRecord, previousRecords[0] ?? null, requestId)
+    }
   }
 
   private parsePositiveInt(value: string | undefined, defaultValue: number): number {
diff --git a/apps/sim/lib/virtual-tables/memory-virtual-table-trigger.server.test.ts b/apps/sim/lib/virtual-tables/memory-virtual-table-trigger.server.test.ts
@@ -0,0 +1,110 @@
+/**
+ * @vitest-environment node
+ */
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+const { mockFireTableTrigger } = vi.hoisted(() => ({
+  mockFireTableTrigger: vi.fn(),
+}))
+
+vi.mock('@/lib/table/trigger', () => ({
+  fireTableTrigger: mockFireTableTrigger,
+}))
+
+import { fireMemoryTableTrigger } from '@/lib/virtual-tables/memory-virtual-table.server'
+
+describe('fireMemoryTableTrigger', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    mockFireTableTrigger.mockResolvedValue(undefined)
+  })
+
+  it('maps an updated memory record to a virtual-table update event', async () => {
+    const previousRecord = {
+      id: 'memory-1',
+      workspaceId: 'workspace-1',
+      key: 'conversation-1',
+      data: [{ role: 'user', content: 'Hello' }],
+      createdAt: new Date('2026-01-01T00:00:00.000Z'),
+      updatedAt: new Date('2026-01-01T00:00:00.000Z'),
+      deletedAt: null,
+    }
+    const updatedRecord = {
+      ...previousRecord,
+      data: [...previousRecord.data, { role: 'assistant', content: 'Hi' }],
+      updatedAt: new Date('2026-01-02T00:00:00.000Z'),
+    }
+
+    await fireMemoryTableTrigger(updatedRecord, previousRecord, 'request-1')
+
+    expect(mockFireTableTrigger).toHaveBeenCalledWith(
+      'system_memory_workspace-1',
+      'Memory',
+      'update',
+      [
+        expect.objectContaining({
+          id: 'memory-1',
+          data: expect.objectContaining({
+            conversation_id: 'conversation-1',
+            message_count: 2,
+            updated_at: '2026-01-02T00:00:00.000Z',
+          }),
+        }),
+      ],
+      new Map([
+        [
+          'memory-1',
+          expect.objectContaining({
+            conversation_id: 'conversation-1',
+            message_count: 1,
+            updated_at: '2026-01-01T00:00:00.000Z',
+          }),
+        ],
+      ]),
+      expect.objectContaining({ columns: expect.any(Array) }),
+      'request-1'
+    )
+  })
+
+  it('maps a newly inserted memory record to a virtual-table insert event', async () => {
+    const insertedRecord = {
+      id: 'memory-1',
+      workspaceId: 'workspace-1',
+      key: 'conversation-1',
+      data: [{ role: 'user', content: 'Hello' }],
+      createdAt: new Date('2026-01-01T00:00:00.000Z'),
+      updatedAt: new Date('2026-01-01T00:00:00.000Z'),
+      deletedAt: null,
+    }
+
+    await fireMemoryTableTrigger(insertedRecord, null, 'request-1')
+
+    expect(mockFireTableTrigger).toHaveBeenCalledWith(
+      'system_memory_workspace-1',
+      'Memory',
+      'insert',
+      [expect.objectContaining({ id: 'memory-1' })],
+      null,
+      expect.any(Object),
+      'request-1'
+    )
+  })
+
+  it('does not emit table events for deleted memory records hidden from the virtual table', async () => {
+    await fireMemoryTableTrigger(
+      {
+        id: 'memory-1',
+        workspaceId: 'workspace-1',
+        key: 'conversation-1',
+        data: [],
+        createdAt: new Date('2026-01-01T00:00:00.000Z'),
+        updatedAt: new Date('2026-01-01T00:00:00.000Z'),
+        deletedAt: new Date('2026-01-02T00:00:00.000Z'),
+      },
+      null,
+      'request-1'
+    )
+
+    expect(mockFireTableTrigger).not.toHaveBeenCalled()
+  })
+})
diff --git a/apps/sim/lib/virtual-tables/memory-virtual-table.server.ts b/apps/sim/lib/virtual-tables/memory-virtual-table.server.ts
@@ -10,9 +10,11 @@ import {
   getMemoryTableId,
   isMemoryTableId,
   MEMORY_TABLE_COLUMNS,
+  MEMORY_TABLE_NAME,
   MEMORY_TABLE_SCHEMA,
   mapMemoryRecordToTableRow,
 } from '@/lib/virtual-tables/memory-virtual-table'
+import { fireVirtualTableTrigger } from '@/lib/virtual-tables/virtual-table-trigger.server'
 
 interface QueryMemoryTableRowsInput extends QueryOptions {
   workspaceId: string
@@ -21,6 +23,11 @@ interface QueryMemoryTableRowsInput extends QueryOptions {
 const MEMORY_TABLE_ID_PREFIX = getMemoryTableId('')
 const MEMORY_ROWS_SQL_NAME = 'memory_rows'
 
+type MemoryTableTriggerRecord = Pick<
+  typeof memory.$inferSelect,
+  'id' | 'workspaceId' | 'key' | 'data' | 'createdAt' | 'updatedAt' | 'deletedAt'
+>
+
 function referencesMemoryTranscript(value: unknown): boolean {
   if (Array.isArray(value)) return value.some(referencesMemoryTranscript)
   if (typeof value !== 'object' || value === null) return false
@@ -199,3 +206,34 @@ export async function queryMemoryTableRows({
     keysetValid: !sort,
   }
 }
+export async function fireMemoryTableTrigger(
+  currentRecord: MemoryTableTriggerRecord,
+  previousRecord: MemoryTableTriggerRecord | null,
+  requestId: string
+): Promise<void> {
+  if (currentRecord.deletedAt) return
+
+  const toTableRow = (record: MemoryTableTriggerRecord) =>
+    mapMemoryRecordToTableRow({
+      id: record.id,
+      key: record.key,
+      data: record.data as JsonValue,
+      messageCount: Array.isArray(record.data) ? record.data.length : 0,
+      createdAt: record.createdAt,
+      updatedAt: record.updatedAt,
+    })
+  const currentRow = toTableRow(currentRecord)
+  const previousRow = previousRecord ? toTableRow(previousRecord) : null
+
+  await fireVirtualTableTrigger({
+    table: {
+      id: getMemoryTableId(currentRecord.workspaceId),
+      name: MEMORY_TABLE_NAME,
+      schema: MEMORY_TABLE_SCHEMA,
+    },
+    eventType: previousRecord ? 'update' : 'insert',
+    rows: [currentRow],
+    previousRows: previousRow ? new Map([[currentRow.id, previousRow.data]]) : null,
+    requestId,
+  })
+}
diff --git a/apps/sim/lib/virtual-tables/memory-virtual-table.ts b/apps/sim/lib/virtual-tables/memory-virtual-table.ts
@@ -1,6 +1,7 @@
 import type { JsonValue, TableDefinition, TableRow, TableSchema } from '@/lib/table/types'
 
 const MEMORY_TABLE_ID_PREFIX = 'system_memory_'
+export const MEMORY_TABLE_NAME = 'Memory'
 
 export const MEMORY_TABLE_COLUMNS = {
   id: 'id',
@@ -97,7 +98,7 @@ export function createMemoryTableDefinition({
   return {
     id: getMemoryTableId(workspace.id),
     isVirtual: true,
-    name: 'Memory',
+    name: MEMORY_TABLE_NAME,
     description: 'Read-only agent conversation memory for this workspace',
     schema: MEMORY_TABLE_SCHEMA,
     metadata: null,
diff --git a/apps/sim/lib/virtual-tables/virtual-table-trigger.server.test.ts b/apps/sim/lib/virtual-tables/virtual-table-trigger.server.test.ts
diff --git a/apps/sim/lib/virtual-tables/virtual-table-trigger.server.ts b/apps/sim/lib/virtual-tables/virtual-table-trigger.server.ts
