Skip to content

Commit b2cb783

Browse files
waleedlatif1claude
andcommitted
refactor(selectors): replace hardcoded display name fallbacks with canonical-aware resolution
Use resolveDependencyValue to resolve context values for useSelectorDisplayName, eliminating manual || getStringValue('*Selector') fallbacks that required updating for each new selector pair. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 61d4cbf commit b2cb783

File tree

1 file changed

+24
-12
lines changed
  • apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block

1 file changed

+24
-12
lines changed

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/workflow-block.tsx

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -549,18 +549,30 @@ const SubBlockRow = memo(function SubBlockRow({
549549
return typeof option === 'string' ? option : option.label
550550
}, [subBlock, rawValue])
551551

552-
const domainValue = getStringValue('domain')
553-
const teamIdValue = getStringValue('teamId')
554-
const projectIdValue = getStringValue('projectId')
555-
const planIdValue = getStringValue('planId') || getStringValue('planSelector')
556-
const baseIdValue = getStringValue('baseId') || getStringValue('baseSelector')
557-
const datasetIdValue = getStringValue('datasetId') || getStringValue('datasetSelector')
558-
const serviceDeskIdValue =
559-
getStringValue('serviceDeskId') || getStringValue('serviceDeskSelector')
560-
const siteIdValue = getStringValue('siteId') || getStringValue('siteSelector')
561-
const collectionIdValue = getStringValue('collectionId') || getStringValue('collectionSelector')
562-
const spreadsheetIdValue = getStringValue('spreadsheetId')
563-
const fileIdValue = getStringValue('fileId')
552+
const resolveContextValue = useCallback(
553+
(key: string): string | undefined => {
554+
const resolved = resolveDependencyValue(
555+
key,
556+
rawValues,
557+
canonicalIndex || buildCanonicalIndex([]),
558+
canonicalModeOverrides
559+
)
560+
return typeof resolved === 'string' && resolved.length > 0 ? resolved : undefined
561+
},
562+
[rawValues, canonicalIndex, canonicalModeOverrides]
563+
)
564+
565+
const domainValue = resolveContextValue('domain')
566+
const teamIdValue = resolveContextValue('teamId')
567+
const projectIdValue = resolveContextValue('projectId')
568+
const planIdValue = resolveContextValue('planId')
569+
const baseIdValue = resolveContextValue('baseId')
570+
const datasetIdValue = resolveContextValue('datasetId')
571+
const serviceDeskIdValue = resolveContextValue('serviceDeskId')
572+
const siteIdValue = resolveContextValue('siteId')
573+
const collectionIdValue = resolveContextValue('collectionId')
574+
const spreadsheetIdValue = resolveContextValue('spreadsheetId')
575+
const fileIdValue = resolveContextValue('fileId')
564576

565577
const { displayName: selectorDisplayName } = useSelectorDisplayName({
566578
subBlock,

0 commit comments

Comments
 (0)